René's URL Explorer Experiment


Title: bpo-35113: Fix inspect.getsource to return correct source for inner classes by tirkarthi · Pull Request #10307 · python/cpython · GitHub

Open Graph Title: bpo-35113: Fix inspect.getsource to return correct source for inner classes by tirkarthi · Pull Request #10307 · python/cpython

X Title: bpo-35113: Fix inspect.getsource to return correct source for inner classes by tirkarthi · Pull Request #10307 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Previous approach used regex along with indentation of the match to return the source code. This caused below issues. This PR proposes usage of ast module to do correct parsing. Issues When a clas...

X Description: Previous approach used regex along with indentation of the match to return the source code. This caused below issues. This PR proposes usage of ast module to do correct parsing. Issues When a clas...

Opengraph URL: https://github.com/python/cpython/pull/10307

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:e1cd6142-e8f0-c3d4-b7d9-d367012d4289
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB724:2019D1:5BF2DF:7F9E6A:6A510448
html-safe-nonce12247e6daa30ffdda0239b94a6dd96f59a27d0bce3549db23f35476cd1424ba8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzI0OjIwMTlEMTo1QkYyREY6N0Y5RTZBOjZBNTEwNDQ4IiwidmlzaXRvcl9pZCI6IjUxMTI0MDY5MTQwMzUxNTYwNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac69be4a3f426fad1fb1334db5efead1de62d378db6808e0746bad082e24427f54
hovercard-subject-tagpull_request:228113555
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/10307/commits
twitter:imagehttps://opengraph.githubassets.com/4b18de11cfeb2224794861aac3940ef5490d2633cf6d23f0cebb949c83b73c29/python/cpython/pull/10307
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4b18de11cfeb2224794861aac3940ef5490d2633cf6d23f0cebb949c83b73c29/python/cpython/pull/10307
og:image:altPrevious approach used regex along with indentation of the match to return the source code. This caused below issues. This PR proposes usage of ast module to do correct parsing. Issues When a clas...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametirkarthi
hostnamegithub.com
expected-hostnamegithub.com
None38906a4da4e3e9fd88dfeacee232f5932c0c5f7495de3b4efc53ddfac7173d12
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release90441ea9b98e7491aa6ebcd135fccce4e2396f48
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/10307/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10307%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10307%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/10307/commits
Reloadhttps://github.com/python/cpython/pull/10307/commits
Reloadhttps://github.com/python/cpython/pull/10307/commits
Please reload this pagehttps://github.com/python/cpython/pull/10307/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/10307/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
tirkarthihttps://github.com/tirkarthi
python:masterhttps://github.com/python/cpython/tree/master
tirkarthi:bpo35113https://github.com/tirkarthi/cpython/tree/bpo35113
Conversationhttps://github.com/python/cpython/pull/10307
Commits17 (17)https://github.com/python/cpython/pull/10307/commits
Checkshttps://github.com/python/cpython/pull/10307/checks
Files changedhttps://github.com/python/cpython/pull/10307/files
bpo-35113: Fix inspect.getsource to return correct source for inner classeshttps://github.com/python/cpython/pull/10307/commits#top
tirkarthihttps://github.com/tirkarthi
python:masterhttps://github.com/python/cpython/tree/master
tirkarthi:bpo35113https://github.com/tirkarthi/cpython/tree/bpo35113
Use ast module to find class definitionhttps://github.com/python/cpython/pull/10307/commits/51aa20955ef674a24ea69ef7971e407e608853d4
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
51aa209https://github.com/python/cpython/pull/10307/commits/51aa20955ef674a24ea69ef7971e407e608853d4
https://github.com/python/cpython/tree/51aa20955ef674a24ea69ef7971e407e608853d4
Add NEWS entryhttps://github.com/python/cpython/pull/10307/commits/341933df107bb093b359194f1cb544c686ef0936
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
341933dhttps://github.com/python/cpython/pull/10307/commits/341933df107bb093b359194f1cb544c686ef0936
https://github.com/python/cpython/tree/341933df107bb093b359194f1cb544c686ef0936
Fix class with multiple children and move decorator code to the methodhttps://github.com/python/cpython/pull/10307/commits/dbbb38ee98d97aa6d93a6999c54d37a8499824ac
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
dbbb38ehttps://github.com/python/cpython/pull/10307/commits/dbbb38ee98d97aa6d93a6999c54d37a8499824ac
https://github.com/python/cpython/tree/dbbb38ee98d97aa6d93a6999c54d37a8499824ac
Fix PR commentshttps://github.com/python/cpython/pull/10307/commits/22b9c9c94e08527adc5843a8dd7a3552f6ea695b
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
22b9c9chttps://github.com/python/cpython/pull/10307/commits/22b9c9c94e08527adc5843a8dd7a3552f6ea695b
https://github.com/python/cpython/tree/22b9c9c94e08527adc5843a8dd7a3552f6ea695b
Add test for nested functions and async callshttps://github.com/python/cpython/pull/10307/commits/2655b1d633d9bec5655080235fa0a802eefcb503
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
2655b1dhttps://github.com/python/cpython/pull/10307/commits/2655b1d633d9bec5655080235fa0a802eefcb503
https://github.com/python/cpython/tree/2655b1d633d9bec5655080235fa0a802eefcb503
Fix pydoc test since comments are returned now correctlyhttps://github.com/python/cpython/pull/10307/commits/bd51f498f5663af7906a744a8a38cd2a15d1fa59
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
bd51f49https://github.com/python/cpython/pull/10307/commits/bd51f498f5663af7906a744a8a38cd2a15d1fa59
https://github.com/python/cpython/tree/bd51f498f5663af7906a744a8a38cd2a15d1fa59
Set event loop policy as None to fix environment related changehttps://github.com/python/cpython/pull/10307/commits/558895fbe5f59183f575415c27745c8e732c2eaa
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
558895fhttps://github.com/python/cpython/pull/10307/commits/558895fbe5f59183f575415c27745c8e732c2eaa
https://github.com/python/cpython/tree/558895fbe5f59183f575415c27745c8e732c2eaa
Refactor visit_AsyncFunctionDef and testshttps://github.com/python/cpython/pull/10307/commits/7d99c193ab7f16b23f7ee83c3a054d626b7ad3b7
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
7d99c19https://github.com/python/cpython/pull/10307/commits/7d99c193ab7f16b23f7ee83c3a054d626b7ad3b7
https://github.com/python/cpython/tree/7d99c193ab7f16b23f7ee83c3a054d626b7ad3b7
Refactor to use local variables and fix testshttps://github.com/python/cpython/pull/10307/commits/5f843442716b111b3012b20094e794398311a4f3
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
5f84344https://github.com/python/cpython/pull/10307/commits/5f843442716b111b3012b20094e794398311a4f3
https://github.com/python/cpython/tree/5f843442716b111b3012b20094e794398311a4f3
Add patch attributionhttps://github.com/python/cpython/pull/10307/commits/8a63f36d38269b7972c9c8397e400e0d0be282f5
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
8a63f36https://github.com/python/cpython/pull/10307/commits/8a63f36d38269b7972c9c8397e400e0d0be282f5
https://github.com/python/cpython/tree/8a63f36d38269b7972c9c8397e400e0d0be282f5
Use self.addCleanup for asynciohttps://github.com/python/cpython/pull/10307/commits/4c7a61b3c476b21b6e6c9f0d3ccfe4f17042495a
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
4c7a61bhttps://github.com/python/cpython/pull/10307/commits/4c7a61b3c476b21b6e6c9f0d3ccfe4f17042495a
https://github.com/python/cpython/tree/4c7a61b3c476b21b6e6c9f0d3ccfe4f17042495a
Rename ClassVisitor to ClassFinder and fix asyncio cleanuphttps://github.com/python/cpython/pull/10307/commits/30865f60b45cef353c1936225718347e1fca9f88
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
30865f6https://github.com/python/cpython/pull/10307/commits/30865f60b45cef353c1936225718347e1fca9f88
https://github.com/python/cpython/tree/30865f60b45cef353c1936225718347e1fca9f88
Return first class inside conditional in case of multiple definitions. Remove decorator for class source.https://github.com/python/cpython/pull/10307/commits/054c3179ea438456f1490baf541d44f01d509151
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
054c317https://github.com/python/cpython/pull/10307/commits/054c3179ea438456f1490baf541d44f01d509151
https://github.com/python/cpython/tree/054c3179ea438456f1490baf541d44f01d509151
Add docstring to make the test correcthttps://github.com/python/cpython/pull/10307/commits/26d1c9616dd380b4bfd41751178e2cfada186d18
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
26d1c96https://github.com/python/cpython/pull/10307/commits/26d1c9616dd380b4bfd41751178e2cfada186d18
https://github.com/python/cpython/tree/26d1c9616dd380b4bfd41751178e2cfada186d18
Modify NEWS entry regarding decoratorshttps://github.com/python/cpython/pull/10307/commits/d7ae710457be3e8d5c276ef775245b242337d2a3
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
d7ae710https://github.com/python/cpython/pull/10307/commits/d7ae710457be3e8d5c276ef775245b242337d2a3
https://github.com/python/cpython/tree/d7ae710457be3e8d5c276ef775245b242337d2a3
Return decorators too for bpo-15856https://github.com/python/cpython/pull/10307/commits/aef42284a16b477535534f827992b327d9a202b9
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
aef4228https://github.com/python/cpython/pull/10307/commits/aef42284a16b477535534f827992b327d9a202b9
https://github.com/python/cpython/tree/aef42284a16b477535534f827992b327d9a202b9
Move ast and the class source code to top. Use proper Exception.https://github.com/python/cpython/pull/10307/commits/797c48dd82e37849ea14e7fb907128df49b06ac7
https://github.com/tirkarthi
tirkarthihttps://github.com/python/cpython/commits?author=tirkarthi
797c48dhttps://github.com/python/cpython/pull/10307/commits/797c48dd82e37849ea14e7fb907128df49b06ac7
https://github.com/python/cpython/tree/797c48dd82e37849ea14e7fb907128df49b06ac7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.