René's URL Explorer Experiment


Title: gh-100227: Make the Global PyModuleDef Cache Safe for Isolated Interpreters by ericsnowcurrently · Pull Request #102938 · python/cpython · GitHub

Open Graph Title: gh-100227: Make the Global PyModuleDef Cache Safe for Isolated Interpreters by ericsnowcurrently · Pull Request #102938 · python/cpython

X Title: gh-100227: Make the Global PyModuleDef Cache Safe for Isolated Interpreters by ericsnowcurrently · Pull Request #102938 · python/cpython

Description: This is a similar change to gh-102925, but applied to the global cache of PyModuleDefs instead of the interned strings. Note that the cache is only used for legacy extension modules and not for mu...

Open Graph Description: This is a similar change to gh-102925, but applied to the global cache of PyModuleDefs instead of the interned strings. Note that the cache is only used for legacy extension modules and not for mu...

X Description: This is a similar change to gh-102925, but applied to the global cache of PyModuleDefs instead of the interned strings. Note that the cache is only used for legacy extension modules and not for mu...

Opengraph URL: https://github.com/python/cpython/pull/102938

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4ca4d055-145d-9ba1-b166-129739371815
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FC4:23CDC6:17E03CF:1FFD692:6969A975
html-safe-nonceacea2c3b4358315e1233ef74039d799434df7c29871a7c5312c09f43ce94bc79
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkM0OjIzQ0RDNjoxN0UwM0NGOjFGRkQ2OTI6Njk2OUE5NzUiLCJ2aXNpdG9yX2lkIjoiNjAwNTgxMTg5NjAwODY4MTg0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacce9504df763b6c514b142da920b57b1e6df5bbd5710c83ba69354709c727c225
hovercard-subject-tagpull_request:1286597199
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/102938/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f1c8ca823ffcc341d59dff384f9607bb9828ade765f33a76e64fb7dd2568c598/python/cpython/pull/102938
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f1c8ca823ffcc341d59dff384f9607bb9828ade765f33a76e64fb7dd2568c598/python/cpython/pull/102938
og:image:altThis is a similar change to gh-102925, but applied to the global cache of PyModuleDefs instead of the interned strings. Note that the cache is only used for legacy extension modules and not for mu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/102938#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102938
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102938
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/102938
Reloadhttps://github.com/python/cpython/pull/102938
Reloadhttps://github.com/python/cpython/pull/102938
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/102938
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/102938
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/102938#issue-comment-box
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:extensions-dict-owned-by-main-interpreterhttps://github.com/ericsnowcurrently/cpython/tree/extensions-dict-owned-by-main-interpreter
gh-100227: Make the Global PyModuleDef Cache Safe for Isolated Interpreters https://github.com/python/cpython/pull/102938#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:extensions-dict-owned-by-main-interpreterhttps://github.com/ericsnowcurrently/cpython/tree/extensions-dict-owned-by-main-interpreter
Conversation 1 https://github.com/python/cpython/pull/102938
Commits 23 https://github.com/python/cpython/pull/102938/commits
Checks 0 https://github.com/python/cpython/pull/102938/checks
Files changed https://github.com/python/cpython/pull/102938/files
Please reload this pagehttps://github.com/python/cpython/pull/102938
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Mar 22, 2023https://github.com/python/cpython/pull/102938#issue-1636608121
Please reload this pagehttps://github.com/python/cpython/pull/102938
gh-102925https://github.com/python/cpython/pull/102925
gh-102925https://github.com/python/cpython/pull/102925
Improve Interpreter Isolation #100227https://github.com/python/cpython/issues/100227
Please reload this pagehttps://github.com/python/cpython/pull/102938
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
March 22, 2023 11:59https://github.com/python/cpython/pull/102938#commits-pushed-546b934
https://github.com/ericsnowcurrently
Factor out add_threadstate().https://github.com/python/cpython/pull/102938/commits/546b934ae1d5fd72c9806f7242d2218f80bac740
546b934https://github.com/python/cpython/pull/102938/commits/546b934ae1d5fd72c9806f7242d2218f80bac740
https://github.com/ericsnowcurrently
Add _PyThreadState_InitDetached().https://github.com/python/cpython/pull/102938/commits/0bcd136ce103558500e70360e75b7d861debfdf2
0bcd136https://github.com/python/cpython/pull/102938/commits/0bcd136ce103558500e70360e75b7d861debfdf2
https://github.com/ericsnowcurrently
Add _PyThreadState_ClearDetached().https://github.com/python/cpython/pull/102938/commits/35d531064e2210b68d0bbc20f5903750251b0d04
35d5310https://github.com/python/cpython/pull/102938/commits/35d531064e2210b68d0bbc20f5903750251b0d04
https://github.com/ericsnowcurrently
Add _PyRuntime.cached_objects.main_tstate.https://github.com/python/cpython/pull/102938/commits/cba9e34b991f77d28510dc63c636896a21c257fd
cba9e34https://github.com/python/cpython/pull/102938/commits/cba9e34b991f77d28510dc63c636896a21c257fd
https://github.com/ericsnowcurrently
Add _Py_AcquireGlobalObjectsState() and _Py_ReleaseGlobalObjectsState().https://github.com/python/cpython/pull/102938/commits/3b1bb8bd677630e3f905896bb84a5fa2e0cb616b
3b1bb8bhttps://github.com/python/cpython/pull/102938/commits/3b1bb8bd677630e3f905896bb84a5fa2e0cb616b
https://github.com/ericsnowcurrently
Add _Py_AddToGlobalDict().https://github.com/python/cpython/pull/102938/commits/eb42aa1a83df5e29dc73dad442ae7306f92cca9d
eb42aa1https://github.com/python/cpython/pull/102938/commits/eb42aa1a83df5e29dc73dad442ae7306f92cca9d
https://github.com/ericsnowcurrently
Drop _Py_AcquireGlobalObjectsState() and _Py_ReleaseGlobalObjectsStat…https://github.com/python/cpython/pull/102938/commits/4e9da2da68655c6fdb106ef098bdf9510484ca97
4e9da2dhttps://github.com/python/cpython/pull/102938/commits/4e9da2da68655c6fdb106ef098bdf9510484ca97
https://github.com/ericsnowcurrently
Add acquire_global_objects_lock() and release_global_objects_lock().https://github.com/python/cpython/pull/102938/commits/6216207cfa3410a20bed9161bb9f067ded8f97fe
6216207https://github.com/python/cpython/pull/102938/commits/6216207cfa3410a20bed9161bb9f067ded8f97fe
https://github.com/ericsnowcurrently
Add some TODO comments.https://github.com/python/cpython/pull/102938/commits/3c007c09531121ae5fef7b73c2499df5254ad4b4
3c007c0https://github.com/python/cpython/pull/102938/commits/3c007c09531121ae5fef7b73c2499df5254ad4b4
https://github.com/ericsnowcurrently
Factor out store_interned().https://github.com/python/cpython/pull/102938/commits/7d95514984a496c89a737d501c178e46b954b23e
7d95514https://github.com/python/cpython/pull/102938/commits/7d95514984a496c89a737d501c178e46b954b23e
https://github.com/ericsnowcurrently
Store a thread state to use just for interned strings.https://github.com/python/cpython/pull/102938/commits/5c20b84033b1a71a0e8db0245bfb6973f0482b32
5c20b84https://github.com/python/cpython/pull/102938/commits/5c20b84033b1a71a0e8db0245bfb6973f0482b32
https://github.com/ericsnowcurrently
Always use the main interpreter when possibly resizing the interned d…https://github.com/python/cpython/pull/102938/commits/a3ae02aeceb894cd9d2a814a79fb78ebefd65e58
a3ae02ahttps://github.com/python/cpython/pull/102938/commits/a3ae02aeceb894cd9d2a814a79fb78ebefd65e58
https://github.com/ericsnowcurrently
Use _PyRuntime.cached_objects.main_tstate instead.https://github.com/python/cpython/pull/102938/commits/d5fbc37edb8e2c3e983ef79e78c861e1e16b9ce8
d5fbc37https://github.com/python/cpython/pull/102938/commits/d5fbc37edb8e2c3e983ef79e78c861e1e16b9ce8
https://github.com/ericsnowcurrently
Add _PyThreadState_IsBound() and _PyThreadState_Unbind().https://github.com/python/cpython/pull/102938/commits/459325f611aad5af80728c5cfdff43f68492ac21
459325fhttps://github.com/python/cpython/pull/102938/commits/459325f611aad5af80728c5cfdff43f68492ac21
https://github.com/ericsnowcurrently
Make sure the one-off tstate is bound before using it.https://github.com/python/cpython/pull/102938/commits/4f25244cd227b7b64a18f26a688f0ab0745c2d5d
4f25244https://github.com/python/cpython/pull/102938/commits/4f25244cd227b7b64a18f26a688f0ab0745c2d5d
https://github.com/ericsnowcurrently
Use _Py_AcquireGlobalObjectsState() in store_interned().https://github.com/python/cpython/pull/102938/commits/e68535ada0fe397c7d8c26e6f193b1e008122544
e68535ahttps://github.com/python/cpython/pull/102938/commits/e68535ada0fe397c7d8c26e6f193b1e008122544
https://github.com/ericsnowcurrently
Use _Py_AddToGlobalDict().https://github.com/python/cpython/pull/102938/commits/22753b33ad22bd50ba9ce207de6a41311c1e6ca1
22753b3https://github.com/python/cpython/pull/102938/commits/22753b33ad22bd50ba9ce207de6a41311c1e6ca1
https://github.com/ericsnowcurrently
Move the extensions dict to _PyRuntime.cached_objects.https://github.com/python/cpython/pull/102938/commits/5c7bfd7565c77c883feaca1b0501705c16ec3b7a
5c7bfd7https://github.com/python/cpython/pull/102938/commits/5c7bfd7565c77c883feaca1b0501705c16ec3b7a
https://github.com/ericsnowcurrently
Add _Py_GetFromGlobalDict().https://github.com/python/cpython/pull/102938/commits/f1a33ce6f60e7e1dce6a9f0d1aeb1e27cc446d50
f1a33cehttps://github.com/python/cpython/pull/102938/commits/f1a33ce6f60e7e1dce6a9f0d1aeb1e27cc446d50
https://github.com/ericsnowcurrently
Add _Py_PopFromGlobalDict().https://github.com/python/cpython/pull/102938/commits/10e6d69b4bbad88b1e43b87dbd0abd9693668626
10e6d69https://github.com/python/cpython/pull/102938/commits/10e6d69b4bbad88b1e43b87dbd0abd9693668626
https://github.com/ericsnowcurrently
Adjust _Py_AddToGlobalDict().https://github.com/python/cpython/pull/102938/commits/7dbae684de3ed2a5bfd9e4f621169429e7db88cf
7dbae68https://github.com/python/cpython/pull/102938/commits/7dbae684de3ed2a5bfd9e4f621169429e7db88cf
https://github.com/ericsnowcurrently
Use _Py_PopFromGlobalDict() in unicode_dealloc().https://github.com/python/cpython/pull/102938/commits/3e08c1f52fb5ea77da943ae64f79103952486972
3e08c1fhttps://github.com/python/cpython/pull/102938/commits/3e08c1f52fb5ea77da943ae64f79103952486972
https://github.com/ericsnowcurrently
Use the global dict API in import.c.https://github.com/python/cpython/pull/102938/commits/1039a601d2d7812f5108a9b3809d63445d82e886
1039a60https://github.com/python/cpython/pull/102938/commits/1039a601d2d7812f5108a9b3809d63445d82e886
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Mar 22, 2023https://github.com/python/cpython/pull/102938#event-8821866384
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
brettcannonhttps://github.com/brettcannon
encukouhttps://github.com/encukou
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/8709697292c67254ba836d7e88d1eba08c4a351a/.github/CODEOWNERS#L67
March 22, 2023 22:56https://github.com/python/cpython/pull/102938#event-8821866461
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 22, 2023 https://github.com/python/cpython/pull/102938#ref-issue-1495359092
Improve Interpreter Isolation #100227 https://github.com/python/cpython/issues/100227
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 22, 2023https://github.com/python/cpython/pull/102938#event-8821866856
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Mar 28, 2023https://github.com/python/cpython/pull/102938#issuecomment-1487067053
gh-103084https://github.com/python/cpython/pull/103084
Please reload this pagehttps://github.com/python/cpython/pull/102938
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Mar 28, 2023https://github.com/python/cpython/pull/102938#event-8866615963
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Mar 28, 2023 https://github.com/python/cpython/pull/102938#ref-pullrequest-1644132942
gh-100227: Make the Global PyModuleDef Cache Safe for Isolated Interpreters #103084 https://github.com/python/cpython/pull/103084
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102938
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/warsaw
warsaw https://github.com/warsaw
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/102938
https://github.com/ericsnowcurrently
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.