René's URL Explorer Experiment


Title: gh-84436: Make Interned Strings Immortal by ericsnowcurrently · Pull Request #102887 · python/cpython · GitHub

Open Graph Title: gh-84436: Make Interned Strings Immortal by ericsnowcurrently · Pull Request #102887 · python/cpython

X Title: gh-84436: Make Interned Strings Immortal by ericsnowcurrently · Pull Request #102887 · python/cpython

Description: This is a prerequisite for a per-interpreter GIL if the interned strings dict stays global (e.g. gh-102858). (This is based on gh-102925. It also requires gh-19474.) Issue: Fixing Copy on Writes...

Open Graph Description: This is a prerequisite for a per-interpreter GIL if the interned strings dict stays global (e.g. gh-102858). (This is based on gh-102925. It also requires gh-19474.) Issue: Fixing Copy on Writes...

X Description: This is a prerequisite for a per-interpreter GIL if the interned strings dict stays global (e.g. gh-102858). (This is based on gh-102925. It also requires gh-19474.) Issue: Fixing Copy on Writes...

Opengraph URL: https://github.com/python/cpython/pull/102887

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7cbc2fb3-5fcb-bfa3-ebbd-8888a7e0b936
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB226:7F615:92A52D:C526E5:696990D2
html-safe-nonce231f949be952c23cd26e23566d018dbf4045a62b923b7065e442af61abc5c53e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjI2OjdGNjE1OjkyQTUyRDpDNTI2RTU6Njk2OTkwRDIiLCJ2aXNpdG9yX2lkIjoiNTYzMDE5ODk0NTYzNTk5NTg1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacacd6be1388b16a698019e9b3d61dfb51ceaca205905fc1eb0b916c31406aef01
hovercard-subject-tagpull_request:1284946588
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/102887/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f0e6fe1387b9e5d3014c55354b1c4129d845d642df874a9067760075f373c00b/python/cpython/pull/102887
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f0e6fe1387b9e5d3014c55354b1c4129d845d642df874a9067760075f373c00b/python/cpython/pull/102887
og:image:altThis is a prerequisite for a per-interpreter GIL if the interned strings dict stays global (e.g. gh-102858). (This is based on gh-102925. It also requires gh-19474.) Issue: Fixing Copy on Writes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
None3542e147982176a7ebaa23dfb559c8af16f721c03ec560c68c56b64a0f35e751
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaf80af7cc9e3de9c336f18b208a600950a3c187c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/102887#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102887
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102887
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/102887
Reloadhttps://github.com/python/cpython/pull/102887
Reloadhttps://github.com/python/cpython/pull/102887
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/102887
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/102887
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/102887#issue-comment-box
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:immortal-interned-stringshttps://github.com/ericsnowcurrently/cpython/tree/immortal-interned-strings
gh-84436: Make Interned Strings Immortal https://github.com/python/cpython/pull/102887#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:immortal-interned-stringshttps://github.com/ericsnowcurrently/cpython/tree/immortal-interned-strings
Conversation 1 https://github.com/python/cpython/pull/102887
Commits 19 https://github.com/python/cpython/pull/102887/commits
Checks 0 https://github.com/python/cpython/pull/102887/checks
Files changed https://github.com/python/cpython/pull/102887/files
Please reload this pagehttps://github.com/python/cpython/pull/102887
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Mar 21, 2023https://github.com/python/cpython/pull/102887#issue-1634726663
Please reload this pagehttps://github.com/python/cpython/pull/102887
gh-102858https://github.com/python/cpython/pull/102858
gh-102925https://github.com/python/cpython/pull/102925
gh-19474https://github.com/python/cpython/pull/19474
Fixing Copy on Writes from reference counting and immortal objects #84436https://github.com/python/cpython/issues/84436
Please reload this pagehttps://github.com/python/cpython/pull/102887
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Mar 21, 2023https://github.com/python/cpython/pull/102887#event-8810478839
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 21, 2023 https://github.com/python/cpython/pull/102887#ref-issue-1199034218
Fixing Copy on Writes from reference counting and immortal objects #84436 https://github.com/python/cpython/issues/84436
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 21, 2023https://github.com/python/cpython/pull/102887#event-8810479926
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Mar 21, 2023 https://github.com/python/cpython/pull/102887#ref-pullrequest-1633003085
gh-100227: Make the Global Interned Dict Safe for Isolated Interpreters #102858 https://github.com/python/cpython/pull/102858
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Mar 21, 2023https://github.com/python/cpython/pull/102887#issuecomment-1478624579
@kumaraditya303https://github.com/kumaraditya303
Please reload this pagehttps://github.com/python/cpython/pull/102887
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
March 22, 2023 11:59https://github.com/python/cpython/pull/102887#commits-pushed-546b934
https://github.com/ericsnowcurrently
Factor out add_threadstate().https://github.com/python/cpython/pull/102887/commits/546b934ae1d5fd72c9806f7242d2218f80bac740
546b934https://github.com/python/cpython/pull/102887/commits/546b934ae1d5fd72c9806f7242d2218f80bac740
https://github.com/ericsnowcurrently
Add _PyThreadState_InitDetached().https://github.com/python/cpython/pull/102887/commits/0bcd136ce103558500e70360e75b7d861debfdf2
0bcd136https://github.com/python/cpython/pull/102887/commits/0bcd136ce103558500e70360e75b7d861debfdf2
https://github.com/ericsnowcurrently
Add _PyThreadState_ClearDetached().https://github.com/python/cpython/pull/102887/commits/35d531064e2210b68d0bbc20f5903750251b0d04
35d5310https://github.com/python/cpython/pull/102887/commits/35d531064e2210b68d0bbc20f5903750251b0d04
https://github.com/ericsnowcurrently
Add _PyRuntime.cached_objects.main_tstate.https://github.com/python/cpython/pull/102887/commits/cba9e34b991f77d28510dc63c636896a21c257fd
cba9e34https://github.com/python/cpython/pull/102887/commits/cba9e34b991f77d28510dc63c636896a21c257fd
https://github.com/ericsnowcurrently
Add _Py_AcquireGlobalObjectsState() and _Py_ReleaseGlobalObjectsState().https://github.com/python/cpython/pull/102887/commits/3b1bb8bd677630e3f905896bb84a5fa2e0cb616b
3b1bb8bhttps://github.com/python/cpython/pull/102887/commits/3b1bb8bd677630e3f905896bb84a5fa2e0cb616b
https://github.com/ericsnowcurrently
Add _Py_AddToGlobalDict().https://github.com/python/cpython/pull/102887/commits/eb42aa1a83df5e29dc73dad442ae7306f92cca9d
eb42aa1https://github.com/python/cpython/pull/102887/commits/eb42aa1a83df5e29dc73dad442ae7306f92cca9d
https://github.com/ericsnowcurrently
Drop _Py_AcquireGlobalObjectsState() and _Py_ReleaseGlobalObjectsStat…https://github.com/python/cpython/pull/102887/commits/4e9da2da68655c6fdb106ef098bdf9510484ca97
4e9da2dhttps://github.com/python/cpython/pull/102887/commits/4e9da2da68655c6fdb106ef098bdf9510484ca97
https://github.com/ericsnowcurrently
Add acquire_global_objects_lock() and release_global_objects_lock().https://github.com/python/cpython/pull/102887/commits/6216207cfa3410a20bed9161bb9f067ded8f97fe
6216207https://github.com/python/cpython/pull/102887/commits/6216207cfa3410a20bed9161bb9f067ded8f97fe
https://github.com/ericsnowcurrently
Add some TODO comments.https://github.com/python/cpython/pull/102887/commits/3c007c09531121ae5fef7b73c2499df5254ad4b4
3c007c0https://github.com/python/cpython/pull/102887/commits/3c007c09531121ae5fef7b73c2499df5254ad4b4
https://github.com/ericsnowcurrently
Factor out store_interned().https://github.com/python/cpython/pull/102887/commits/7d95514984a496c89a737d501c178e46b954b23e
7d95514https://github.com/python/cpython/pull/102887/commits/7d95514984a496c89a737d501c178e46b954b23e
https://github.com/ericsnowcurrently
Store a thread state to use just for interned strings.https://github.com/python/cpython/pull/102887/commits/5c20b84033b1a71a0e8db0245bfb6973f0482b32
5c20b84https://github.com/python/cpython/pull/102887/commits/5c20b84033b1a71a0e8db0245bfb6973f0482b32
https://github.com/ericsnowcurrently
Always use the main interpreter when possibly resizing the interned d…https://github.com/python/cpython/pull/102887/commits/a3ae02aeceb894cd9d2a814a79fb78ebefd65e58
a3ae02ahttps://github.com/python/cpython/pull/102887/commits/a3ae02aeceb894cd9d2a814a79fb78ebefd65e58
https://github.com/ericsnowcurrently
Use _PyRuntime.cached_objects.main_tstate instead.https://github.com/python/cpython/pull/102887/commits/d5fbc37edb8e2c3e983ef79e78c861e1e16b9ce8
d5fbc37https://github.com/python/cpython/pull/102887/commits/d5fbc37edb8e2c3e983ef79e78c861e1e16b9ce8
https://github.com/ericsnowcurrently
Add _PyThreadState_IsBound() and _PyThreadState_Unbind().https://github.com/python/cpython/pull/102887/commits/459325f611aad5af80728c5cfdff43f68492ac21
459325fhttps://github.com/python/cpython/pull/102887/commits/459325f611aad5af80728c5cfdff43f68492ac21
https://github.com/ericsnowcurrently
Make sure the one-off tstate is bound before using it.https://github.com/python/cpython/pull/102887/commits/4f25244cd227b7b64a18f26a688f0ab0745c2d5d
4f25244https://github.com/python/cpython/pull/102887/commits/4f25244cd227b7b64a18f26a688f0ab0745c2d5d
https://github.com/ericsnowcurrently
Use _Py_AcquireGlobalObjectsState() in store_interned().https://github.com/python/cpython/pull/102887/commits/e68535ada0fe397c7d8c26e6f193b1e008122544
e68535ahttps://github.com/python/cpython/pull/102887/commits/e68535ada0fe397c7d8c26e6f193b1e008122544
https://github.com/ericsnowcurrently
Use _Py_AddToGlobalDict().https://github.com/python/cpython/pull/102887/commits/22753b33ad22bd50ba9ce207de6a41311c1e6ca1
22753b3https://github.com/python/cpython/pull/102887/commits/22753b33ad22bd50ba9ce207de6a41311c1e6ca1
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
force-pushedhttps://github.com/python/cpython/compare/13f3b8f76844f99e6cc73e35b27778e12322f5fb..ca776b130d970c5cc372d5c01099ccf2a43254d3
13f3b8fhttps://github.com/python/cpython/commit/13f3b8f76844f99e6cc73e35b27778e12322f5fb
ca776b1https://github.com/python/cpython/commit/ca776b130d970c5cc372d5c01099ccf2a43254d3
Compare https://github.com/python/cpython/compare/13f3b8f76844f99e6cc73e35b27778e12322f5fb..ca776b130d970c5cc372d5c01099ccf2a43254d3
March 22, 2023 18:25https://github.com/python/cpython/pull/102887#event-8820015624
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
March 22, 2023 12:32https://github.com/python/cpython/pull/102887#commits-pushed-b649a84
https://github.com/ericsnowcurrently
Make objects stored in global containers immortal.https://github.com/python/cpython/pull/102887/commits/b649a84e4bf938fb60e735252aa9c800bbb11f65
b649a84https://github.com/python/cpython/pull/102887/commits/b649a84e4bf938fb60e735252aa9c800bbb11f65
https://github.com/ericsnowcurrently
Immortalize the interned strings dict.https://github.com/python/cpython/pull/102887/commits/9b0dc99ab9cac17a03d2edda519ab9175336a119
9b0dc99https://github.com/python/cpython/pull/102887/commits/9b0dc99ab9cac17a03d2edda519ab9175336a119
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
force-pushedhttps://github.com/python/cpython/compare/ca776b130d970c5cc372d5c01099ccf2a43254d3..9b0dc99ab9cac17a03d2edda519ab9175336a119
ca776b1https://github.com/python/cpython/commit/ca776b130d970c5cc372d5c01099ccf2a43254d3
9b0dc99https://github.com/python/cpython/commit/9b0dc99ab9cac17a03d2edda519ab9175336a119
Compare https://github.com/python/cpython/compare/ca776b130d970c5cc372d5c01099ccf2a43254d3..9b0dc99ab9cac17a03d2edda519ab9175336a119
March 22, 2023 18:34https://github.com/python/cpython/pull/102887#event-8820078697
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102887
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/102887
https://github.com/ericsnowcurrently
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.