René's URL Explorer Experiment


Title: gh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` by sobolevn · Pull Request #102722 · python/cpython · GitHub

Open Graph Title: gh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` by sobolevn · Pull Request #102722 · python/cpython

X Title: gh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` by sobolevn · Pull Request #102722 · python/cpython

Description: Two main changes: More pickle tests with different callables Passing things like 0 is not allowed, so I think testing this behaviour won't hurt. The test is quite simple All tests work for both typing.Callable and _collections_abc.Callable. I also went ahead and remove this suspicious if from #102681 (comment) Moreover, all tests pass without it. I cannot find any examples where it is needed. Please, prove me wrong. CC @AlexWaygood Issue: gh-102721

Open Graph Description: Two main changes: More pickle tests with different callables Passing things like 0 is not allowed, so I think testing this behaviour won't hurt. The test is quite simple All tests work for bo...

X Description: Two main changes: More pickle tests with different callables Passing things like 0 is not allowed, so I think testing this behaviour won't hurt. The test is quite simple All tests work fo...

Opengraph URL: https://github.com/python/cpython/pull/102722

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dc0264e4-8908-0b33-5ab5-421e9ba6d9a4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8072:B7306:F8E11A:15AE3D8:696A8752
html-safe-nonce67aa8a70e6f7417dc274a3cc2a6bd6fdf4f46794cd4b983172b4c7ef4d1a035b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDcyOkI3MzA2OkY4RTExQToxNUFFM0Q4OjY5NkE4NzUyIiwidmlzaXRvcl9pZCI6IjI1NTM5OTE2MjI3NTEzMjM5ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb7b4051bfdf3e52469f62f5a0f8890eadcdd8c1ea191df9932986bc3cd2cc99b
hovercard-subject-tagpull_request:1276590769
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/102722/files
twitter:imagehttps://avatars.githubusercontent.com/u/4660275?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4660275?s=400&v=4
og:image:altTwo main changes: More pickle tests with different callables Passing things like 0 is not allowed, so I think testing this behaviour won't hurt. The test is quite simple All tests work for bo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/102722/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102722%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102722%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/102722/files
Reloadhttps://github.com/python/cpython/pull/102722/files
Reloadhttps://github.com/python/cpython/pull/102722/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-102721https://github.com/sobolevn/cpython/tree/issue-102721
Conversation 18 https://github.com/python/cpython/pull/102722
Commits 2 https://github.com/python/cpython/pull/102722/commits
Checks 0 https://github.com/python/cpython/pull/102722/checks
Files changed https://github.com/python/cpython/pull/102722/files
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
gh-102721: Improve coverage of _collections_abc._CallableGenericAlias https://github.com/python/cpython/pull/102722/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/102722/files
8ed3dd8 gh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` sobolevn Mar 15, 2023 https://github.com/python/cpython/pull/102722/commits/8ed3dd8b6d265e721aa5151b8800effda9fb593a
afe8f37 Apply suggestions from code review sobolevn Mar 15, 2023 https://github.com/python/cpython/pull/102722/commits/afe8f372965c54dfc3a416a8b501e8a7abf542e8
Clear filters https://github.com/python/cpython/pull/102722/files
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
_collections_abc.py https://github.com/python/cpython/pull/102722/files#diff-2044b2b16b4875063072f171fbaa695fab71ffa10976692286bc7f5e0fb4b545
test_typing.py https://github.com/python/cpython/pull/102722/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L400
Lib/_collections_abc.pyhttps://github.com/python/cpython/pull/102722/files#diff-2044b2b16b4875063072f171fbaa695fab71ffa10976692286bc7f5e0fb4b545
View file https://github.com/sobolevn/cpython/blob/afe8f372965c54dfc3a416a8b501e8a7abf542e8/Lib/_collections_abc.py
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/102722/{{ revealButtonHref }}
https://github.com/python/cpython/pull/102722/files#diff-2044b2b16b4875063072f171fbaa695fab71ffa10976692286bc7f5e0fb4b545
AlexWaygoodhttps://github.com/AlexWaygood
Mar 15, 2023https://github.com/python/cpython/pull/102722/files#r1137196475
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Fidget-Spinnerhttps://github.com/Fidget-Spinner
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
sobolevnhttps://github.com/sobolevn
Mar 15, 2023https://github.com/python/cpython/pull/102722/files#r1137207606
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
gvanrossumhttps://github.com/gvanrossum
Mar 16, 2023https://github.com/python/cpython/pull/102722/files#r1137911316
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
AlexWaygoodhttps://github.com/AlexWaygood
Mar 16, 2023https://github.com/python/cpython/pull/102722/files#r1137913307
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
gvanrossumhttps://github.com/gvanrossum
Mar 16, 2023https://github.com/python/cpython/pull/102722/files#r1138016510
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
sobolevnhttps://github.com/sobolevn
Mar 16, 2023https://github.com/python/cpython/pull/102722/files#r1138418054
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/python/cpython/blame/2dc94634b50f0e5e207787e5ac1d56c68b22c3ae/Objects/genericaliasobject.c#L361https://github.com/python/cpython/blame/2dc94634b50f0e5e207787e5ac1d56c68b22c3ae/Objects/genericaliasobject.c#L361
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
AlexWaygoodhttps://github.com/AlexWaygood
Mar 16, 2023https://github.com/python/cpython/pull/102722/files#r1138425716
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
sobolevnhttps://github.com/sobolevn
Mar 16, 2023https://github.com/python/cpython/pull/102722/files#r1138428486
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/102722/files
https://github.com/python/cpython/pull/102722/files#diff-2044b2b16b4875063072f171fbaa695fab71ffa10976692286bc7f5e0fb4b545
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L599
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/102722/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
View file https://github.com/sobolevn/cpython/blob/afe8f372965c54dfc3a416a8b501e8a7abf542e8/Lib/test/test_typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/102722/{{ revealButtonHref }}
https://github.com/python/cpython/pull/102722/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/102722/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/102722/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.