René's URL Explorer Experiment


Title: [3.10] gh-102433: Add tests for how classes with properties interact with `isinstance()` checks on `typing.runtime_checkable` protocols (GH-102449) by miss-islington · Pull Request #102593 · python/cpython · GitHub

Open Graph Title: [3.10] gh-102433: Add tests for how classes with properties interact with `isinstance()` checks on `typing.runtime_checkable` protocols (GH-102449) by miss-islington · Pull Request #102593 · python/cpython

X Title: [3.10] gh-102433: Add tests for how classes with properties interact with `isinstance()` checks on `typing.runtime_checkable` protocols (GH-102449) by miss-islington · Pull Request #102593 · python/cpython

Description: (cherry picked from commit 5ffdaf7) Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com Co-authored-by: Carl Meyer carl@oddbird.net Issue: isinstance on runtime_checkable Protocol has side-effect...

Open Graph Description: (cherry picked from commit 5ffdaf7) Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com Co-authored-by: Carl Meyer carl@oddbird.net Issue: isinstance on runtime_checkable Protocol has side-effect...

X Description: (cherry picked from commit 5ffdaf7) Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com Co-authored-by: Carl Meyer carl@oddbird.net Issue: isinstance on runtime_checkable Protocol has side-effect...

Mail addresses
Alex.Waygood@Gmail.com
carl@oddbird.net

Opengraph URL: https://github.com/python/cpython/pull/102593

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2d20b1a4-500b-3b72-b072-2a81d6e20981
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA338:201472:7B4F87:AE0F6C:696A1484
html-safe-nonced64f9879c54f30057d4b2010800750c80caf17a2d38488d3f7611f12c01fbc89
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzM4OjIwMTQ3Mjo3QjRGODc6QUUwRjZDOjY5NkExNDg0IiwidmlzaXRvcl9pZCI6IjU0NjA5MjgwMzUzMjMyNTM4OTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9c93a43e44f9ece4eadff4af167f5467c6fb704cc2868ca16578e608827dc029
hovercard-subject-tagpull_request:1271901862
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/102593/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e40b775ce6c4a385ca8b9622ea88280c418af8fcdaadb719d5665fbb0babd0e6/python/cpython/pull/102593
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e40b775ce6c4a385ca8b9622ea88280c418af8fcdaadb719d5665fbb0babd0e6/python/cpython/pull/102593
og:image:alt(cherry picked from commit 5ffdaf7) Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com Co-authored-by: Carl Meyer carl@oddbird.net Issue: isinstance on runtime_checkable Protocol has side-effect...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None34a52bd10bd674f68e5c1b6b74413b79bf2ca20c551055ace3f7cdd112803923
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee8bd37502700f365b18a4d39acf7cb7947e11b1a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/102593#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102593
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102593
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/102593
Reloadhttps://github.com/python/cpython/pull/102593
Reloadhttps://github.com/python/cpython/pull/102593
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/102593
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/102593
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/102593#issue-comment-box
miss-islingtonhttps://github.com/miss-islington
python:3.10https://github.com/python/cpython/tree/3.10
miss-islington:backport-5ffdaf7-3.10https://github.com/miss-islington/cpython/tree/backport-5ffdaf7-3.10
[3.10] gh-102433: Add tests for how classes with properties interact with isinstance() checks on typing.runtime_checkable protocols (GH-102449) https://github.com/python/cpython/pull/102593#top
miss-islingtonhttps://github.com/miss-islington
python:3.10https://github.com/python/cpython/tree/3.10
miss-islington:backport-5ffdaf7-3.10https://github.com/miss-islington/cpython/tree/backport-5ffdaf7-3.10
Conversation 0 https://github.com/python/cpython/pull/102593
Commits 1 https://github.com/python/cpython/pull/102593/commits
Checks 0 https://github.com/python/cpython/pull/102593/checks
Files changed https://github.com/python/cpython/pull/102593/files
Please reload this pagehttps://github.com/python/cpython/pull/102593
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 11, 2023https://github.com/python/cpython/pull/102593#issue-1619822406
Please reload this pagehttps://github.com/python/cpython/pull/102593
5ffdaf7https://github.com/python/cpython/commit/5ffdaf748d98da6065158534720f1996a45a0072
isinstance on runtime_checkable Protocol has side-effects for @property methods #102433https://github.com/python/cpython/issues/102433
Please reload this pagehttps://github.com/python/cpython/pull/102593
https://github.com/AlexWaygood
https://github.com/carljm
https://github.com/miss-islington
pythongh-102433https://github.com/python/cpython/issues/102433
: Add tests for how classes with properties interact w…https://github.com/python/cpython/pull/102593/commits/385fae374e8cc7614945e04fbc8d3218debe17bd
385fae3https://github.com/python/cpython/pull/102593/commits/385fae374e8cc7614945e04fbc8d3218debe17bd
pythonGH-102449https://github.com/python/cpython/pull/102449
5ffdaf7https://github.com/miss-islington/cpython/commit/5ffdaf748d98da6065158534720f1996a45a0072
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
AlexWaygoodhttps://github.com/AlexWaygood
Fidget-Spinnerhttps://github.com/Fidget-Spinner
JelleZijlstrahttps://github.com/JelleZijlstra
gvanrossumhttps://github.com/gvanrossum
code ownershttps://github.com/python/cpython/blob/7276ee0d122d072486b4a9fc03d17533f871da8f/.github/CODEOWNERS#L134
March 11, 2023 01:20https://github.com/python/cpython/pull/102593#event-8723140075
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Mar 11, 2023https://github.com/python/cpython/pull/102593#event-8723140169
isinstance on runtime_checkable Protocol has side-effects for @property methods #102433 https://github.com/python/cpython/issues/102433
gh-102433: Add tests for how classes with properties interact with isinstance() checks on typing.runtime_checkable protocols #102449 https://github.com/python/cpython/pull/102449
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 11, 2023https://github.com/python/cpython/pull/102593#event-8723140345
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Mar 11, 2023 https://github.com/python/cpython/pull/102593#pullrequestreview-1335788309
View reviewed changes https://github.com/python/cpython/pull/102593/files/385fae374e8cc7614945e04fbc8d3218debe17bd
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 11, 2023https://github.com/python/cpython/pull/102593#event-8723141952
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Mar 11, 2023https://github.com/python/cpython/pull/102593#event-8723142266
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
2810787https://github.com/python/cpython/commit/281078794f10a42d0aa99d660e25a434fde96ec4
Mar 11, 2023https://github.com/python/cpython/pull/102593#event-8723181830
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 11, 2023https://github.com/python/cpython/pull/102593#event-8723181904
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
March 11, 2023 01:45https://github.com/python/cpython/pull/102593#event-8723182021
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102593
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/python/cpython/pull/102593/files/385fae374e8cc7614945e04fbc8d3218debe17bd
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/102593
https://github.com/miss-islington
https://github.com/AlexWaygood
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.