René's URL Explorer Experiment


Title: gh-87092: refactor assemble() to a number of separate functions, which do not need the compiler struct by iritkatriel · Pull Request #102562 · python/cpython · GitHub

Open Graph Title: gh-87092: refactor assemble() to a number of separate functions, which do not need the compiler struct by iritkatriel · Pull Request #102562 · python/cpython

X Title: gh-87092: refactor assemble() to a number of separate functions, which do not need the compiler struct by iritkatriel · Pull Request #102562 · python/cpython

Description: This PR: further breaks up the assemble() function, and extracts out of it the optimize_code_unit(), assemble_code_unit(), assemble_emit() and resolve_line_numbers() steps into separate functions. passes less stuff around (namely, not passing the whole compiler struct but only what is needed). unit tests (_PyCompile_OptimizeCfg ) run all of optimize_code_unit(), not just optimize_cfg(), so we can test dead code removal, unused const removal, hot/cold code arrangements, etc. _PyCompile_CodeGen no longer constructs a cfg. Issue: gh-87092

Open Graph Description: This PR: further breaks up the assemble() function, and extracts out of it the optimize_code_unit(), assemble_code_unit(), assemble_emit() and resolve_line_numbers() steps into separate functions....

X Description: This PR: further breaks up the assemble() function, and extracts out of it the optimize_code_unit(), assemble_code_unit(), assemble_emit() and resolve_line_numbers() steps into separate functions....

Opengraph URL: https://github.com/python/cpython/pull/102562

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9c252458-14e7-cb55-ae6d-44321bbc984a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id94CE:2D39D2:9BEA7:C3CA9:6969B899
html-safe-nonce4fb9b2f170b24db7510c6312fd8f13145b7d2e32fa7bade90ba32801ca83355c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NENFOjJEMzlEMjo5QkVBNzpDM0NBOTo2OTY5Qjg5OSIsInZpc2l0b3JfaWQiOiI1MDc0MDc4NDYyNjYxNzM2NjAxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc372e9a85d9980882c6daf8216c7d24cf8d05d89ef44d8c27b5a15701ed1d701
hovercard-subject-tagpull_request:1270075162
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/102562/files
twitter:imagehttps://avatars.githubusercontent.com/u/1055913?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1055913?s=400&v=4
og:image:altThis PR: further breaks up the assemble() function, and extracts out of it the optimize_code_unit(), assemble_code_unit(), assemble_emit() and resolve_line_numbers() steps into separate functions....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/102562/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102562%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102562%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/102562/files
Reloadhttps://github.com/python/cpython/pull/102562/files
Reloadhttps://github.com/python/cpython/pull/102562/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/102562/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/102562/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
iritkatriel:decouple_assemblerhttps://github.com/iritkatriel/cpython/tree/decouple_assembler
Conversation 3 https://github.com/python/cpython/pull/102562
Commits 10 https://github.com/python/cpython/pull/102562/commits
Checks 0 https://github.com/python/cpython/pull/102562/checks
Files changed https://github.com/python/cpython/pull/102562/files
Please reload this pagehttps://github.com/python/cpython/pull/102562/files
gh-87092: refactor assemble() to a number of separate functions, which do not need the compiler struct https://github.com/python/cpython/pull/102562/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/102562/files
8b71935 remove compiler as arg from some codegen functions iritkatriel Mar 8, 2023 https://github.com/python/cpython/pull/102562/commits/8b71935f6aba37e66411c3745c9d0b89cb5e0038
ed9c7d2 prepare_localsplus doesn't need the whole compiler struct iritkatriel Mar 8, 2023 https://github.com/python/cpython/pull/102562/commits/ed9c7d2751c338751f021b9e83bd875a85ab905e
1232d41 don't pass compiler around so much in assembler stage iritkatriel Mar 8, 2023 https://github.com/python/cpython/pull/102562/commits/1232d4150c3655e36040a6b795023d5154f7d1ae
dbf22d1 extract optimize_code_unit() out of assemble() iritkatriel Mar 9, 2023 https://github.com/python/cpython/pull/102562/commits/dbf22d19693310f74951f388529bd70431aba2f2
db4b2b8 _PyCompile_CodeGen doesn't need to construct a cfg iritkatriel Mar 9, 2023 https://github.com/python/cpython/pull/102562/commits/db4b2b8feebb18b98d72b1cadeb298f462a9d677
9071570 refactor optimize_code_unit further iritkatriel Mar 9, 2023 https://github.com/python/cpython/pull/102562/commits/9071570f396b508542858bfa95937e179d968f12
4e7857f unit tests run all of the optimization stage, not just optimize_cfg iritkatriel Mar 9, 2023 https://github.com/python/cpython/pull/102562/commits/4e7857f10e5a2de76de9cebdfc2a046d58d03db8
d0166c4 break up assemble() some more iritkatriel Mar 10, 2023 https://github.com/python/cpython/pull/102562/commits/d0166c4d2b35365ee0221c8a11ce5556956d4d2b
c9fc294 remove obsolete comment iritkatriel Mar 10, 2023 https://github.com/python/cpython/pull/102562/commits/c9fc294ab939f456211fd04feaaf976a4a855e43
0f198b6 tidy up the no-arg representation in unit test instruction sequences iritkatriel Mar 10, 2023 https://github.com/python/cpython/pull/102562/commits/0f198b6ee313459ef2ab679be02387c4bf523b73
Clear filters https://github.com/python/cpython/pull/102562/files
Please reload this pagehttps://github.com/python/cpython/pull/102562/files
Please reload this pagehttps://github.com/python/cpython/pull/102562/files
bytecode_helper.py https://github.com/python/cpython/pull/102562/files#diff-ce71f1eeafea9d44637c79993bcf2f5d2f69b73e9261b9afddb94b3b3627afec
test_peepholer.py https://github.com/python/cpython/pull/102562/files#diff-bcf92ed219340e9e0c52401909828c2e9a821541660073e24d64dd996beaf842
compile.c https://github.com/python/cpython/pull/102562/files#diff-ebc983d9f91e5bcf73500e377ac65e85863c4f77fd5b6b6caf4fcdf7c0f0b057
Lib/test/support/bytecode_helper.pyhttps://github.com/python/cpython/pull/102562/files#diff-ce71f1eeafea9d44637c79993bcf2f5d2f69b73e9261b9afddb94b3b3627afec
View file https://github.com/iritkatriel/cpython/blob/0f198b6ee313459ef2ab679be02387c4bf523b73/Lib/test/support/bytecode_helper.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/102562/{{ revealButtonHref }}
https://github.com/python/cpython/pull/102562/files#diff-ce71f1eeafea9d44637c79993bcf2f5d2f69b73e9261b9afddb94b3b3627afec
https://github.com/python/cpython/pull/102562/files#diff-ce71f1eeafea9d44637c79993bcf2f5d2f69b73e9261b9afddb94b3b3627afec
Lib/test/test_peepholer.pyhttps://github.com/python/cpython/pull/102562/files#diff-bcf92ed219340e9e0c52401909828c2e9a821541660073e24d64dd996beaf842
View file https://github.com/iritkatriel/cpython/blob/0f198b6ee313459ef2ab679be02387c4bf523b73/Lib/test/test_peepholer.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/102562/{{ revealButtonHref }}
https://github.com/python/cpython/pull/102562/files#diff-bcf92ed219340e9e0c52401909828c2e9a821541660073e24d64dd996beaf842
https://github.com/python/cpython/pull/102562/files#diff-bcf92ed219340e9e0c52401909828c2e9a821541660073e24d64dd996beaf842
https://github.com/python/cpython/pull/102562/files#diff-bcf92ed219340e9e0c52401909828c2e9a821541660073e24d64dd996beaf842
Please reload this pagehttps://github.com/python/cpython/pull/102562/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.