| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6e0e03ef-55b6-1ecd-92a6-4a68e2fcf20a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BE16:BB754:2F5C33:421C04:696A43F8 |
| html-safe-nonce | bf9c83d67fc54d270a1f1717784bbc864d526dc23772beceda267de5fdeb4571 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTE2OkJCNzU0OjJGNUMzMzo0MjFDMDQ6Njk2QTQzRjgiLCJ2aXNpdG9yX2lkIjoiNzQ5MDc5MjY3MjQ4MjQ0NDI4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f2ef2402330e4ba55117ba9eb591df6eaaea5b6a244a0875beeab117d1d361b0 |
| hovercard-subject-tag | pull_request:1267426029 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/102523/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3c79b201e06df492b9e67b299d25fc469ab8221df9d8251ef37532e57ed9ae08/python/cpython/pull/102523 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3c79b201e06df492b9e67b299d25fc469ab8221df9d8251ef37532e57ed9ae08/python/cpython/pull/102523 |
| og:image:alt | input checks for math_1(L989), math_1a(L1023), math_2(L1064,L1071), hypot(L2682), log(L2307), ldexp(L2168), ceil(L1165), floor(L1236,L1239) and dist(L2587,L2588,L2628).
drop inaccessible "if&q... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | skirpichev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/102523#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102523 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102523 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/102523 |
| Reload | https://github.com/python/cpython/pull/102523 |
| Reload | https://github.com/python/cpython/pull/102523 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/102523#issue-comment-box |
| hauntsaninja | https://github.com/hauntsaninja |
| python:main | https://github.com/python/cpython/tree/main |
| skirpichev:math-cov | https://github.com/skirpichev/cpython/tree/math-cov |
|
gh-102837: few coverage nitpicks for the math module
| https://github.com/python/cpython/pull/102523#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:main | https://github.com/python/cpython/tree/main |
| skirpichev:math-cov | https://github.com/skirpichev/cpython/tree/math-cov |
|
Conversation
27
| https://github.com/python/cpython/pull/102523 |
|
Commits
20
| https://github.com/python/cpython/pull/102523/commits |
|
Checks
0
| https://github.com/python/cpython/pull/102523/checks |
|
Files changed
| https://github.com/python/cpython/pull/102523/files |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| Mar 8, 2023 | https://github.com/python/cpython/pull/102523#issue-1614759500 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| 5e6661b | https://github.com/python/cpython/commit/5e6661bce968173fa45b74fa2111098645ff609c |
| Improve test coverage for the math module #102837 | https://github.com/python/cpython/issues/102837 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Mar 8, 2023 | https://github.com/python/cpython/pull/102523#event-8693632813 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| Mar 8, 2023 | https://github.com/python/cpython/pull/102523#issuecomment-1459641522 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| #102067 | https://github.com/python/cpython/pull/102067 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Mar 8, 2023 | https://github.com/python/cpython/pull/102523#event-8695644464 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| Mar 8, 2023 | https://github.com/python/cpython/pull/102523#issuecomment-1460226309 |
| @AlexWaygood | https://github.com/AlexWaygood |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Mar 8, 2023 | https://github.com/python/cpython/pull/102523#issuecomment-1460229792 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| @AlexWaygood | https://github.com/AlexWaygood |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| Mar 8, 2023 | https://github.com/python/cpython/pull/102523#issuecomment-1460340189 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| https://github.com/mdickinson |
| mdickinson | https://github.com/mdickinson |
| March 8, 2023 17:40 | https://github.com/python/cpython/pull/102523#event-8698892991 |
|
| https://github.com/skirpichev |
| pythongh-102837 | https://github.com/python/cpython/issues/102837 |
| : few coverage nitpicks for the math module | https://github.com/python/cpython/pull/102523/commits/68b2e428811d31783f70c9e051064de24f7bcbac |
| 68b2e42 | https://github.com/python/cpython/pull/102523/commits/68b2e428811d31783f70c9e051064de24f7bcbac |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| force-pushed | https://github.com/python/cpython/compare/3e3807b8ea911acefc65e04d19b957dfedc3fa83..68b2e428811d31783f70c9e051064de24f7bcbac |
| 3e3807b | https://github.com/python/cpython/commit/3e3807b8ea911acefc65e04d19b957dfedc3fa83 |
| 68b2e42 | https://github.com/python/cpython/commit/68b2e428811d31783f70c9e051064de24f7bcbac |
|
Compare
| https://github.com/python/cpython/compare/3e3807b8ea911acefc65e04d19b957dfedc3fa83..68b2e428811d31783f70c9e051064de24f7bcbac |
| March 20, 2023 07:26 | https://github.com/python/cpython/pull/102523#event-8791064822 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| Mar 20, 2023 | https://github.com/python/cpython/pull/102523#event-8791087060 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
Mar 20, 2023
| https://github.com/python/cpython/pull/102523#ref-issue-1631428426 |
|
Improve test coverage for the math module
#102837
| https://github.com/python/cpython/issues/102837 |
| skirpichev | https://github.com/skirpichev |
| April 3, 2023 14:22 | https://github.com/python/cpython/pull/102523#commits-pushed-dc85378 |
|
| https://github.com/skirpichev |
| Merge branch 'main' into math-cov | https://github.com/python/cpython/pull/102523/commits/dc853789b601478de7f5fc7d0e52c760262fe2d5 |
| dc85378 | https://github.com/python/cpython/pull/102523/commits/dc853789b601478de7f5fc7d0e52c760262fe2d5 |
|
| https://github.com/skirpichev |
| Merge branch 'main' into math-cov | https://github.com/python/cpython/pull/102523/commits/86aee3ccbb2a74be0c67ce9546c1bfb5f92e7084 |
| 86aee3c | https://github.com/python/cpython/pull/102523/commits/86aee3ccbb2a74be0c67ce9546c1bfb5f92e7084 |
|
| https://github.com/skirpichev |
| Simplify math_1, like other functions | https://github.com/python/cpython/pull/102523/commits/9c32ae022f07ea90892175a2d7f5c777621be0e0 |
| 9c32ae0 | https://github.com/python/cpython/pull/102523/commits/9c32ae022f07ea90892175a2d7f5c777621be0e0 |
|
| https://github.com/skirpichev |
| Merge branch 'main' into math-cov | https://github.com/python/cpython/pull/102523/commits/b8cf8acc1bc20a09ac68e2cc49a51b24616eb4fa |
| b8cf8ac | https://github.com/python/cpython/pull/102523/commits/b8cf8acc1bc20a09ac68e2cc49a51b24616eb4fa |
|
| https://github.com/skirpichev |
| Merge branch 'main' into math-cov | https://github.com/python/cpython/pull/102523/commits/b395cfbae769509fbe6cb8dcca7a44260f95dd8a |
| b395cfb | https://github.com/python/cpython/pull/102523/commits/b395cfbae769509fbe6cb8dcca7a44260f95dd8a |
|
| https://github.com/skirpichev |
| Merge branch 'main' into math-cov | https://github.com/python/cpython/pull/102523/commits/c3bd1cd740af295d330915c14fa24653969da0c4 |
| c3bd1cd | https://github.com/python/cpython/pull/102523/commits/c3bd1cd740af295d330915c14fa24653969da0c4 |
|
| https://github.com/skirpichev |
| Merge branch 'main' into math-cov | https://github.com/python/cpython/pull/102523/commits/dc8ac10ed0c8e9185ea2583ea8db7295e8d209e4 |
| dc8ac10 | https://github.com/python/cpython/pull/102523/commits/dc8ac10ed0c8e9185ea2583ea8db7295e8d209e4 |
|
| https://github.com/skirpichev |
| Merge branch 'main' into math-cov | https://github.com/python/cpython/pull/102523/commits/acb851da21bba3c76868b6a92391b31064fd2b8a |
| acb851d | https://github.com/python/cpython/pull/102523/commits/acb851da21bba3c76868b6a92391b31064fd2b8a |
|
| https://github.com/skirpichev |
| Merge branch 'main' into math-cov | https://github.com/python/cpython/pull/102523/commits/a6c769e799a389aacb33314770537210932dbbd4 |
| a6c769e | https://github.com/python/cpython/pull/102523/commits/a6c769e799a389aacb33314770537210932dbbd4 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Sep 1, 2023
| https://github.com/python/cpython/pull/102523#pullrequestreview-1607677527 |
|
View reviewed changes
| https://github.com/python/cpython/pull/102523/files/a6c769e799a389aacb33314770537210932dbbd4 |
| hauntsaninja | https://github.com/hauntsaninja |
| https://github.com/python/cpython/pull/102523#pullrequestreview-1607677527 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| Modules/mathmodule.c | https://github.com/python/cpython/pull/102523/files/a6c769e799a389aacb33314770537210932dbbd4#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| Modules/mathmodule.c | https://github.com/python/cpython/pull/102523/files/a6c769e799a389aacb33314770537210932dbbd4#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| Modules/mathmodule.c | https://github.com/python/cpython/pull/102523/files/a6c769e799a389aacb33314770537210932dbbd4#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| skirpichev | https://github.com/skirpichev |
| September 2, 2023 05:14 | https://github.com/python/cpython/pull/102523#commits-pushed-d45ea20 |
|
| https://github.com/skirpichev |
| Merge branch 'math-cov' of github.com:skirpichev/cpython into math-cov | https://github.com/python/cpython/pull/102523/commits/d45ea20495c44596aa5dbf12cf1d22970d141421 |
| d45ea20 | https://github.com/python/cpython/pull/102523/commits/d45ea20495c44596aa5dbf12cf1d22970d141421 |
|
| https://github.com/skirpichev |
| Merge branch 'main' into math-cov | https://github.com/python/cpython/pull/102523/commits/59a5422eda053c2e580000aa6895272e2ccf2c4e |
| 59a5422 | https://github.com/python/cpython/pull/102523/commits/59a5422eda053c2e580000aa6895272e2ccf2c4e |
|
| https://github.com/skirpichev |
| Add asserts | https://github.com/python/cpython/pull/102523/commits/a0c619b98c90cf5b7168d5b5a7df2d3c2e9d8c95 |
| a0c619b | https://github.com/python/cpython/pull/102523/commits/a0c619b98c90cf5b7168d5b5a7df2d3c2e9d8c95 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| hauntsaninja | https://github.com/hauntsaninja |
| September 2, 2023 02:36 | https://github.com/python/cpython/pull/102523#event-10262637036 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| force-pushed | https://github.com/python/cpython/compare/6634b886766cdd6e6f6350887239ea54c17dbb25..a0c619b98c90cf5b7168d5b5a7df2d3c2e9d8c95 |
| 6634b88 | https://github.com/python/cpython/commit/6634b886766cdd6e6f6350887239ea54c17dbb25 |
| a0c619b | https://github.com/python/cpython/commit/a0c619b98c90cf5b7168d5b5a7df2d3c2e9d8c95 |
|
Compare
| https://github.com/python/cpython/compare/6634b886766cdd6e6f6350887239ea54c17dbb25..a0c619b98c90cf5b7168d5b5a7df2d3c2e9d8c95 |
| September 2, 2023 03:24 | https://github.com/python/cpython/pull/102523#event-10262809289 |
|
| https://github.com/skirpichev |
| Amend | https://github.com/python/cpython/pull/102523/commits/b991b7c327af625d063449b62c34fdd289b194a4 |
| 9c32ae0 | https://github.com/skirpichev/cpython/commit/9c32ae022f07ea90892175a2d7f5c777621be0e0 |
| (comment restored) | https://github.com/python/cpython/pull/102523/commits/b991b7c327af625d063449b62c34fdd289b194a4 |
| b991b7c | https://github.com/python/cpython/pull/102523/commits/b991b7c327af625d063449b62c34fdd289b194a4 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Sep 2, 2023
| https://github.com/python/cpython/pull/102523#pullrequestreview-1607894811 |
|
View reviewed changes
| https://github.com/python/cpython/pull/102523/files/b991b7c327af625d063449b62c34fdd289b194a4 |
| Modules/mathmodule.c | https://github.com/python/cpython/pull/102523/files/a6c769e799a389aacb33314770537210932dbbd4#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| Modules/mathmodule.c | https://github.com/python/cpython/pull/102523/files/b991b7c327af625d063449b62c34fdd289b194a4#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| skirpichev | https://github.com/skirpichev |
| September 2, 2023 09:15 | https://github.com/python/cpython/pull/102523#commits-pushed-192a279 |
|
| https://github.com/skirpichev |
| Merge branch 'main' into math-cov | https://github.com/python/cpython/pull/102523/commits/192a27945d51631ce210ae53852a8433ed32c49e |
| 192a279 | https://github.com/python/cpython/pull/102523/commits/192a27945d51631ce210ae53852a8433ed32c49e |
|
| https://github.com/skirpichev |
| Revert back math_floor(), add tests to cover L1239 (same for ceil()) | https://github.com/python/cpython/pull/102523/commits/828ba755e23d3a6bf78a719ef1670cd8747dccc1 |
| 828ba75 | https://github.com/python/cpython/pull/102523/commits/828ba755e23d3a6bf78a719ef1670cd8747dccc1 |
|
| https://github.com/skirpichev |
| Tests for bad __floor__/__ceil__ descriptors (cover L1165, L1236) | https://github.com/python/cpython/pull/102523/commits/6498162bdf0944d3eb16e9d7e13845b31275d2e5 |
| 6498162 | https://github.com/python/cpython/pull/102523/commits/6498162bdf0944d3eb16e9d7e13845b31275d2e5 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| Sep 2, 2023 | https://github.com/python/cpython/pull/102523#issuecomment-1703773625 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| skirpichev | https://github.com/skirpichev |
| September 3, 2023 06:42 | https://github.com/python/cpython/pull/102523#commits-pushed-8fcca16 |
|
| https://github.com/skirpichev |
| +1 | https://github.com/python/cpython/pull/102523/commits/8fcca165e0c25949618fdbe148284066ba93cbca |
| 8fcca16 | https://github.com/python/cpython/pull/102523/commits/8fcca165e0c25949618fdbe148284066ba93cbca |
|
| https://github.com/skirpichev |
| Revert "Simplify math_1, like other functions" | https://github.com/python/cpython/pull/102523/commits/796bdca44c9662d27353e7281bd7ecf6a5f9e0e0 |
| 796bdca | https://github.com/python/cpython/pull/102523/commits/796bdca44c9662d27353e7281bd7ecf6a5f9e0e0 |
| 9c32ae0 | https://github.com/skirpichev/cpython/commit/9c32ae022f07ea90892175a2d7f5c777621be0e0 |
|
| https://github.com/skirpichev |
| Merge branch 'main' into math-cov | https://github.com/python/cpython/pull/102523/commits/c7d1764ed67c130fa08338348b89f9c6a4252cef |
| c7d1764 | https://github.com/python/cpython/pull/102523/commits/c7d1764ed67c130fa08338348b89f9c6a4252cef |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| hauntsaninja | https://github.com/hauntsaninja |
| September 3, 2023 04:29 | https://github.com/python/cpython/pull/102523#event-10265260558 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Sep 3, 2023
| https://github.com/python/cpython/pull/102523#pullrequestreview-1608457383 |
|
View reviewed changes
| https://github.com/python/cpython/pull/102523/files/c7d1764ed67c130fa08338348b89f9c6a4252cef |
| hauntsaninja | https://github.com/hauntsaninja |
| https://github.com/python/cpython/pull/102523#pullrequestreview-1608457383 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Sep 3, 2023 | https://github.com/python/cpython/pull/102523#event-10265586085 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| 9c995ab | https://github.com/python/cpython/commit/9c995abd780f3740dcd23ad85b78f2df5b4cdbaf |
| Sep 3, 2023 | https://github.com/python/cpython/pull/102523#event-10265587151 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Sep 3, 2023 | https://github.com/python/cpython/pull/102523#event-10265587207 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| September 3, 2023 09:03 | https://github.com/python/cpython/pull/102523#event-10265607990 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
|
Sep 3, 2023
| https://github.com/python/cpython/pull/102523#ref-pullrequest-1878362937 |
|
gh-110489: Optimise math.ceil for known exact float
#108801
| https://github.com/python/cpython/pull/108801 |
|
gh-101410: Improve error messages in math module
#101492
| https://github.com/python/cpython/pull/101492 |
|
gh-102837: Increase test coverage for the math module
#110000
| https://github.com/python/cpython/pull/110000 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| Sep 28, 2023 | https://github.com/python/cpython/pull/102523#issuecomment-1738387511 |
| #110000 | https://github.com/python/cpython/pull/110000 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Oct 6, 2023
| https://github.com/python/cpython/pull/102523#pullrequestreview-1661309121 |
|
View reviewed changes
| https://github.com/python/cpython/pull/102523/files/c7d1764ed67c130fa08338348b89f9c6a4252cef |
| Modules/mathmodule.c | https://github.com/python/cpython/pull/102523/files/c7d1764ed67c130fa08338348b89f9c6a4252cef#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| Modules/mathmodule.c | https://github.com/python/cpython/pull/102523/files/a6c769e799a389aacb33314770537210932dbbd4#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| skirpichev | https://github.com/skirpichev |
|
Oct 6, 2023
| https://github.com/python/cpython/pull/102523#ref-commit-3df127e |
|
| https://github.com/skirpichev |
| More efficient (for finite x) handling of special cases in math.modf | https://github.com/skirpichev/cpython/commit/3df127ee1789cf9fb01c1cb98bc98ab6e26d1679 |
| 3df127e | https://github.com/skirpichev/cpython/commit/3df127ee1789cf9fb01c1cb98bc98ab6e26d1679 |
| python#102523 | https://github.com/python/cpython/pull/102523 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
|
Nov 13, 2023
| https://github.com/python/cpython/pull/102523#ref-pullrequest-1990523746 |
|
[3.12] gh-102837: more tests for the math module (GH-111930)
#112029
| https://github.com/python/cpython/pull/112029 |
| encukou | https://github.com/encukou |
|
Nov 13, 2023
| https://github.com/python/cpython/pull/102523#ref-commit-42d1d23 |
|
| https://github.com/skirpichev |
|
| https://github.com/encukou |
| pythongh-102837 | https://github.com/python/cpython/issues/102837 |
| : improve test coverage for math module ( | https://github.com/encukou/cpython/commit/42d1d23978cf292a1739ce95f12cd403066945c9 |
| python#102523 | https://github.com/python/cpython/pull/102523 |
| ) ( | https://github.com/encukou/cpython/commit/42d1d23978cf292a1739ce95f12cd403066945c9 |
| 42d1d23 | https://github.com/encukou/cpython/commit/42d1d23978cf292a1739ce95f12cd403066945c9 |
| pythonGH-102523 | https://github.com/python/cpython/pull/102523 |
| pythonGH-102523 | https://github.com/python/cpython/pull/102523 |
| 5e6661b | https://github.com/encukou/cpython/commit/5e6661bce968173fa45b74fa2111098645ff609c |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
| Nov 13, 2023 | https://github.com/python/cpython/pull/102523#issuecomment-1808050198 |
| GH-112030 | https://github.com/python/cpython/pull/112030 |
| 3.12 branch | https://github.com/python/cpython/tree/3.12 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
| encukou | https://github.com/encukou |
|
Nov 13, 2023
| https://github.com/python/cpython/pull/102523#ref-commit-c6aea46 |
|
| https://github.com/encukou |
|
| https://github.com/skirpichev |
| [3.12] | https://github.com/python/cpython/commit/c6aea46a71d158f993cc723c14b4bf7982b73a2a |
| gh-102837 | https://github.com/python/cpython/issues/102837 |
| : more tests for the math module ( | https://github.com/python/cpython/commit/c6aea46a71d158f993cc723c14b4bf7982b73a2a |
| GH-111930 | https://github.com/python/cpython/pull/111930 |
| )( | https://github.com/python/cpython/commit/c6aea46a71d158f993cc723c14b4bf7982b73a2a |
| GH-102523 | https://github.com/python/cpython/pull/102523 |
| )… | https://github.com/python/cpython/commit/c6aea46a71d158f993cc723c14b4bf7982b73a2a |
| c6aea46 | https://github.com/python/cpython/commit/c6aea46a71d158f993cc723c14b4bf7982b73a2a |
| GH-112030 | https://github.com/python/cpython/pull/112030 |
| gh-102837 | https://github.com/python/cpython/issues/102837 |
| GH-102523 | https://github.com/python/cpython/pull/102523 |
| GH-102523 | https://github.com/python/cpython/pull/102523 |
| 5e6661b | https://github.com/python/cpython/commit/5e6661bce968173fa45b74fa2111098645ff609c |
| gh-102837 | https://github.com/python/cpython/issues/102837 |
| GH-111930 | https://github.com/python/cpython/pull/111930 |
| 9dc4fb8 | https://github.com/python/cpython/commit/9dc4fb820439db26b223edce30e5313a2e3182ff |
| c61de45 | https://github.com/python/cpython/commit/c61de456db0186b65d479d41e84127832205d30d |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
Nov 13, 2023
| https://github.com/python/cpython/pull/102523#ref-pullrequest-1990862185 |
|
[3.11] gh-102837: more tests for the math module (GH-111930)(GH-102523) (GH-112030)
#112041
| https://github.com/python/cpython/pull/112041 |
| encukou | https://github.com/encukou |
|
Nov 16, 2023
| https://github.com/python/cpython/pull/102523#ref-commit-132a749 |
|
| https://github.com/encukou |
|
| https://github.com/skirpichev |
| [3.11] | https://github.com/python/cpython/commit/132a74922a786aec6c9dc35e6756736c4ebcb966 |
| gh-102837 | https://github.com/python/cpython/issues/102837 |
| : more tests for the math module ( | https://github.com/python/cpython/commit/132a74922a786aec6c9dc35e6756736c4ebcb966 |
| GH-111930 | https://github.com/python/cpython/pull/111930 |
| )( | https://github.com/python/cpython/commit/132a74922a786aec6c9dc35e6756736c4ebcb966 |
| GH-102523 | https://github.com/python/cpython/pull/102523 |
| )… | https://github.com/python/cpython/commit/132a74922a786aec6c9dc35e6756736c4ebcb966 |
| 132a749 | https://github.com/python/cpython/commit/132a74922a786aec6c9dc35e6756736c4ebcb966 |
| GH-112030 | https://github.com/python/cpython/pull/112030 |
| GH-112041 | https://github.com/python/cpython/pull/112041 |
| gh-102837 | https://github.com/python/cpython/issues/102837 |
| GH-111930 | https://github.com/python/cpython/pull/111930 |
| GH-102523 | https://github.com/python/cpython/pull/102523 |
| GH-112030 | https://github.com/python/cpython/pull/112030 |
| gh-102837 | https://github.com/python/cpython/issues/102837 |
| GH-102523 | https://github.com/python/cpython/pull/102523 |
| GH-102523 | https://github.com/python/cpython/pull/102523 |
| 5e6661b | https://github.com/python/cpython/commit/5e6661bce968173fa45b74fa2111098645ff609c |
| gh-102837 | https://github.com/python/cpython/issues/102837 |
| GH-111930 | https://github.com/python/cpython/pull/111930 |
| 9dc4fb8 | https://github.com/python/cpython/commit/9dc4fb820439db26b223edce30e5313a2e3182ff |
| c61de45 | https://github.com/python/cpython/commit/c61de456db0186b65d479d41e84127832205d30d |
| c6aea46 | https://github.com/python/cpython/commit/c6aea46a71d158f993cc723c14b4bf7982b73a2a |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102523 |
|
| https://github.com/serhiy-storchaka |
|
serhiy-storchaka
| https://github.com/serhiy-storchaka |
|
| https://github.com/python/cpython/pull/102523/files/c7d1764ed67c130fa08338348b89f9c6a4252cef |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/cpython/pull/102523/files/c7d1764ed67c130fa08338348b89f9c6a4252cef |
|
| https://github.com/mdickinson |
|
mdickinson
| https://github.com/mdickinson |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/102523 |
|
| https://github.com/skirpichev |
|
| https://github.com/AlexWaygood |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/hauntsaninja |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |