René's URL Explorer Experiment


Title: gh-81057: Add a CI Check for New Unsupported C Global Variables by ericsnowcurrently · Pull Request #102506 · python/cpython · GitHub

Open Graph Title: gh-81057: Add a CI Check for New Unsupported C Global Variables by ericsnowcurrently · Pull Request #102506 · python/cpython

X Title: gh-81057: Add a CI Check for New Unsupported C Global Variables by ericsnowcurrently · Pull Request #102506 · python/cpython

Description: This will keep us from adding new unsupported (i.e. non-const) C global variables, which would break interpreter isolation. FYI, historically it is very uncommon for new global variables to get added. Furthermore, it is rare for new code to break the c-analyzer. So the check should almost always pass unnoticed. Note that I've removed test_check_c_globals. A test wasn't a great fit conceptually and was super slow on debug builds. A CI check is a better fit. (I'm going to sit on this PR for a few days in case there are any concerns with the new CI check. I'll also do a quick double-check with the core team but don't anticipate any real opposition.) This also resolves gh-100237. Issue: gh-81057

Open Graph Description: This will keep us from adding new unsupported (i.e. non-const) C global variables, which would break interpreter isolation. FYI, historically it is very uncommon for new global variables to get add...

X Description: This will keep us from adding new unsupported (i.e. non-const) C global variables, which would break interpreter isolation. FYI, historically it is very uncommon for new global variables to get add...

Opengraph URL: https://github.com/python/cpython/pull/102506

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:75e96c8d-e229-ba9b-0b24-c81a4cda6352
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCDB0:14D19C:58E4792:780C4DB:6995C7EE
html-safe-nonceb252bc504803ce59ff7b979af5a395dcae217a3519edf72fe7c1243bba375c07
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDREIwOjE0RDE5Qzo1OEU0NzkyOjc4MEM0REI6Njk5NUM3RUUiLCJ2aXNpdG9yX2lkIjoiNDkwMjAwNDQxMTg4MTM0Mjk1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb5924070b7ab9704f6a5aab2b069f59a53bd5f14be5a6071bdf4952ec36203db
hovercard-subject-tagpull_request:1266683910
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e
twitter:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
og:image:altThis will keep us from adding new unsupported (i.e. non-const) C global variables, which would break interpreter isolation. FYI, historically it is very uncommon for new global variables to get add...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0f7f0c08152b2fbe00b7a94c0999555da729903b87c8fcd49e22663191f98790
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release152dd84c0d51b8f667cbe521c323d7a05cca7903
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102506%2Fcommits%2F3651ee7312e145c0731d9e0f446c518d6522b09e
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102506%2Fcommits%2F3651ee7312e145c0731d9e0f446c518d6522b09e
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e
Reloadhttps://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e
Reloadhttps://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.5k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:enable-globals-ci-checkhttps://github.com/ericsnowcurrently/cpython/tree/enable-globals-ci-check
Conversation 7 https://github.com/python/cpython/pull/102506
Commits 22 https://github.com/python/cpython/pull/102506/commits
Checks 0 https://github.com/python/cpython/pull/102506/checks
Files changed https://github.com/python/cpython/pull/102506/files
Please reload this pagehttps://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e
gh-81057: Add a CI Check for New Unsupported C Global Variables https://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e#top
Show all changes 22 commits https://github.com/python/cpython/pull/102506/files
3651ee7 Print a helpful message when the globals check fails. ericsnowcurrently Mar 7, 2023 https://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e
1c1e0b0 Print the explanation even when the parser breaks. ericsnowcurrently Mar 7, 2023 https://github.com/python/cpython/pull/102506/commits/1c1e0b0f915a5ea603d7de5588b73a9965d7e7b2
aa08d9d Enable the CI globals check. ericsnowcurrently Mar 7, 2023 https://github.com/python/cpython/pull/102506/commits/aa08d9d05e81a06ae25cec9be5707b16d34ab29e
94db0e4 Add the globals check to CI. ericsnowcurrently Mar 7, 2023 https://github.com/python/cpython/pull/102506/commits/94db0e4e174225adcf0465a045e458de19920add
68db07f Drop the test. ericsnowcurrently Mar 7, 2023 https://github.com/python/cpython/pull/102506/commits/68db07f9f258d32ef5ff88de6a32671048ab0bfb
9ed998a Fix the command. ericsnowcurrently Mar 7, 2023 https://github.com/python/cpython/pull/102506/commits/9ed998a7f935ae48657233656cf7028e69bd7a57
5ee7611 Add some temporary debugging code. ericsnowcurrently Mar 7, 2023 https://github.com/python/cpython/pull/102506/commits/5ee7611bf7df0626cad464797f312d5e35b208cc
bb1463e Accommodate newer GCC versions. ericsnowcurrently Mar 7, 2023 https://github.com/python/cpython/pull/102506/commits/bb1463e5f37741b0828b540c66af2e4abef86756
d9f45a8 Fix the "ignored" filename. ericsnowcurrently Mar 7, 2023 https://github.com/python/cpython/pull/102506/commits/d9f45a8ff317eb2b31fcccab74e564c78a2a82d4
f1e5827 Emit the message from the right script. ericsnowcurrently Mar 7, 2023 https://github.com/python/cpython/pull/102506/commits/f1e5827d4b8464b47f2e985de37677676e18e605
d59e2af Print the traceback. ericsnowcurrently Mar 7, 2023 https://github.com/python/cpython/pull/102506/commits/d59e2af41f29c3d6a4b1828fa00be6baac256ca3
a959ccd Let lineno be 0 for meta files. ericsnowcurrently Mar 7, 2023 https://github.com/python/cpython/pull/102506/commits/a959ccd7dbf4b4b2802c2d19339d56f039907e3e
3390014 Allow meta files with flags. ericsnowcurrently Mar 8, 2023 https://github.com/python/cpython/pull/102506/commits/33900143edb2c6890a31bc9361daff04c45675a2
8f93550 Special-case . ericsnowcurrently Mar 8, 2023 https://github.com/python/cpython/pull/102506/commits/8f935509aa433e894c00b471e02a66e9ac0fc8bc
76039c0 Flush stdout/stderr around the explanation. ericsnowcurrently Mar 8, 2023 https://github.com/python/cpython/pull/102506/commits/76039c08d3b8f0efe25e0c71967069c712dd9eb4
dc4ee3a Print preprocessor errors by default. ericsnowcurrently Mar 8, 2023 https://github.com/python/cpython/pull/102506/commits/dc4ee3ab27d42dc9f8b0ac07a9d4ef8349547f37
4c03fd0 Add a possible include dir for uuid. ericsnowcurrently Mar 8, 2023 https://github.com/python/cpython/pull/102506/commits/4c03fd04adeb3d1ab5cad12e3aad7ced70b22fe8
863e152 Add other possible include dirs. ericsnowcurrently Mar 8, 2023 https://github.com/python/cpython/pull/102506/commits/863e1526af4592010906944f420128ddedf7b44e
f230d79 Use Same Capitalization as Other Jobs ericsnowcurrently Mar 14, 2023 https://github.com/python/cpython/pull/102506/commits/f230d79fa5d80f0429e9c9e366f1d3a1c577cea4
08f9279 Add a make target. ericsnowcurrently Mar 14, 2023 https://github.com/python/cpython/pull/102506/commits/08f92795adeafb55484b8966333503fe2c1b7236
c220d54 Merge branch 'main' into enable-globals-ci-check ericsnowcurrently Mar 14, 2023 https://github.com/python/cpython/pull/102506/commits/c220d54aec481e47ce2c01c2a3f12af569b05cc2
9cc170c Ignore a global that snuck in. ericsnowcurrently Mar 14, 2023 https://github.com/python/cpython/pull/102506/commits/9cc170c1e86d0ca2f3a9d1701aa955558d6bee07
Clear filters https://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e
Please reload this pagehttps://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e
Please reload this pagehttps://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e
Next https://github.com/python/cpython/pull/102506/commits/1c1e0b0f915a5ea603d7de5588b73a9965d7e7b2
Please reload this pagehttps://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/python/cpython/commits?author=ericsnowcurrently
Tools/c-analyzer/c_analyzer/__main__.pyhttps://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e#diff-960e55199f42a212ad2057479ef2352a64720d6d41bf8d20f66d6b234c96ea28
View file https://github.com/ericsnowcurrently/cpython/blob/3651ee7312e145c0731d9e0f446c518d6522b09e/Tools/c-analyzer/c_analyzer/__main__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/102506/commits/{{ revealButtonHref }}
https://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e#diff-960e55199f42a212ad2057479ef2352a64720d6d41bf8d20f66d6b234c96ea28
https://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e#diff-960e55199f42a212ad2057479ef2352a64720d6d41bf8d20f66d6b234c96ea28
https://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e#diff-960e55199f42a212ad2057479ef2352a64720d6d41bf8d20f66d6b234c96ea28
https://github.com/python/cpython/pull/102506/commits/3651ee7312e145c0731d9e0f446c518d6522b09e#diff-960e55199f42a212ad2057479ef2352a64720d6d41bf8d20f66d6b234c96ea28
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.