| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:efcf5001-4370-b46e-94c6-77f146341edc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DBA2:1C2602:7F63D:B37A8:696A5971 |
| html-safe-nonce | 953f6ee082f1ee5fad85720ae36f00557ded9f125be8818e8a3ced784ff38b19 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkEyOjFDMjYwMjo3RjYzRDpCMzdBODo2OTZBNTk3MSIsInZpc2l0b3JfaWQiOiIzNjgwMDk0MTkxOTIwNzY1Mjk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 115711fc327d718cec3a3314ba20fd747e8b160a121d82f0ad10a3acd8656ce7 |
| hovercard-subject-tag | pull_request:1257865181 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/102345/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c06f366676f6c403f2fb1045ffce12d20a589eda1424c904fc3c5d6fb6d82631/python/cpython/pull/102345 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c06f366676f6c403f2fb1045ffce12d20a589eda1424c904fc3c5d6fb6d82631/python/cpython/pull/102345 |
| og:image:alt | Some review already took place in #102256:
implementation for QueryValueEx / SetValueEx should possibly be cleaned up as well by using a similar structure
The two could possibly share some part of... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | maxbachmann |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/102345#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102345 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102345 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/102345 |
| Reload | https://github.com/python/cpython/pull/102345 |
| Reload | https://github.com/python/cpython/pull/102345 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/102345 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/102345 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/102345#issue-comment-box |
| zooba | https://github.com/zooba |
| python:main | https://github.com/python/cpython/tree/main |
|
gh-102344: implement winreg QueryValue / SetValue using QueryValueEx / SetValueEx
| https://github.com/python/cpython/pull/102345#top |
| zooba | https://github.com/zooba |
| python:main | https://github.com/python/cpython/tree/main |
|
Conversation
7
| https://github.com/python/cpython/pull/102345 |
|
Commits
10
| https://github.com/python/cpython/pull/102345/commits |
|
Checks
0
| https://github.com/python/cpython/pull/102345/checks |
|
Files changed
| https://github.com/python/cpython/pull/102345/files |
| Please reload this page | https://github.com/python/cpython/pull/102345 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/maxbachmann |
| maxbachmann | https://github.com/maxbachmann |
| Feb 28, 2023 | https://github.com/python/cpython/pull/102345#issue-1603890421 |
| Please reload this page | https://github.com/python/cpython/pull/102345 |
| #102256 | https://github.com/python/cpython/pull/102256 |
| implement winreg QueryValue / SetValue using QueryValueEx / SetValueEx #102344 | https://github.com/python/cpython/issues/102344 |
| Please reload this page | https://github.com/python/cpython/pull/102345 |
|
| https://github.com/maxbachmann |
| reimplement QueryValue / SetValue | https://github.com/python/cpython/pull/102345/commits/0d928df61a177021a3575932e6ed97831afcc0fe |
| 0d928df | https://github.com/python/cpython/pull/102345/commits/0d928df61a177021a3575932e6ed97831afcc0fe |
| https://github.com/maxbachmann |
| maxbachmann | https://github.com/maxbachmann |
| code owner | https://github.com/python/cpython/blob/360ef843d8fc03aad38ed84f9f45026ab08ca4f4/.github/CODEOWNERS#L117 |
| February 28, 2023 22:10 | https://github.com/python/cpython/pull/102345#event-8631937081 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Feb 28, 2023 | https://github.com/python/cpython/pull/102345#event-8631937361 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
Feb 28, 2023
| https://github.com/python/cpython/pull/102345#ref-issue-1603887215 |
|
implement winreg QueryValue / SetValue using QueryValueEx / SetValueEx
#102344
| https://github.com/python/cpython/issues/102344 |
| maxbachmann | https://github.com/maxbachmann |
| February 28, 2023 23:11 | https://github.com/python/cpython/pull/102345#commits-pushed-e0b256d |
|
| https://github.com/maxbachmann |
| refactor QueryValueEx | https://github.com/python/cpython/pull/102345/commits/e0b256d791073e8133b8cbdf310e1bde1bb40908 |
| e0b256d | https://github.com/python/cpython/pull/102345/commits/e0b256d791073e8133b8cbdf310e1bde1bb40908 |
|
| https://github.com/maxbachmann |
| cleanup | https://github.com/python/cpython/pull/102345/commits/799f380cbc93fefc63340de3d747040bd7bbfd56 |
| 799f380 | https://github.com/python/cpython/pull/102345/commits/799f380cbc93fefc63340de3d747040bd7bbfd56 |
|
| https://github.com/maxbachmann |
| fix type | https://github.com/python/cpython/pull/102345/commits/67ef9f305f91bc5476240f316554ac9606b324e5 |
| 67ef9f3 | https://github.com/python/cpython/pull/102345/commits/67ef9f305f91bc5476240f316554ac9606b324e5 |
|
| https://github.com/maxbachmann |
| remove unused variables | https://github.com/python/cpython/pull/102345/commits/fbc1a0ea3af02e58f89eacf185fff237737ca9bf |
| fbc1a0e | https://github.com/python/cpython/pull/102345/commits/fbc1a0ea3af02e58f89eacf185fff237737ca9bf |
| https://github.com/maxbachmann |
| maxbachmann | https://github.com/maxbachmann |
|
Feb 28, 2023
| https://github.com/python/cpython/pull/102345#ref-pullrequest-1599803136 |
|
gh-102255: Improve build support on xbox
#102256
| https://github.com/python/cpython/pull/102256 |
| https://github.com/eryksun |
| eryksun | https://github.com/eryksun |
|
OS-windows
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-windows |
| Feb 28, 2023 | https://github.com/python/cpython/pull/102345#event-8632402429 |
| maxbachmann | https://github.com/maxbachmann |
| March 1, 2023 01:06 | https://github.com/python/cpython/pull/102345#commits-pushed-de0549b |
|
| https://github.com/maxbachmann |
| fix duplicated variable name | https://github.com/python/cpython/pull/102345/commits/de0549bc1d65962ead12f429b535d83dfefdda36 |
| de0549b | https://github.com/python/cpython/pull/102345/commits/de0549bc1d65962ead12f429b535d83dfefdda36 |
|
| https://github.com/maxbachmann |
| add news | https://github.com/python/cpython/pull/102345/commits/deca441770ef2dcf98a486ce0889420910c841c6 |
| deca441 | https://github.com/python/cpython/pull/102345/commits/deca441770ef2dcf98a486ce0889420910c841c6 |
| https://github.com/eryksun |
| eryksun | https://github.com/eryksun |
|
Mar 1, 2023
| https://github.com/python/cpython/pull/102345#pullrequestreview-1318901098 |
|
View reviewed changes
| https://github.com/python/cpython/pull/102345/files/deca441770ef2dcf98a486ce0889420910c841c6 |
| PC/winreg.c | https://github.com/python/cpython/pull/102345/files/deca441770ef2dcf98a486ce0889420910c841c6#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c |
| Please reload this page | https://github.com/python/cpython/pull/102345 |
| maxbachmann | https://github.com/maxbachmann |
| March 1, 2023 02:36 | https://github.com/python/cpython/pull/102345#commits-pushed-2c95f23 |
|
| https://github.com/maxbachmann |
|
| https://github.com/eryksun |
| Update PC/winreg.c | https://github.com/python/cpython/pull/102345/commits/2c95f23c9a2f6f4a02262329b7f17104d47d056c |
| 2c95f23 | https://github.com/python/cpython/pull/102345/commits/2c95f23c9a2f6f4a02262329b7f17104d47d056c |
|
| https://github.com/maxbachmann |
| revert part | https://github.com/python/cpython/pull/102345/commits/8a4543b9374d77bd501c089d66f644a82eb91c20 |
| 8a4543b | https://github.com/python/cpython/pull/102345/commits/8a4543b9374d77bd501c089d66f644a82eb91c20 |
| https://github.com/zooba |
| zooba | https://github.com/zooba |
|
Mar 1, 2023
| https://github.com/python/cpython/pull/102345#pullrequestreview-1319715387 |
|
View reviewed changes
| https://github.com/python/cpython/pull/102345/files/8a4543b9374d77bd501c089d66f644a82eb91c20 |
| PC/winreg.c | https://github.com/python/cpython/pull/102345/files/8a4543b9374d77bd501c089d66f644a82eb91c20#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c |
| Please reload this page | https://github.com/python/cpython/pull/102345 |
| Misc/NEWS.d/next/Core and Builtins/2023-03-01-01-36-39.gh-issue-102344.Dgfux4.rst | https://github.com/python/cpython/pull/102345/files/8a4543b9374d77bd501c089d66f644a82eb91c20#diff-c0cdd7867a6912f47ed4f75d3a0009c924d36fd26cb7077df8d09ea0815e6628 |
| Please reload this page | https://github.com/python/cpython/pull/102345 |
|
| https://github.com/maxbachmann |
| move news | https://github.com/python/cpython/pull/102345/commits/8397a2fda74b35b4cc33abff83934461b66b2975 |
| 8397a2f | https://github.com/python/cpython/pull/102345/commits/8397a2fda74b35b4cc33abff83934461b66b2975 |
| https://github.com/zooba |
| zooba | https://github.com/zooba |
| c1748ed | https://github.com/python/cpython/commit/c1748ed59dc30ab99fe69c22bdbab54f93baa57c |
| Mar 1, 2023 | https://github.com/python/cpython/pull/102345#event-8639123535 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Mar 1, 2023 | https://github.com/python/cpython/pull/102345#event-8639124623 |
| https://github.com/eryksun |
| eryksun | https://github.com/eryksun |
| Mar 1, 2023 | https://github.com/python/cpython/pull/102345#issuecomment-1450590994 |
| Please reload this page | https://github.com/python/cpython/pull/102345 |
| https://github.com/maxbachmann |
| maxbachmann | https://github.com/maxbachmann |
| Mar 1, 2023 | https://github.com/python/cpython/pull/102345#issuecomment-1450645429 |
| Please reload this page | https://github.com/python/cpython/pull/102345 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102345 |
|
| https://github.com/eryksun |
|
eryksun
| https://github.com/eryksun |
|
| https://github.com/python/cpython/pull/102345/files/8397a2fda74b35b4cc33abff83934461b66b2975 |
|
| https://github.com/zooba |
|
zooba
| https://github.com/zooba |
|
| https://github.com/python/cpython/pull/102345/files/8a4543b9374d77bd501c089d66f644a82eb91c20 |
|
OS-windows
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-windows |
| Please reload this page | https://github.com/python/cpython/pull/102345 |
|
| https://github.com/maxbachmann |
|
| https://github.com/eryksun |
|
| https://github.com/zooba |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |