Title: gh-102251: Updates to test_imp Toward Fixing Some Refleaks by ericsnowcurrently · Pull Request #102254 · python/cpython · GitHub
Open Graph Title: gh-102251: Updates to test_imp Toward Fixing Some Refleaks by ericsnowcurrently · Pull Request #102254 · python/cpython
X Title: gh-102251: Updates to test_imp Toward Fixing Some Refleaks by ericsnowcurrently · Pull Request #102254 · python/cpython
Description: This includes some cleanup, some tweaks to the existing tests, and a bunch of new test cases. It is all related to fixing the refleaks introduced by 096d009. I haven't been able to find the leak yet, but these changes are a consequence of that effort. The only change here that might have impact outside the tests in question is in imp.py, where I update imp.load_dynamic() to use spec_from_file_location() instead of creating a ModuleSpec directly. (See commit 0c65700 below.) Also note that I've updated the tests to only skip if we're checking for refleaks (regrtest's --huntrleaks), whereas in gh-101969 I had skipped the tests entirely. The tests will be useful for some upcoming work and I'd rather the refleaks not hold that up. (It isn't clear how quickly we'll be able to fix the leaking code, though it will certainly be done in the short term.) Issue: gh-102251
Open Graph Description: This includes some cleanup, some tweaks to the existing tests, and a bunch of new test cases. It is all related to fixing the refleaks introduced by 096d009. I haven't been able to find the l...
X Description: This includes some cleanup, some tweaks to the existing tests, and a bunch of new test cases. It is all related to fixing the refleaks introduced by 096d009. I haven't been able to find t...
Opengraph URL: https://github.com/python/cpython/pull/102254
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:c279293f-5b02-21c2-eabd-7764f7fa45e7 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | A902:2AC946:57530E:7604D9:6969B2A0 |
| html-safe-nonce | d74a8b9fbfeb922acf8c1e313909d0c6b9b04ea9fef749801e6397183da949a6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTAyOjJBQzk0Njo1NzUzMEU6NzYwNEQ5OjY5NjlCMkEwIiwidmlzaXRvcl9pZCI6IjIwMzAyMDQ1ODU1ODkxOTEzMjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7feee52dfa1253a87bc0653ef02cdf6630866503010d1e02795aad3c9a14bef6 |
| hovercard-subject-tag | pull_request:1254284223 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/102254/checks |
| twitter:image | https://avatars.githubusercontent.com/u/1152074?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1152074?s=400&v=4 |
| og:image:alt | This includes some cleanup, some tweaks to the existing tests, and a bunch of new test cases. It is all related to fixing the refleaks introduced by 096d009. I haven't been able to find the l... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0672399d88424758731ec07fe24509e23bb17fb5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width