René's URL Explorer Experiment


Title: gh-102179: Fix os.dup2() error reporting for negative fds by izbyshev · Pull Request #102180 · python/cpython · GitHub

Open Graph Title: gh-102179: Fix os.dup2() error reporting for negative fds by izbyshev · Pull Request #102180 · python/cpython

X Title: gh-102179: Fix os.dup2() error reporting for negative fds by izbyshev · Pull Request #102180 · python/cpython

Description: A remnant of old code manually checks the sign of fds, but doesn't set errno before raising OSError: >>> os.dup2(-1, 0) Traceback (most recent call last): File "", line 1, in OSError: [Errno 0] Error Remove the manual check altogether: the C library functions used to implement os.dup2() check fd validity anyway. Issue: gh-102179

Open Graph Description: A remnant of old code manually checks the sign of fds, but doesn't set errno before raising OSError: >>> os.dup2(-1, 0) Traceback (most recent call last): File "<stdin>&qu...

X Description: A remnant of old code manually checks the sign of fds, but doesn&#39;t set errno before raising OSError: &gt;&gt;&gt; os.dup2(-1, 0) Traceback (most recent call last): File &q...

Opengraph URL: https://github.com/python/cpython/pull/102180

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7c06f467-ebf0-5846-861f-186c2ed5ecb7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD8C:146FD0:2A6EC5:3B8B1E:696A1D0C
html-safe-nonce82ceaf4faa5360d8cc4180c4c45e7513b4773db4dbbb4a6bbb5f78c1540cf266
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDhDOjE0NkZEMDoyQTZFQzU6M0I4QjFFOjY5NkExRDBDIiwidmlzaXRvcl9pZCI6Ijc3MzgwMzAyMjcxOTg3MTMxMDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5e9821a1d38f2bf4987dbe19b70392cce0452225a95fe6e25a8aa13e01d2f818
hovercard-subject-tagpull_request:1251856945
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/102180/files
twitter:imagehttps://avatars.githubusercontent.com/u/11427362?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11427362?s=400&v=4
og:image:altA remnant of old code manually checks the sign of fds, but doesn't set errno before raising OSError: >>> os.dup2(-1, 0) Traceback (most recent call last): File "<stdin>&qu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/102180/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102180%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102180%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/102180/files
Reloadhttps://github.com/python/cpython/pull/102180/files
Reloadhttps://github.com/python/cpython/pull/102180/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/102180/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/102180/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
izbyshev:gh-102179-dup2-negative-fdhttps://github.com/izbyshev/cpython/tree/gh-102179-dup2-negative-fd
Conversation 11 https://github.com/python/cpython/pull/102180
Commits 3 https://github.com/python/cpython/pull/102180/commits
Checks 0 https://github.com/python/cpython/pull/102180/checks
Files changed https://github.com/python/cpython/pull/102180/files
Please reload this pagehttps://github.com/python/cpython/pull/102180/files
gh-102179: Fix os.dup2() error reporting for negative fds https://github.com/python/cpython/pull/102180/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/102180/files
411107d gh-102179: Fix os.dup2() error reporting for negative fds Feb 23, 2023 https://github.com/python/cpython/pull/102180/commits/411107d5a8df5fa11a2cd89d89811c8811d77cd4
01df936 Update Misc/NEWS.d/next/Library/2023-02-23-15-06-01.gh-issue-102179.P… kumaraditya303 Mar 3, 2023 https://github.com/python/cpython/pull/102180/commits/01df936fd1b7616a5ac5a850bb15ee35c59f38f9
c32ea70 Skip the test case on Emscripten Mar 4, 2023 https://github.com/python/cpython/pull/102180/commits/c32ea70c904a798d3da2237a0300f676d07a9c56
Clear filters https://github.com/python/cpython/pull/102180/files
Please reload this pagehttps://github.com/python/cpython/pull/102180/files
Please reload this pagehttps://github.com/python/cpython/pull/102180/files
test_os.py https://github.com/python/cpython/pull/102180/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
2023-02-23-15-06-01.gh-issue-102179.P6KQ4c.rst https://github.com/python/cpython/pull/102180/files#diff-d3ba70e49a6e7ac89ecd87ad6630ab2980f9f54f9e7adb77811047966d30a003
posixmodule.c https://github.com/python/cpython/pull/102180/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
Lib/test/test_os.pyhttps://github.com/python/cpython/pull/102180/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
View file https://github.com/izbyshev/cpython/blob/c32ea70c904a798d3da2237a0300f676d07a9c56/Lib/test/test_os.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/102180/{{ revealButtonHref }}
https://github.com/python/cpython/pull/102180/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/102180/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
Misc/NEWS.d/next/Library/2023-02-23-15-06-01.gh-issue-102179.P6KQ4c.rsthttps://github.com/python/cpython/pull/102180/files#diff-d3ba70e49a6e7ac89ecd87ad6630ab2980f9f54f9e7adb77811047966d30a003
View file https://github.com/izbyshev/cpython/blob/c32ea70c904a798d3da2237a0300f676d07a9c56/Misc/NEWS.d/next/Library/2023-02-23-15-06-01.gh-issue-102179.P6KQ4c.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/102180/{{ revealButtonHref }}
Modules/posixmodule.chttps://github.com/python/cpython/pull/102180/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
View file https://github.com/izbyshev/cpython/blob/c32ea70c904a798d3da2237a0300f676d07a9c56/Modules/posixmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/102180/{{ revealButtonHref }}
https://github.com/python/cpython/pull/102180/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/102180/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.