René's URL Explorer Experiment


Title: gh-88233: zipfile: refactor _strip_extra by jaraco · Pull Request #102084 · python/cpython · GitHub

Open Graph Title: gh-88233: zipfile: refactor _strip_extra by jaraco · Pull Request #102084 · python/cpython

X Title: gh-88233: zipfile: refactor _strip_extra by jaraco · Pull Request #102084 · python/cpython

Description: While reviewing #96161, I too had difficulty fully understanding the complexities of _strip_extra function. This PR refactors that function to use a class with methods separating the concerns (pars...

Open Graph Description: While reviewing #96161, I too had difficulty fully understanding the complexities of _strip_extra function. This PR refactors that function to use a class with methods separating the concerns (pars...

X Description: While reviewing #96161, I too had difficulty fully understanding the complexities of _strip_extra function. This PR refactors that function to use a class with methods separating the concerns (pars...

Opengraph URL: https://github.com/python/cpython/pull/102084

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:378ed073-3fae-385c-6c15-dcceadbf8a76
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB75E:339E6E:8A5F38:B86663:6969BE71
html-safe-noncec90b6e2fc270ec84d7f9ed68e93dd2f240d796da2c6eb7c216f1e1c4fa3035cc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzVFOjMzOUU2RTo4QTVGMzg6Qjg2NjYzOjY5NjlCRTcxIiwidmlzaXRvcl9pZCI6IjM4MDQzNTg2NTQwNzE3NjMwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaba5445fb96714e5279a1c5277e24e044221d51bb25d6a6e3d061f71520ec2a0
hovercard-subject-tagpull_request:1247601675
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/102084/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6d042fd4f73545bcb627cf7eb613c2d1158fe28ddc3757bb07929abc64f5ba34/python/cpython/pull/102084
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6d042fd4f73545bcb627cf7eb613c2d1158fe28ddc3757bb07929abc64f5ba34/python/cpython/pull/102084
og:image:altWhile reviewing #96161, I too had difficulty fully understanding the complexities of _strip_extra function. This PR refactors that function to use a class with methods separating the concerns (pars...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejaraco
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/102084#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102084
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102084
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/102084
Reloadhttps://github.com/python/cpython/pull/102084
Reloadhttps://github.com/python/cpython/pull/102084
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/102084
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/102084
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/102084#issue-comment-box
jaracohttps://github.com/jaraco
python:mainhttps://github.com/python/cpython/tree/main
jaraco:refactor/zipfile-extrahttps://github.com/jaraco/cpython/tree/refactor/zipfile-extra
gh-88233: zipfile: refactor _strip_extra https://github.com/python/cpython/pull/102084#top
jaracohttps://github.com/jaraco
python:mainhttps://github.com/python/cpython/tree/main
jaraco:refactor/zipfile-extrahttps://github.com/jaraco/cpython/tree/refactor/zipfile-extra
Conversation 5 https://github.com/python/cpython/pull/102084
Commits 5 https://github.com/python/cpython/pull/102084/commits
Checks 0 https://github.com/python/cpython/pull/102084/checks
Files changed https://github.com/python/cpython/pull/102084/files
Please reload this pagehttps://github.com/python/cpython/pull/102084
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/jaraco
jaracohttps://github.com/jaraco
Feb 20, 2023https://github.com/python/cpython/pull/102084#issue-1592194812
Please reload this pagehttps://github.com/python/cpython/pull/102084
#96161https://github.com/python/cpython/pull/96161
Zipfile lib overwrites the extra field during closing when the archive size is more then ZIP64_LIMIT #88233https://github.com/python/cpython/issues/88233
Please reload this pagehttps://github.com/python/cpython/pull/102084
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 20, 2023https://github.com/python/cpython/pull/102084#event-8563664457
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Feb 20, 2023 https://github.com/python/cpython/pull/102084#ref-issue-1199058021
Zipfile lib overwrites the extra field during closing when the archive size is more then ZIP64_LIMIT #88233 https://github.com/python/cpython/issues/88233
https://github.com/jaraco
jaracohttps://github.com/jaraco
force-pushedhttps://github.com/python/cpython/compare/13f4fad17418946ea23a669e0ef8db1e7e8562aa..6ebff4a465aca762ef62e8f919f49debe3b7575d
13f4fadhttps://github.com/python/cpython/commit/13f4fad17418946ea23a669e0ef8db1e7e8562aa
6ebff4ahttps://github.com/python/cpython/commit/6ebff4a465aca762ef62e8f919f49debe3b7575d
Compare https://github.com/python/cpython/compare/13f4fad17418946ea23a669e0ef8db1e7e8562aa..6ebff4a465aca762ef62e8f919f49debe3b7575d
February 20, 2023 16:57https://github.com/python/cpython/pull/102084#event-8563671832
jaracohttps://github.com/jaraco
February 20, 2023 12:09https://github.com/python/cpython/pull/102084#commits-pushed-de2802b
https://github.com/jaraco
Refactor zipfile._strip_extra to use higher level abstractions for ex…https://github.com/python/cpython/pull/102084/commits/de2802b1ff2e91a9c52c6d43039b3bd96f63d713
de2802bhttps://github.com/python/cpython/pull/102084/commits/de2802b1ff2e91a9c52c6d43039b3bd96f63d713
https://github.com/jaraco
Add blurbhttps://github.com/python/cpython/pull/102084/commits/796f1dd02403e9358a2d7c6e58fbb88b03d50d1b
796f1ddhttps://github.com/python/cpython/pull/102084/commits/796f1dd02403e9358a2d7c6e58fbb88b03d50d1b
https://github.com/jaraco
Remove _strip_extra and use _Extra.strip directly.https://github.com/python/cpython/pull/102084/commits/e6abc5543b9b35740a37ea3148cc900342aa429b
e6abc55https://github.com/python/cpython/pull/102084/commits/e6abc5543b9b35740a37ea3148cc900342aa429b
https://github.com/jaraco
jaracohttps://github.com/jaraco
force-pushedhttps://github.com/python/cpython/compare/6e57d1f65343553d733d2d28e0c1c7d22e1f5e08..e6abc5543b9b35740a37ea3148cc900342aa429b
6e57d1fhttps://github.com/python/cpython/commit/6e57d1f65343553d733d2d28e0c1c7d22e1f5e08
e6abc55https://github.com/python/cpython/commit/e6abc5543b9b35740a37ea3148cc900342aa429b
Compare https://github.com/python/cpython/compare/6e57d1f65343553d733d2d28e0c1c7d22e1f5e08..e6abc5543b9b35740a37ea3148cc900342aa429b
February 20, 2023 17:10https://github.com/python/cpython/pull/102084#event-8563767361
https://github.com/jaraco
jaracohttps://github.com/jaraco
Feb 25, 2023 https://github.com/python/cpython/pull/102084#pullrequestreview-1314538200
View reviewed changes https://github.com/python/cpython/pull/102084/files/e6abc5543b9b35740a37ea3148cc900342aa429b
Lib/zipfile/__init__.pyhttps://github.com/python/cpython/pull/102084/files/e6abc5543b9b35740a37ea3148cc900342aa429b#diff-7629293618f2b3cf8ae7daf98526226fa12f047d71645a05497e6687aae10c76
Please reload this pagehttps://github.com/python/cpython/pull/102084
https://github.com/jaraco
Merge branch 'main' into refactor/zipfile-extrahttps://github.com/python/cpython/pull/102084/commits/1b4bb556b7ead8969accd9a93298709c0f12f17d
1b4bb55https://github.com/python/cpython/pull/102084/commits/1b4bb556b7ead8969accd9a93298709c0f12f17d
https://github.com/jaraco
jaracohttps://github.com/jaraco
serhiy-storchakahttps://github.com/serhiy-storchaka
July 14, 2023 16:40https://github.com/python/cpython/pull/102084#event-9823655145
https://github.com/jaraco
jaracohttps://github.com/jaraco
Jul 14, 2023https://github.com/python/cpython/pull/102084#issuecomment-1636110369
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/102084
https://github.com/jaraco
Use memoryview to avoid unnecessary copies while splitting Extras.https://github.com/python/cpython/pull/102084/commits/980ae60b914acb0f4458fc2fcc5efb460df69090
980ae60https://github.com/python/cpython/pull/102084/commits/980ae60b914acb0f4458fc2fcc5efb460df69090
https://github.com/jaraco
jaracohttps://github.com/jaraco
e9791bahttps://github.com/python/cpython/commit/e9791ba35175171170ff09094ea46b91fc18c654
Sep 25, 2023https://github.com/python/cpython/pull/102084#event-10468466866
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 25, 2023https://github.com/python/cpython/pull/102084#event-10468467280
https://github.com/jaraco
jaracohttps://github.com/jaraco
September 25, 2023 23:47https://github.com/python/cpython/pull/102084#event-10468467451
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 25, 2023https://github.com/python/cpython/pull/102084#issuecomment-1734622312
e9791bahttps://github.com/python/cpython/commit/e9791ba35175171170ff09094ea46b91fc18c654
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/all/#builders/1223/builds/222https://buildbot.python.org/all/#builders/1223/builds/222
e9791bahttps://github.com/python/cpython/commit/e9791ba35175171170ff09094ea46b91fc18c654
https://buildbot.python.org/all/#builders/1223/builds/222https://buildbot.python.org/all/#builders/1223/builds/222
Please reload this pagehttps://github.com/python/cpython/pull/102084
csm10495https://github.com/csm10495
Sep 28, 2023 https://github.com/python/cpython/pull/102084#ref-commit-b3ee6d0
https://github.com/jaraco
https://github.com/csm10495
pythongh-88233https://github.com/python/cpython/issues/88233
: zipfile: refactor _strip_extra (https://github.com/csm10495/cpython/commit/b3ee6d06ed1133959284f06396251ddb9260a902
python#102084https://github.com/python/cpython/pull/102084
)https://github.com/csm10495/cpython/commit/b3ee6d06ed1133959284f06396251ddb9260a902
b3ee6d0https://github.com/csm10495/cpython/commit/b3ee6d06ed1133959284f06396251ddb9260a902
Glyphackhttps://github.com/Glyphack
Sep 2, 2024 https://github.com/python/cpython/pull/102084#ref-commit-9e459a1
https://github.com/jaraco
https://github.com/Glyphack
pythongh-88233https://github.com/python/cpython/issues/88233
: zipfile: refactor _strip_extra (https://github.com/Glyphack/cpython/commit/9e459a13c3b0c3ae6bb952bea646c3f7d4b3b61f
python#102084https://github.com/python/cpython/pull/102084
)https://github.com/Glyphack/cpython/commit/9e459a13c3b0c3ae6bb952bea646c3f7d4b3b61f
9e459a1https://github.com/Glyphack/cpython/commit/9e459a13c3b0c3ae6bb952bea646c3f7d4b3b61f
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102084
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/102084
https://github.com/jaraco
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.