René's URL Explorer Experiment


Title: gh-98886: Fix issues with dataclass fields with special underscore names by hauntsaninja · Pull Request #102032 · python/cpython · GitHub

Open Graph Title: gh-98886: Fix issues with dataclass fields with special underscore names by hauntsaninja · Pull Request #102032 · python/cpython

X Title: gh-98886: Fix issues with dataclass fields with special underscore names by hauntsaninja · Pull Request #102032 · python/cpython

Description: This commit prefixes __dataclass to several things in the locals dict: Names like _dflt_ (which cause trouble, see first test) Names like _type_ (not known to be able to cause trouble) _return_type (not known to able to cause trouble) _HAS_DEFAULT_FACTORY (which causes trouble, see second test) In addition, this removes MISSING from the locals dict. As far as I can tell, this wasn't needed even in the initial implementation of dataclasses.py (and tests on that version passed with it removed). This makes me wary :-) This is basically a continuation of #96151, where fixing this was welcomed in #98143 (comment) Issue: gh-98886

Open Graph Description: This commit prefixes __dataclass to several things in the locals dict: Names like _dflt_ (which cause trouble, see first test) Names like _type_ (not known to be able to cause trouble) _return_typ...

X Description: This commit prefixes __dataclass to several things in the locals dict: Names like _dflt_ (which cause trouble, see first test) Names like _type_ (not known to be able to cause trouble) _return_typ...

Opengraph URL: https://github.com/python/cpython/pull/102032

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e3f27fe6-6649-2716-5512-8cc7c1eda63d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id81B2:3463DE:25A518C:33FA132:6A4F4CDC
html-safe-noncec31570caefa4bfcb97fa88d9920bde7b73de859fb54ef2c2f327104259e2f010
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUIyOjM0NjNERToyNUE1MThDOjMzRkExMzI6NkE0RjRDREMiLCJ2aXNpdG9yX2lkIjoiODk1MjY3Mjg1ODg2NzgyNjg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac00b75ab29edc50f348febe41c569b6cfc9ae14abeb460dcfc8ea2ed9e8e9c1fe
hovercard-subject-tagpull_request:1246148301
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/102032/files
twitter:imagehttps://avatars.githubusercontent.com/u/12621235?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12621235?s=400&v=4
og:image:altThis commit prefixes __dataclass to several things in the locals dict: Names like _dflt_ (which cause trouble, see first test) Names like _type_ (not known to be able to cause trouble) _return_typ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/102032/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102032%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F102032%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/102032/files
Reloadhttps://github.com/python/cpython/pull/102032/files
Reloadhttps://github.com/python/cpython/pull/102032/files
Please reload this pagehttps://github.com/python/cpython/pull/102032/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/102032/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
hauntsaninjahttps://github.com/hauntsaninja
python:mainhttps://github.com/python/cpython/tree/main
hauntsaninja:gh-98886https://github.com/hauntsaninja/cpython/tree/gh-98886
Conversation 3 https://github.com/python/cpython/pull/102032
Commits 5 https://github.com/python/cpython/pull/102032/commits
Checks 0 https://github.com/python/cpython/pull/102032/checks
Files changed https://github.com/python/cpython/pull/102032/files
Please reload this pagehttps://github.com/python/cpython/pull/102032/files
gh-98886: Fix issues with dataclass fields with special underscore names https://github.com/python/cpython/pull/102032/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/102032/files
8b906cb gh-98886: Fix issues with fields with special underscore names hauntsaninja Feb 18, 2023 https://github.com/python/cpython/pull/102032/commits/8b906cb66a4f7de2c3b27d89ae002feb0a95cdc0
f6ad0f4 📜🤖 Added by blurb_it. blurb-it[bot] Feb 18, 2023 https://github.com/python/cpython/pull/102032/commits/f6ad0f447e87b8bca5b5684f60d322b76230be0e
7217b1a Merge branch 'main' into gh-98886 hauntsaninja Feb 20, 2023 https://github.com/python/cpython/pull/102032/commits/7217b1ac89bdb9cd4d4ad4d9a4cb1288617255f5
4322f6f Merge branch 'main' into gh-98886 hauntsaninja Feb 20, 2023 https://github.com/python/cpython/pull/102032/commits/4322f6f7da0800e8b7a8f23fb40efbc98c9a1075
c1d22c7 use dunder names hauntsaninja Mar 8, 2023 https://github.com/python/cpython/pull/102032/commits/c1d22c72226c07518de5842311f79d687ac5de8e
Clear filters https://github.com/python/cpython/pull/102032/files
Please reload this pagehttps://github.com/python/cpython/pull/102032/files
Please reload this pagehttps://github.com/python/cpython/pull/102032/files
dataclasses.py https://github.com/python/cpython/pull/102032/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
test_dataclasses.py https://github.com/python/cpython/pull/102032/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
2023-02-18-23-03-50.gh-issue-98886.LkKGWv.rst https://github.com/python/cpython/pull/102032/files#diff-141e05e3499c78748725416467b475c78939ace53a5befd3f3766d8e1fb02195
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L425
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/102032/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
View file https://github.com/hauntsaninja/cpython/blob/c1d22c72226c07518de5842311f79d687ac5de8e/Lib/dataclasses.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/102032/{{ revealButtonHref }}
https://github.com/python/cpython/pull/102032/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/102032/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/102032/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/102032/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/102032/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/102032/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/102032/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
Lib/test/test_dataclasses.pyhttps://github.com/python/cpython/pull/102032/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
View file https://github.com/hauntsaninja/cpython/blob/c1d22c72226c07518de5842311f79d687ac5de8e/Lib/test/test_dataclasses.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/102032/{{ revealButtonHref }}
https://github.com/python/cpython/pull/102032/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
https://github.com/python/cpython/pull/102032/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
Misc/NEWS.d/next/Library/2023-02-18-23-03-50.gh-issue-98886.LkKGWv.rsthttps://github.com/python/cpython/pull/102032/files#diff-141e05e3499c78748725416467b475c78939ace53a5befd3f3766d8e1fb02195
View file https://github.com/hauntsaninja/cpython/blob/c1d22c72226c07518de5842311f79d687ac5de8e/Misc/NEWS.d/next/Library/2023-02-18-23-03-50.gh-issue-98886.LkKGWv.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/102032/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.