René's URL Explorer Experiment


Title: gh-101758: Add _PyState_AddModule() Back for the Stable ABI by ericsnowcurrently · Pull Request #101956 · python/cpython · GitHub

Open Graph Title: gh-101758: Add _PyState_AddModule() Back for the Stable ABI by ericsnowcurrently · Pull Request #101956 · python/cpython

X Title: gh-101758: Add _PyState_AddModule() Back for the Stable ABI by ericsnowcurrently · Pull Request #101956 · python/cpython

Description: We're adding the function back, only for the stable ABI symbol and not as any form of API. I had removed it yesterday. This undocumented "private" function was added with the implementation for PEP 3121 (3.0, 2007) for internal use and later moved out of the limited API (3.6, 2016) and then into the internal API (3.9, 2019). I removed it completely yesterday, including from the stable ABI manifest (where it was added because the symbol happened to be exported). It's unlikely that anyone is using _PyState_AddModule(), especially any stable ABI extensions built against 3.2-3.5, but we're playing it safe. (See my comment.) Issue: gh-101758

Open Graph Description: We're adding the function back, only for the stable ABI symbol and not as any form of API. I had removed it yesterday. This undocumented "private" function was added with the impleme...

X Description: We're adding the function back, only for the stable ABI symbol and not as any form of API. I had removed it yesterday. This undocumented "private" function was added with...

Opengraph URL: https://github.com/python/cpython/pull/101956

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:90255ea7-f04f-c56d-59a8-7a4a0053b612
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA02:9CC2A:22C9CC0:2FEF058:696ABE18
html-safe-noncebd56e4ad7dcd8efe70c26efce76a9665f18f29b285fa885a101dc20b075ae101
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTAyOjlDQzJBOjIyQzlDQzA6MkZFRjA1ODo2OTZBQkUxOCIsInZpc2l0b3JfaWQiOiI0NTkzMDU4MjQ4ODE3MDMyNzI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9a37a08e078b568d6b83c78d89b859057fcfc6f6e999f68c275d0f6e9a65a8ab
hovercard-subject-tagpull_request:1243987723
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/101956/files
twitter:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
og:image:altWe're adding the function back, only for the stable ABI symbol and not as any form of API. I had removed it yesterday. This undocumented "private" function was added with the impleme...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/101956/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101956%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101956%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/101956/files
Reloadhttps://github.com/python/cpython/pull/101956/files
Reloadhttps://github.com/python/cpython/pull/101956/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/101956/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/101956/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:add-_PyState_AddModule-backhttps://github.com/ericsnowcurrently/cpython/tree/add-_PyState_AddModule-back
Conversation 0 https://github.com/python/cpython/pull/101956
Commits 2 https://github.com/python/cpython/pull/101956/commits
Checks 0 https://github.com/python/cpython/pull/101956/checks
Files changed https://github.com/python/cpython/pull/101956/files
Please reload this pagehttps://github.com/python/cpython/pull/101956/files
gh-101758: Add _PyState_AddModule() Back for the Stable ABI https://github.com/python/cpython/pull/101956/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/101956/files
3222797 Add _PyState_AddModule() back for the stable ABI. ericsnowcurrently Feb 16, 2023 https://github.com/python/cpython/pull/101956/commits/32227972a9751ca5349f8d503ad8a09fb69d6c63
78e9617 Also export the symbol. ericsnowcurrently Feb 16, 2023 https://github.com/python/cpython/pull/101956/commits/78e9617a3cedec7c0c0720109e6a5ea0abc8ced8
Clear filters https://github.com/python/cpython/pull/101956/files
Please reload this pagehttps://github.com/python/cpython/pull/101956/files
Please reload this pagehttps://github.com/python/cpython/pull/101956/files
pycore_pystate.h https://github.com/python/cpython/pull/101956/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
test_stable_abi_ctypes.py https://github.com/python/cpython/pull/101956/files#diff-e23b7eb96b17ef58f28bd65875edc3ec27eeb85be4c342d0c2d9c74121a74c0b
stable_abi.toml https://github.com/python/cpython/pull/101956/files#diff-f098b9ddf231fb279a9f5b4b8ed22c4241e1ffed7fe0deffb2c76bb2126d2911
python3dll.c https://github.com/python/cpython/pull/101956/files#diff-be34b08a4cde4f0bfbf86bc3c427e4a3dcc3f2f472061a50d00040a0d8a57c88
import.c https://github.com/python/cpython/pull/101956/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L311
Include/internal/pycore_pystate.hhttps://github.com/python/cpython/pull/101956/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
View file https://github.com/ericsnowcurrently/cpython/blob/78e9617a3cedec7c0c0720109e6a5ea0abc8ced8/Include/internal/pycore_pystate.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101956/{{ revealButtonHref }}
https://github.com/python/cpython/pull/101956/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
https://github.com/python/cpython/pull/101956/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
Lib/test/test_stable_abi_ctypes.pyhttps://github.com/python/cpython/pull/101956/files#diff-e23b7eb96b17ef58f28bd65875edc3ec27eeb85be4c342d0c2d9c74121a74c0b
View file https://github.com/ericsnowcurrently/cpython/blob/78e9617a3cedec7c0c0720109e6a5ea0abc8ced8/Lib/test/test_stable_abi_ctypes.py
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/101956/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L138
Misc/stable_abi.tomlhttps://github.com/python/cpython/pull/101956/files#diff-f098b9ddf231fb279a9f5b4b8ed22c4241e1ffed7fe0deffb2c76bb2126d2911
View file https://github.com/ericsnowcurrently/cpython/blob/78e9617a3cedec7c0c0720109e6a5ea0abc8ced8/Misc/stable_abi.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101956/{{ revealButtonHref }}
https://github.com/python/cpython/pull/101956/files#diff-f098b9ddf231fb279a9f5b4b8ed22c4241e1ffed7fe0deffb2c76bb2126d2911
https://github.com/python/cpython/pull/101956/files#diff-f098b9ddf231fb279a9f5b4b8ed22c4241e1ffed7fe0deffb2c76bb2126d2911
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L184
PC/python3dll.chttps://github.com/python/cpython/pull/101956/files#diff-be34b08a4cde4f0bfbf86bc3c427e4a3dcc3f2f472061a50d00040a0d8a57c88
View file https://github.com/ericsnowcurrently/cpython/blob/78e9617a3cedec7c0c0720109e6a5ea0abc8ced8/PC/python3dll.c
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/101956/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L261
Python/import.chttps://github.com/python/cpython/pull/101956/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
View file https://github.com/ericsnowcurrently/cpython/blob/78e9617a3cedec7c0c0720109e6a5ea0abc8ced8/Python/import.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101956/{{ revealButtonHref }}
https://github.com/python/cpython/pull/101956/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/101956/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.