René's URL Explorer Experiment


Title: gh-99108: Build the hashlib HACL* code as a static library. (fix wasm builds) by gpshead · Pull Request #101917 · python/cpython · GitHub

Open Graph Title: gh-99108: Build the hashlib HACL* code as a static library. (fix wasm builds) by gpshead · Pull Request #101917 · python/cpython

X Title: gh-99108: Build the hashlib HACL* code as a static library. (fix wasm builds) by gpshead · Pull Request #101917 · python/cpython

Description: A followup to #101707 which broke some builds. This builds HACL* as a library in one place. This doesn't solve all the problems, the wasm-wasi build is fixed by this. The wasm-enscripten build is...

Open Graph Description: A followup to #101707 which broke some builds. This builds HACL* as a library in one place. This doesn't solve all the problems, the wasm-wasi build is fixed by this. The wasm-enscripten buil...

X Description: A followup to #101707 which broke some builds. This builds HACL* as a library in one place. This doesn't solve all the problems, the wasm-wasi build is fixed by this. The wasm-enscripten ...

Opengraph URL: https://github.com/python/cpython/pull/101917

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0ba82d7e-e5ce-48b1-4614-7a2d134ff025
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA788:36099A:7FDCAE:B30474:696A20DA
html-safe-nonceaf8713c5a02638af3fe47d94e1f8db657ad1b4dfc906e995b28873e6fca92a1f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzg4OjM2MDk5QTo3RkRDQUU6QjMwNDc0OjY5NkEyMERBIiwidmlzaXRvcl9pZCI6IjU5MTA1MTI0NDI5MzA3NjYwNDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2196d6e5d23f7b1a5f0f5b5571e2db2552a3a9c267c7e5ff4eab4278d89c9416
hovercard-subject-tagpull_request:1241214748
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/101917/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/48354f6b0b1f772d8bbf387c8d2c9f1a205f7cd93244d07dba44085828c11b07/python/cpython/pull/101917
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/48354f6b0b1f772d8bbf387c8d2c9f1a205f7cd93244d07dba44085828c11b07/python/cpython/pull/101917
og:image:altA followup to #101707 which broke some builds. This builds HACL* as a library in one place. This doesn't solve all the problems, the wasm-wasi build is fixed by this. The wasm-enscripten buil...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegpshead
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/101917#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101917
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101917
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/101917
Reloadhttps://github.com/python/cpython/pull/101917
Reloadhttps://github.com/python/cpython/pull/101917
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/101917
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/101917
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/101917#issue-comment-box
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:build/libhaclhttps://github.com/gpshead/cpython/tree/build/libhacl
gh-99108: Build the hashlib HACL* code as a static library. (fix wasm builds) https://github.com/python/cpython/pull/101917#top
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:build/libhaclhttps://github.com/gpshead/cpython/tree/build/libhacl
Conversation 8 https://github.com/python/cpython/pull/101917
Commits 4 https://github.com/python/cpython/pull/101917/commits
Checks 0 https://github.com/python/cpython/pull/101917/checks
Files changed https://github.com/python/cpython/pull/101917/files
Please reload this pagehttps://github.com/python/cpython/pull/101917
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 14, 2023https://github.com/python/cpython/pull/101917#issue-1584869964
Please reload this pagehttps://github.com/python/cpython/pull/101917
#101707https://github.com/python/cpython/pull/101707
Replace built-in hashlib with verified implementations from HACL* #99108https://github.com/python/cpython/issues/99108
Please reload this pagehttps://github.com/python/cpython/pull/101917
gpsheadhttps://github.com/gpshead
February 14, 2023 21:37https://github.com/python/cpython/pull/101917#commits-pushed-22b2267
https://github.com/gpshead
Build HACL* SHA2 as a static library.https://github.com/python/cpython/pull/101917/commits/22b22674e46d6a061f4e6b1c099edf6dfa793383
22b2267https://github.com/python/cpython/pull/101917/commits/22b22674e46d6a061f4e6b1c099edf6dfa793383
https://github.com/gpshead
direct .a reference (no real difference)https://github.com/python/cpython/pull/101917/commits/3c7e18ec5e03d9219e2ba07b1dca068747208e8b
3c7e18ehttps://github.com/python/cpython/pull/101917/commits/3c7e18ec5e03d9219e2ba07b1dca068747208e8b
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 14, 2023https://github.com/python/cpython/pull/101917#event-8520046206
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 14, 2023https://github.com/python/cpython/pull/101917#issuecomment-1430416398
Please reload this pagehttps://github.com/python/cpython/pull/101917
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Feb 14, 2023https://github.com/python/cpython/pull/101917#issuecomment-1430416434
@gpsheadhttps://github.com/gpshead
3c7e18ehttps://github.com/python/cpython/commit/3c7e18ec5e03d9219e2ba07b1dca068747208e8b
Please reload this pagehttps://github.com/python/cpython/pull/101917
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 14, 2023https://github.com/python/cpython/pull/101917#issuecomment-1430437561
Please reload this pagehttps://github.com/python/cpython/pull/101917
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
OS-wasi https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-wasi
Feb 14, 2023https://github.com/python/cpython/pull/101917#event-8520207860
https://github.com/gpshead
use -l instead of the .a file again.https://github.com/python/cpython/pull/101917/commits/a5bb63e5e00a27980ab55fab116cc85fe25b155f
a5bb63ehttps://github.com/python/cpython/pull/101917/commits/a5bb63e5e00a27980ab55fab116cc85fe25b155f
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 14, 2023https://github.com/python/cpython/pull/101917#issuecomment-1430449257
Please reload this pagehttps://github.com/python/cpython/pull/101917
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Feb 14, 2023https://github.com/python/cpython/pull/101917#issuecomment-1430449311
@gpsheadhttps://github.com/gpshead
a5bb63ehttps://github.com/python/cpython/commit/a5bb63e5e00a27980ab55fab116cc85fe25b155f
Please reload this pagehttps://github.com/python/cpython/pull/101917
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 14, 2023https://github.com/python/cpython/pull/101917#issuecomment-1430486892
Please reload this pagehttps://github.com/python/cpython/pull/101917
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
brettcannonhttps://github.com/brettcannon
February 14, 2023 22:42https://github.com/python/cpython/pull/101917#event-8520426968
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 14, 2023https://github.com/python/cpython/pull/101917#event-8520436238
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 14, 2023https://github.com/python/cpython/pull/101917#event-8520436703
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Feb 14, 2023 https://github.com/python/cpython/pull/101917#ref-issue-1436673526
Replace built-in hashlib with verified implementations from HACL* #99108 https://github.com/python/cpython/issues/99108
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 14, 2023https://github.com/python/cpython/pull/101917#event-8520437437
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
February 14, 2023 22:44https://github.com/python/cpython/pull/101917#event-8520439279
https://github.com/gpshead
Go back to the .a file, emcc undoes -L -l anyways.https://github.com/python/cpython/pull/101917/commits/6cd13a41e4c9c0b0463814bde3e3ad7669d8a33b
6cd13a4https://github.com/python/cpython/pull/101917/commits/6cd13a41e4c9c0b0463814bde3e3ad7669d8a33b
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 14, 2023https://github.com/python/cpython/pull/101917#issuecomment-1430495518
Please reload this pagehttps://github.com/python/cpython/pull/101917
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 14, 2023https://github.com/python/cpython/pull/101917#event-8520473979
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 14, 2023https://github.com/python/cpython/pull/101917#issuecomment-1430503232
Please reload this pagehttps://github.com/python/cpython/pull/101917
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
d777790https://github.com/python/cpython/commit/d777790bab878b8d1a218a1a60894b2823485cca
Feb 14, 2023https://github.com/python/cpython/pull/101917#event-8520787352
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 14, 2023https://github.com/python/cpython/pull/101917#event-8520787633
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
February 14, 2023 23:57https://github.com/python/cpython/pull/101917#event-8520787983
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Feb 15, 2023 https://github.com/python/cpython/pull/101917#ref-pullrequest-1585089420
gh-99108: Refactor _sha256 & _sha512 into _sha2. #101924 https://github.com/python/cpython/pull/101924
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101917
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
OS-wasi https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-wasi
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/101917
https://github.com/gpshead
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.