René's URL Explorer Experiment


Title: gh-101561: Add typing.override decorator by stroxler · Pull Request #101564 · python/cpython · GitHub

Open Graph Title: gh-101561: Add typing.override decorator by stroxler · Pull Request #101564 · python/cpython

X Title: gh-101561: Add typing.override decorator by stroxler · Pull Request #101564 · python/cpython

Description: The code is pulled almost unchanged from typing_extensions: decorator implementation tests Question that came up was where to put the type variable and what to name it: In typing_extensions the type variables use underscore prefixes to indicate that they are not public, but typing doesn't appear to use that convention so I named the type variable F. I couldn't put the type variable next to all of the other ones (used in generic container definitions) because it relies on Callable which is defined below. If this is a problem I could correct it using a forward reference, or we could try to rearrange the module to put special forms above type variables. Testing the code: First set up the repo, following instructions at https://devguide.python.org/ by running: ./configure --with-pydebug && make -j Then run the typing tests: ./python -m test test_typing -v I ran the full test suite with ./python -m test -j3 and it came back clean except for a test_grp failure which I seem to get on trunk as well - likely something in my build is misconfigured but I'm pretty sure it is unrelated to the changes here. Issue: gh-101561 Make sure the docs build: cd Doc make venv make html

Open Graph Description: The code is pulled almost unchanged from typing_extensions: decorator implementation tests Question that came up was where to put the type variable and what to name it: In typing_extensions the ...

X Description: The code is pulled almost unchanged from typing_extensions: decorator implementation tests Question that came up was where to put the type variable and what to name it: In typing_extensions the ...

Opengraph URL: https://github.com/python/cpython/pull/101564

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b138bf49-5cd2-6914-83c1-c7495c7560f9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA2C:30006B:625B77:83F939:6969B544
html-safe-nonce112729087ed258d4d2a979d978c9934d9250550b4116f7df40b28771121b6dce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTJDOjMwMDA2Qjo2MjVCNzc6ODNGOTM5OjY5NjlCNTQ0IiwidmlzaXRvcl9pZCI6IjQ5NTA4Njk1ODE5NDk5NDEwNjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf2ff374664b0d55ed382b26b0948e2d5c8c7fe25b82c5dbb309aedcb9ef7ee77
hovercard-subject-tagpull_request:1229170473
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/101564/files
twitter:imagehttps://avatars.githubusercontent.com/u/966970?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/966970?s=400&v=4
og:image:altThe code is pulled almost unchanged from typing_extensions: decorator implementation tests Question that came up was where to put the type variable and what to name it: In typing_extensions the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/101564/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101564%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101564%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/101564/files
Reloadhttps://github.com/python/cpython/pull/101564/files
Reloadhttps://github.com/python/cpython/pull/101564/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/101564/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/101564/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
stroxler:gh-101561-typing-overridehttps://github.com/stroxler/cpython/tree/gh-101561-typing-override
Conversation 14 https://github.com/python/cpython/pull/101564
Commits 10 https://github.com/python/cpython/pull/101564/commits
Checks 0 https://github.com/python/cpython/pull/101564/checks
Files changed https://github.com/python/cpython/pull/101564/files
Please reload this pagehttps://github.com/python/cpython/pull/101564/files
gh-101561: Add typing.override decorator https://github.com/python/cpython/pull/101564/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/101564/files
e2349bb PEP 698: Add typing.override decorator stroxler Feb 3, 2023 https://github.com/python/cpython/pull/101564/commits/e2349bb8fffbd7d6b9043c026ed92dcc0b06a762
bd3b6ac Add missing `For example::` in the rst doc stroxler Feb 4, 2023 https://github.com/python/cpython/pull/101564/commits/bd3b6acff2096fcd6ce2111c6e155300f07438fa
c3b9b7f 📜🤖 Added by blurb_it. blurb-it[bot] Feb 4, 2023 https://github.com/python/cpython/pull/101564/commits/c3b9b7f4ffbc2c228953a1c6af6d9a32b6bd3aa9
c7cecf8 Update Doc/library/typing.rst stroxler Feb 4, 2023 https://github.com/python/cpython/pull/101564/commits/c7cecf8200fafbfad58b748f16c4184e96bdb23a
2acf32f Add whatsnew entry, as per Alex Waygood's suggestion stroxler Feb 4, 2023 https://github.com/python/cpython/pull/101564/commits/2acf32fd373322903a3be20ce50d11a9881f42b2
6bd3356 Add ACKS entry, fix rst errors stroxler Feb 4, 2023 https://github.com/python/cpython/pull/101564/commits/6bd3356398628050b0caf7be605cb0f75a133b57
42277cb Fix title underline length in whatisnew doc. stroxler Feb 4, 2023 https://github.com/python/cpython/pull/101564/commits/42277cb9561014d7a7d188f86d35f2625b388616
afb74de Update Misc/NEWS.d/next/Library/2023-02-04-16-35-46.gh-issue-101561.X… stroxler Feb 4, 2023 https://github.com/python/cpython/pull/101564/commits/afb74de6274ef8fbb3927d7688129c15b87f2c7c
090d9d2 Use a positional-only argument named `method` stroxler Feb 4, 2023 https://github.com/python/cpython/pull/101564/commits/090d9d294a889b833372342cd65ed129e1984bd9
f6c00e5 Apply suggestions from code review stroxler Feb 27, 2023 https://github.com/python/cpython/pull/101564/commits/f6c00e54c3eea74c65dba0c87737cb78920fd01d
Clear filters https://github.com/python/cpython/pull/101564/files
Please reload this pagehttps://github.com/python/cpython/pull/101564/files
Please reload this pagehttps://github.com/python/cpython/pull/101564/files
typing.rst https://github.com/python/cpython/pull/101564/files#diff-8a0f115fde6769c122b771b6d0eca184c4580f7b5fabe2f0b0579c679424364f
3.12.rst https://github.com/python/cpython/pull/101564/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b
test_typing.py https://github.com/python/cpython/pull/101564/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
typing.py https://github.com/python/cpython/pull/101564/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
ACKS https://github.com/python/cpython/pull/101564/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
2023-02-04-16-35-46.gh-issue-101561.Xo6pIZ.rst https://github.com/python/cpython/pull/101564/files#diff-e7ccb753b67dc661328fcc023f365f40fef35b95002fd858c79430e81858f9cb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L598
Doc/library/typing.rsthttps://github.com/python/cpython/pull/101564/files#diff-8a0f115fde6769c122b771b6d0eca184c4580f7b5fabe2f0b0579c679424364f
View file https://github.com/stroxler/cpython/blob/f6c00e54c3eea74c65dba0c87737cb78920fd01d/Doc/library/typing.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101564/{{ revealButtonHref }}
https://github.com/python/cpython/pull/101564/files#diff-8a0f115fde6769c122b771b6d0eca184c4580f7b5fabe2f0b0579c679424364f
https://github.com/python/cpython/pull/101564/files#diff-8a0f115fde6769c122b771b6d0eca184c4580f7b5fabe2f0b0579c679424364f
https://github.com/python/cpython/pull/101564/files#diff-8a0f115fde6769c122b771b6d0eca184c4580f7b5fabe2f0b0579c679424364f
https://github.com/python/cpython/pull/101564/files#diff-8a0f115fde6769c122b771b6d0eca184c4580f7b5fabe2f0b0579c679424364f
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L114
Doc/whatsnew/3.12.rsthttps://github.com/python/cpython/pull/101564/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b
View file https://github.com/stroxler/cpython/blob/f6c00e54c3eea74c65dba0c87737cb78920fd01d/Doc/whatsnew/3.12.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101564/{{ revealButtonHref }}
https://github.com/python/cpython/pull/101564/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b
https://github.com/python/cpython/pull/101564/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L599
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/101564/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
View file https://github.com/stroxler/cpython/blob/f6c00e54c3eea74c65dba0c87737cb78920fd01d/Lib/test/test_typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101564/{{ revealButtonHref }}
https://github.com/python/cpython/pull/101564/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/101564/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/101564/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/101564/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L601
Lib/typing.pyhttps://github.com/python/cpython/pull/101564/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
View file https://github.com/stroxler/cpython/blob/f6c00e54c3eea74c65dba0c87737cb78920fd01d/Lib/typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101564/{{ revealButtonHref }}
https://github.com/python/cpython/pull/101564/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/101564/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/101564/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/101564/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/101564/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/101564/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/101564/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
Misc/ACKShttps://github.com/python/cpython/pull/101564/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
View file https://github.com/stroxler/cpython/blob/f6c00e54c3eea74c65dba0c87737cb78920fd01d/Misc/ACKS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101564/{{ revealButtonHref }}
https://github.com/python/cpython/pull/101564/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/pull/101564/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
Misc/NEWS.d/next/Library/2023-02-04-16-35-46.gh-issue-101561.Xo6pIZ.rsthttps://github.com/python/cpython/pull/101564/files#diff-e7ccb753b67dc661328fcc023f365f40fef35b95002fd858c79430e81858f9cb
View file https://github.com/stroxler/cpython/blob/f6c00e54c3eea74c65dba0c87737cb78920fd01d/Misc/NEWS.d/next/Library/2023-02-04-16-35-46.gh-issue-101561.Xo6pIZ.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101564/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.