René's URL Explorer Experiment


Title: GH-100288: Skip extra work when failing to specialize `LOAD_ATTR` by brandtbucher · Pull Request #101354 · python/cpython · GitHub

Open Graph Title: GH-100288: Skip extra work when failing to specialize `LOAD_ATTR` by brandtbucher · Pull Request #101354 · python/cpython

X Title: GH-100288: Skip extra work when failing to specialize `LOAD_ATTR` by brandtbucher · Pull Request #101354 · python/cpython

Description: I think this was missed in #100753. This removes a dict lookup, a dict version, and a cache write from one case where we fail to specialize method loads (due to the existence of a non-managed insta...

Open Graph Description: I think this was missed in #100753. This removes a dict lookup, a dict version, and a cache write from one case where we fail to specialize method loads (due to the existence of a non-managed insta...

X Description: I think this was missed in #100753. This removes a dict lookup, a dict version, and a cache write from one case where we fail to specialize method loads (due to the existence of a non-managed insta...

Opengraph URL: https://github.com/python/cpython/pull/101354

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4bacd694-f8c1-9cdc-ba8e-5df43426fec4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9250:17C6E:307B7C3:43A8714:69693628
html-safe-nonce2f33abf29ff2657c85f9e76dca2f33fd6a7fafd9bb1666d7dc47d4246c4efde8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjUwOjE3QzZFOjMwN0I3QzM6NDNBODcxNDo2OTY5MzYyOCIsInZpc2l0b3JfaWQiOiI2MjIyMzUyODcyNzgzODIwMzI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbd0160b6f2c905e4bef64b85b935a6476fc1b46fb52657baa2366966574a56f4
hovercard-subject-tagpull_request:1218410055
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/101354/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a07d764044a4bd6a90a3bb261828e3ae71ba27d36f82b5f9ba92ffb1673b4a4c/python/cpython/pull/101354
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a07d764044a4bd6a90a3bb261828e3ae71ba27d36f82b5f9ba92ffb1673b4a4c/python/cpython/pull/101354
og:image:altI think this was missed in #100753. This removes a dict lookup, a dict version, and a cache write from one case where we fail to specialize method loads (due to the existence of a non-managed insta...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrandtbucher
hostnamegithub.com
expected-hostnamegithub.com
None54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released69ac0477df0f87da03b8b06cebd187012d7a930
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/101354#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101354
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101354
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/101354
Reloadhttps://github.com/python/cpython/pull/101354
Reloadhttps://github.com/python/cpython/pull/101354
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/101354
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/101354
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/101354#issue-comment-box
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:remove-old-branchhttps://github.com/brandtbucher/cpython/tree/remove-old-branch
GH-100288: Skip extra work when failing to specialize LOAD_ATTR https://github.com/python/cpython/pull/101354#top
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:remove-old-branchhttps://github.com/brandtbucher/cpython/tree/remove-old-branch
Conversation 6 https://github.com/python/cpython/pull/101354
Commits 2 https://github.com/python/cpython/pull/101354/commits
Checks 0 https://github.com/python/cpython/pull/101354/checks
Files changed https://github.com/python/cpython/pull/101354/files
Please reload this pagehttps://github.com/python/cpython/pull/101354
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jan 26, 2023https://github.com/python/cpython/pull/101354#issue-1558744294
Please reload this pagehttps://github.com/python/cpython/pull/101354
#100753https://github.com/python/cpython/pull/100753
Finish up LOAD_ATTR specialisation #100288https://github.com/python/cpython/issues/100288
Please reload this pagehttps://github.com/python/cpython/pull/101354
brandtbucherhttps://github.com/brandtbucher
January 17, 2023 00:47https://github.com/python/cpython/pull/101354#commits-pushed-d6dcb34
https://github.com/brandtbucher
Remove old branchhttps://github.com/python/cpython/pull/101354/commits/d6dcb34303f560b1c9d89ca8ff9be3414c08171b
d6dcb34https://github.com/python/cpython/pull/101354/commits/d6dcb34303f560b1c9d89ca8ff9be3414c08171b
https://github.com/brandtbucher
Simplify method load specializationhttps://github.com/python/cpython/pull/101354/commits/b1845b61a4560bcac938fd4bd7685bdb983cf3f9
b1845b6https://github.com/python/cpython/pull/101354/commits/b1845b61a4560bcac938fd4bd7685bdb983cf3f9
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
interpreter-core https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Ainterpreter-core
Jan 26, 2023https://github.com/python/cpython/pull/101354#event-8367685327
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
markshannonhttps://github.com/markshannon
January 26, 2023 20:37https://github.com/python/cpython/pull/101354#event-8367685366
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jan 26, 2023https://github.com/python/cpython/pull/101354#event-8367685435
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 26, 2023https://github.com/python/cpython/pull/101354#event-8367685757
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 26, 2023 https://github.com/python/cpython/pull/101354#ref-issue-1499820911
Finish up LOAD_ATTR specialisation #100288 https://github.com/python/cpython/issues/100288
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jan 27, 2023 https://github.com/python/cpython/pull/101354#pullrequestreview-1272474691
View reviewed changes https://github.com/python/cpython/pull/101354/files/d6dcb34303f560b1c9d89ca8ff9be3414c08171b
markshannonhttps://github.com/markshannon
https://github.com/python/cpython/pull/101354#pullrequestreview-1272474691
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/101354
Python/specialize.chttps://github.com/python/cpython/pull/101354/files/d6dcb34303f560b1c9d89ca8ff9be3414c08171b#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
markshannonhttps://github.com/markshannon
Jan 27, 2023https://github.com/python/cpython/pull/101354#discussion_r1088829902
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/101354
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jan 27, 2023https://github.com/python/cpython/pull/101354#issuecomment-1406912582
Please reload this pagehttps://github.com/python/cpython/pull/101354
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jan 29, 2023https://github.com/python/cpython/pull/101354#issuecomment-1407640570
Please reload this pagehttps://github.com/python/cpython/pull/101354
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jan 31, 2023https://github.com/python/cpython/pull/101354#issuecomment-1410269320
Please reload this pagehttps://github.com/python/cpython/pull/101354
https://github.com/markshannon
markshannonhttps://github.com/markshannon
January 31, 2023 12:34https://github.com/python/cpython/pull/101354#event-8398914373
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jan 31, 2023 https://github.com/python/cpython/pull/101354#pullrequestreview-1277087783
View reviewed changes https://github.com/python/cpython/pull/101354/files/b1845b61a4560bcac938fd4bd7685bdb983cf3f9
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 31, 2023https://github.com/python/cpython/pull/101354#event-8398917469
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jan 31, 2023https://github.com/python/cpython/pull/101354#issuecomment-1411092610
Please reload this pagehttps://github.com/python/cpython/pull/101354
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
76efcb4https://github.com/python/cpython/commit/76efcb40930d1584e8706f015d0e5475fb16acb5
Jan 31, 2023https://github.com/python/cpython/pull/101354#event-8403947685
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 31, 2023https://github.com/python/cpython/pull/101354#event-8403948083
carljmhttps://github.com/carljm
Jan 31, 2023 https://github.com/python/cpython/pull/101354#ref-commit-db208d5
https://github.com/carljm
Merge branch 'main' into inlinecomp2https://github.com/carljm/cpython/commit/db208d57128896c3600386d07313bf47ea13c022
db208d5https://github.com/carljm/cpython/commit/db208d57128896c3600386d07313bf47ea13c022
pythonGH-100288https://github.com/python/cpython/issues/100288
pythonGH-101354https://github.com/python/cpython/pull/101354
pythongh-101409https://github.com/python/cpython/issues/101409
python#101411https://github.com/python/cpython/pull/101411
pythongh-98831https://github.com/python/cpython/issues/98831
python#101458https://github.com/python/cpython/pull/101458
pythongh-101469https://github.com/python/cpython/issues/101469
pythonGH-101470https://github.com/python/cpython/pull/101470
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101354
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/python/cpython/pull/101354/files/b1845b61a4560bcac938fd4bd7685bdb983cf3f9
https://github.com/brandtbucher
brandtbucher https://github.com/brandtbucher
interpreter-core https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Ainterpreter-core
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/101354
https://github.com/brandtbucher
https://github.com/markshannon
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.