| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:85838c84-83f0-9bda-8223-40395d746a7d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 919E:2695F6:B09731:F3BFC8:6969F12B |
| html-safe-nonce | 0c6964d2f09d289ea213f865266b0eed28dc295cf0dbd5849fef508b68569fab |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTlFOjI2OTVGNjpCMDk3MzE6RjNCRkM4OjY5NjlGMTJCIiwidmlzaXRvcl9pZCI6IjI2NjE1MzI4NzkzNzkwOTk5NDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 69c93cf967d60176e94fec7afd375ac4f12192c0811e3a530d8aacf55ba85528 |
| hovercard-subject-tag | pull_request:1216778483 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/101323/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9ef8868a5a7d1006afe42995259a29b577dbfdd5ad5d35d83b970a14609f35fc/python/cpython/pull/101323 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9ef8868a5a7d1006afe42995259a29b577dbfdd5ad5d35d83b970a14609f35fc/python/cpython/pull/101323 |
| og:image:alt | Turns out that when I made #97664 I added test but these are actually not run at test time.
I also found a small error in the code that is now fixed.
Issue: ZlibDecompressor not tested #101322 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rhpvorderman |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/101323#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101323 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101323 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/101323 |
| Reload | https://github.com/python/cpython/pull/101323 |
| Reload | https://github.com/python/cpython/pull/101323 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/101323 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/101323 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/101323#issue-comment-box |
| gpshead | https://github.com/gpshead |
| python:main | https://github.com/python/cpython/tree/main |
| rhpvorderman:testfix | https://github.com/rhpvorderman/cpython/tree/testfix |
|
gh-101322: Ensure test_zlib.ZlibDecompressorTest runs, fix errors in ZlibDecompressor
| https://github.com/python/cpython/pull/101323#top |
| gpshead | https://github.com/gpshead |
| python:main | https://github.com/python/cpython/tree/main |
| rhpvorderman:testfix | https://github.com/rhpvorderman/cpython/tree/testfix |
|
Conversation
1
| https://github.com/python/cpython/pull/101323 |
|
Commits
2
| https://github.com/python/cpython/pull/101323/commits |
|
Checks
0
| https://github.com/python/cpython/pull/101323/checks |
|
Files changed
| https://github.com/python/cpython/pull/101323/files |
| Please reload this page | https://github.com/python/cpython/pull/101323 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/rhpvorderman |
| rhpvorderman | https://github.com/rhpvorderman |
| Jan 25, 2023 | https://github.com/python/cpython/pull/101323#issue-1556886179 |
| Please reload this page | https://github.com/python/cpython/pull/101323 |
| #97664 | https://github.com/python/cpython/pull/97664 |
| ZlibDecompressor not tested #101322 | https://github.com/python/cpython/issues/101322 |
| Please reload this page | https://github.com/python/cpython/pull/101323 |
|
| https://github.com/rhpvorderman |
| Ensure test_zlib.ZlibDecompressorTest actually runs, fix errors in Zl… | https://github.com/python/cpython/pull/101323/commits/48e648370f903f9b4d9d36bf519ac94afc32fa07 |
| 48e6483 | https://github.com/python/cpython/pull/101323/commits/48e648370f903f9b4d9d36bf519ac94afc32fa07 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jan 25, 2023 | https://github.com/python/cpython/pull/101323#event-8356217535 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
Jan 25, 2023
| https://github.com/python/cpython/pull/101323#ref-issue-1556884751 |
|
ZlibDecompressor not tested
#101322
| https://github.com/python/cpython/issues/101322 |
|
| https://github.com/rhpvorderman |
| Add blurb for _ZlibDecompressor error fix | https://github.com/python/cpython/pull/101323/commits/e4b342b88e434feb4b802e19ac86601a22cbebc2 |
| e4b342b | https://github.com/python/cpython/pull/101323/commits/e4b342b88e434feb4b802e19ac86601a22cbebc2 |
| https://github.com/kumaraditya303 |
| kumaraditya303 | https://github.com/kumaraditya303 |
|
Feb 3, 2023
| https://github.com/python/cpython/pull/101323#pullrequestreview-1283379215 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101323/files/e4b342b88e434feb4b802e19ac86601a22cbebc2 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Feb 3, 2023 | https://github.com/python/cpython/pull/101323#event-8434621818 |
| https://github.com/kumaraditya303 |
| kumaraditya303 | https://github.com/kumaraditya303 |
| gpshead | https://github.com/gpshead |
| February 3, 2023 17:24 | https://github.com/python/cpython/pull/101323#event-8434622770 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
Feb 4, 2023
| https://github.com/python/cpython/pull/101323#pullrequestreview-1284110950 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101323/files/e4b342b88e434feb4b802e19ac86601a22cbebc2 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| a89e671 | https://github.com/python/cpython/commit/a89e6713c4de99d4be5a1304b134e57a24ab10ac |
| Feb 4, 2023 | https://github.com/python/cpython/pull/101323#event-8439127335 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Feb 4, 2023 | https://github.com/python/cpython/pull/101323#event-8439127393 |
| https://github.com/rhpvorderman |
| rhpvorderman | https://github.com/rhpvorderman |
| Feb 6, 2023 | https://github.com/python/cpython/pull/101323#issuecomment-1418555208 |
| Please reload this page | https://github.com/python/cpython/pull/101323 |
| https://github.com/rhpvorderman |
| rhpvorderman | https://github.com/rhpvorderman |
| February 6, 2023 05:54 | https://github.com/python/cpython/pull/101323#event-8443834719 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101323 |
|
| https://github.com/gpshead |
|
gpshead
| https://github.com/gpshead |
|
| https://github.com/python/cpython/pull/101323/files/e4b342b88e434feb4b802e19ac86601a22cbebc2 |
|
| https://github.com/kumaraditya303 |
|
kumaraditya303
| https://github.com/kumaraditya303 |
|
| https://github.com/python/cpython/pull/101323/files/e4b342b88e434feb4b802e19ac86601a22cbebc2 |
| Please reload this page | https://github.com/python/cpython/pull/101323 |
|
| https://github.com/rhpvorderman |
|
| https://github.com/gpshead |
|
| https://github.com/kumaraditya303 |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |