René's URL Explorer Experiment


Title: gh-101260: Return to a simpler output buffer for zlib, bz2 and lzma for better performance. by rhpvorderman · Pull Request #101279 · python/cpython · GitHub

Open Graph Title: gh-101260: Return to a simpler output buffer for zlib, bz2 and lzma for better performance. by rhpvorderman · Pull Request #101279 · python/cpython

X Title: gh-101260: Return to a simpler output buffer for zlib, bz2 and lzma for better performance. by rhpvorderman · Pull Request #101279 · python/cpython

Description: See the accompanying issue for a detailed explanation. BlocksOutputBuffer was introduced in Python 3.10 and the benchmarks back then showed increased performance on larger output buffers. Smaller output buffers were not benchmarked however. In the accompanying issue I show why the previous buffer scheme works better for smaller output sizes. Since small data packets and streaming is more common than large in-memory compression it is beneficial to switch back to the 3.9 python style of arranging the buffers. This also leads to a lot less code. I changed one thing from the pthon 3.9 code: the lzma and bz2 buffer sizes do not follow a complex grow pattern but simply double the buffer (just like the zlib module). This only really hurts large in-memory compression but that is an anti-pattern anyway. Issue: gh-101260

Open Graph Description: See the accompanying issue for a detailed explanation. BlocksOutputBuffer was introduced in Python 3.10 and the benchmarks back then showed increased performance on larger output buffers. Smaller o...

X Description: See the accompanying issue for a detailed explanation. BlocksOutputBuffer was introduced in Python 3.10 and the benchmarks back then showed increased performance on larger output buffers. Smaller o...

Opengraph URL: https://github.com/python/cpython/pull/101279

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4db8dd3d-354d-a4c0-6a43-e4fa026a6489
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9382:16AB79:3CCE725:4D43809:6B020BCC
html-safe-nonce7ef3f1622ab6ceddc6abda46968afc36f6be72bdb0b41b6d7e3799dc5968cd6b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzgyOjE2QUI3OTozQ0NFNzI1OjRENDM4MDk6NkIwMjBCQ0MiLCJ2aXNpdG9yX2lkIjoiNjk2NTU3ODIwNzI2MTIzMjA3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1c6e497b47c95c533e0dd54c34ba726ccebbb6c1c9550059b572df3d168c93b0
hovercard-subject-tagpull_request:1214784165
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/101279/files
twitter:imagehttps://avatars.githubusercontent.com/u/26142226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/26142226?s=400&v=4
og:image:altSee the accompanying issue for a detailed explanation. BlocksOutputBuffer was introduced in Python 3.10 and the benchmarks back then showed increased performance on larger output buffers. Smaller o...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/101279/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101279%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101279%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/101279/files
Reloadhttps://github.com/python/cpython/pull/101279/files
Reloadhttps://github.com/python/cpython/pull/101279/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
rhpvordermanhttps://github.com/rhpvorderman
python:mainhttps://github.com/python/cpython/tree/main
rhpvorderman:gh-101260https://github.com/rhpvorderman/cpython/tree/gh-101260
Conversation 0 https://github.com/python/cpython/pull/101279
Commits 13 https://github.com/python/cpython/pull/101279/commits
Checks 0 https://github.com/python/cpython/pull/101279/checks
Files changed https://github.com/python/cpython/pull/101279/files
Please reload this pagehttps://github.com/python/cpython/pull/101279/files
gh-101260: Return to a simpler output buffer for zlib, bz2 and lzma for better performance. https://github.com/python/cpython/pull/101279/files#top
Show all changes 13 commits https://github.com/python/cpython/pull/101279/files
78271bc Remove blocksoutputbuffer rhpvorderman Jan 23, 2023 https://github.com/python/cpython/pull/101279/commits/78271bcc7b891a138f04d1e33bcb514028f18f93
f838c1d Fix error regarding maximum length rhpvorderman Jan 23, 2023 https://github.com/python/cpython/pull/101279/commits/f838c1d61a6107f9843411e472cdbd5b8e8dddf2
8793f1a Add missing braces rhpvorderman Jan 24, 2023 https://github.com/python/cpython/pull/101279/commits/8793f1a9c5e0e2ca0eabf9be519331bb8f25fb1d
cf7c244 Set return value properly to NULL in case of error rhpvorderman Jan 24, 2023 https://github.com/python/cpython/pull/101279/commits/cf7c24478652846b4cbeb1a9470b78944dafb100
723ca68 Remove blocksbuffer from bz2module rhpvorderman Jan 24, 2023 https://github.com/python/cpython/pull/101279/commits/723ca68eba016c9620d080a7de365df0a91f4c34
66199e4 Remove blocks output buffer rhpvorderman Jan 24, 2023 https://github.com/python/cpython/pull/101279/commits/66199e4daf498c1465dbddc547208196baae4025
852bae0 More consistent bracing style rhpvorderman Jan 24, 2023 https://github.com/python/cpython/pull/101279/commits/852bae059f8b0fd087154dab618c4ff8fc47f962
a1eff84 Grow bz2 buffer more aggresively rhpvorderman Jan 24, 2023 https://github.com/python/cpython/pull/101279/commits/a1eff84cf03c3fb2eb3e51bb80d8f986389c5178
b98450f Start on lzma module rhpvorderman Jan 24, 2023 https://github.com/python/cpython/pull/101279/commits/b98450f6202e4dead520a20a6d8371c382caab9d
6162715 Finish _lzmamodule rhpvorderman Jan 24, 2023 https://github.com/python/cpython/pull/101279/commits/6162715f960d0073b126bbd7f0dde702b0211141
38bef68 Code style changes rhpvorderman Jan 24, 2023 https://github.com/python/cpython/pull/101279/commits/38bef68cae936d2ef03e58712cbed523c33d9c28
52945c6 Add blurb rhpvorderman Jan 24, 2023 https://github.com/python/cpython/pull/101279/commits/52945c60d23d9037847fac588f255a2819f8ad4a
b12be9b Merge remote-tracking branch 'upstream/main' into gh-101260 rhpvorderman May 11, 2023 https://github.com/python/cpython/pull/101279/commits/b12be9be975424b18c0547a5d35755b28ca9bde8
Clear filters https://github.com/python/cpython/pull/101279/files
Please reload this pagehttps://github.com/python/cpython/pull/101279/files
Please reload this pagehttps://github.com/python/cpython/pull/101279/files
pycore_blocks_output_buffer.h https://github.com/python/cpython/pull/101279/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
2023-01-24-10-20-52.gh-issue-101260.bsNSeT.rst https://github.com/python/cpython/pull/101279/files#diff-95d4ece497e22a625078fc12011712f5dd53c690ca2fce7341dfb9943582c3b1
_bz2module.c https://github.com/python/cpython/pull/101279/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
_lzmamodule.c https://github.com/python/cpython/pull/101279/files#diff-604739065f6d9a2f56bed1e9d1fd56b51e212e9acd630a92ccac9fe8390fa4d9
zlibmodule.c https://github.com/python/cpython/pull/101279/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
Include/internal/pycore_blocks_output_buffer.hhttps://github.com/python/cpython/pull/101279/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
View file https://github.com/python/cpython/blob/fcd5fb49b1d71165f3c503c3d2e74a082ddb2f21/Include/internal/pycore_blocks_output_buffer.h
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/cpython/pull/101279/files
Misc/NEWS.d/next/Library/2023-01-24-10-20-52.gh-issue-101260.bsNSeT.rsthttps://github.com/python/cpython/pull/101279/files#diff-95d4ece497e22a625078fc12011712f5dd53c690ca2fce7341dfb9943582c3b1
View file https://github.com/rhpvorderman/cpython/blob/b12be9be975424b18c0547a5d35755b28ca9bde8/Misc/NEWS.d/next/Library/2023-01-24-10-20-52.gh-issue-101260.bsNSeT.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101279/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/101279/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.