René's URL Explorer Experiment


Title: [3.7] bpo-35017, socketserver: don't accept request after shutdown (GH-9952) by miss-islington · Pull Request #10125 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-35017, socketserver: don't accept request after shutdown (GH-9952) by miss-islington · Pull Request #10125 · python/cpython

X Title: [3.7] bpo-35017, socketserver: don't accept request after shutdown (GH-9952) by miss-islington · Pull Request #10125 · python/cpython

Description: Prior to this revision, after the shutdown of a BaseServer, the server accepted a last single request if it was sent between the server socket polling and the polling timeout. This can be problematic for instance for a server restart for which you do not want to interrupt the service, by not closing the listening socket during the restart. One request failed because of this behavior. Note that only one request failed, following requests were not accepted, as expected. (cherry picked from commit 10cb376) Co-authored-by: Denis Ledoux be.ledoux.denis@gmail.com https://bugs.python.org/issue35017

Open Graph Description: Prior to this revision, after the shutdown of a BaseServer, the server accepted a last single request if it was sent between the server socket polling and the polling timeout. This can be problemat...

X Description: Prior to this revision, after the shutdown of a BaseServer, the server accepted a last single request if it was sent between the server socket polling and the polling timeout. This can be problemat...

Opengraph URL: https://github.com/python/cpython/pull/10125

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:907eaf27-2585-d30a-1587-ee71f695eada
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id82A0:1201C:3922D8D:4BD0BC5:6B021101
html-safe-nonce800980a764cf63a7e8f4e1bbff72ffe2c27f90c94a8a189061aa8c52a139f8af
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkEwOjEyMDFDOjM5MjJEOEQ6NEJEMEJDNTo2QjAyMTEwMSIsInZpc2l0b3JfaWQiOiI2NTk1NDk5OTMyMTM0ODA1NzYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccb46b1d303d07cefd8933ae5ef1f9a6e309500559b0299fddf4a6ce6c29a3063
hovercard-subject-tagpull_request:226104254
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/10125/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altPrior to this revision, after the shutdown of a BaseServer, the server accepted a last single request if it was sent between the server socket polling and the polling timeout. This can be problemat...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/10125/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10125%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10125%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/10125/files
Reloadhttps://github.com/python/cpython/pull/10125/files
Reloadhttps://github.com/python/cpython/pull/10125/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
miss-islingtonhttps://github.com/miss-islington
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-10cb376-3.7https://github.com/miss-islington/cpython/tree/backport-10cb376-3.7
Conversation 3 https://github.com/python/cpython/pull/10125
Commits 1 https://github.com/python/cpython/pull/10125/commits
Checks 0 https://github.com/python/cpython/pull/10125/checks
Files changed https://github.com/python/cpython/pull/10125/files
Please reload this pagehttps://github.com/python/cpython/pull/10125/files
[3.7] bpo-35017, socketserver: don't accept request after shutdown (GH-9952) https://github.com/python/cpython/pull/10125/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/10125/files
49562fb bpo-35017, socketserver: don't accept request after shutdown (GH-9952) beledouxdenis Oct 26, 2018 https://github.com/python/cpython/pull/10125/commits/49562fba0898c244103ae46d8186ff1b56b9690b
Clear filters https://github.com/python/cpython/pull/10125/files
Please reload this pagehttps://github.com/python/cpython/pull/10125/files
Please reload this pagehttps://github.com/python/cpython/pull/10125/files
socketserver.py https://github.com/python/cpython/pull/10125/files#diff-c00d56a0c132ee4bdf79f55a4b43643cf314df1fe122c07c539e120c7ec98b5e
2018-10-26-00-11-21.bpo-35017.6Ez4Cv.rst https://github.com/python/cpython/pull/10125/files#diff-60ea7316d244642d613c88667fc1b5a470ce4fdb71cca46ad1481b1dcde6099f
Lib/socketserver.pyhttps://github.com/python/cpython/pull/10125/files#diff-c00d56a0c132ee4bdf79f55a4b43643cf314df1fe122c07c539e120c7ec98b5e
View file https://github.com/miss-islington/cpython/blob/49562fba0898c244103ae46d8186ff1b56b9690b/Lib/socketserver.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10125/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10125/files#diff-c00d56a0c132ee4bdf79f55a4b43643cf314df1fe122c07c539e120c7ec98b5e
https://github.com/python/cpython/pull/10125/files#diff-c00d56a0c132ee4bdf79f55a4b43643cf314df1fe122c07c539e120c7ec98b5e
Misc/NEWS.d/next/Library/2018-10-26-00-11-21.bpo-35017.6Ez4Cv.rsthttps://github.com/python/cpython/pull/10125/files#diff-60ea7316d244642d613c88667fc1b5a470ce4fdb71cca46ad1481b1dcde6099f
View file https://github.com/miss-islington/cpython/blob/49562fba0898c244103ae46d8186ff1b56b9690b/Misc/NEWS.d/next/Library/2018-10-26-00-11-21.bpo-35017.6Ez4Cv.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10125/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.