René's URL Explorer Experiment


Title: gh-101144: Allow open and read_text encoding to be positional. by gpshead · Pull Request #101145 · python/cpython · GitHub

Open Graph Title: gh-101144: Allow open and read_text encoding to be positional. by gpshead · Pull Request #101145 · python/cpython

X Title: gh-101144: Allow open and read_text encoding to be positional. by gpshead · Pull Request #101145 · python/cpython

Description: This was the behavior in 3.9 and earlier. The fix for #87817 introduced an API regression in 3.10.0b1. Issue: gh-101144

Open Graph Description: This was the behavior in 3.9 and earlier. The fix for #87817 introduced an API regression in 3.10.0b1. Issue: gh-101144

X Description: This was the behavior in 3.9 and earlier. The fix for #87817 introduced an API regression in 3.10.0b1. Issue: gh-101144

Opengraph URL: https://github.com/python/cpython/pull/101145

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bca9f0c0-ad42-c648-8225-97d8bf0be66c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CC6:C6EF1:1FED51:2E572A:6A576F9F
html-safe-nonce8dee004d748da8650b4c5890412d53361ad655c80ffca5367a2181b77924d392
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0M2OkM2RUYxOjFGRUQ1MToyRTU3MkE6NkE1NzZGOUYiLCJ2aXNpdG9yX2lkIjoiODYzMjEwOTQ4OTAwMzY1NTA3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd3dda16d3ff1ed524c043c0216bdc9886d646bcbd8de98f19377483b36d063d8
hovercard-subject-tagpull_request:1209390799
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/101145/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altThis was the behavior in 3.9 and earlier. The fix for #87817 introduced an API regression in 3.10.0b1. Issue: gh-101144
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec0ca805e53f128ba1f966be1d3ccd81d0d1959c7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/101145/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101145%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101145%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/101145/files
Reloadhttps://github.com/python/cpython/pull/101145/files
Reloadhttps://github.com/python/cpython/pull/101145/files
Please reload this pagehttps://github.com/python/cpython/pull/101145/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/101145/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:regression/zipfile.Path.read_text/gh-101144https://github.com/gpshead/cpython/tree/regression/zipfile.Path.read_text/gh-101144
Conversation 28 https://github.com/python/cpython/pull/101145
Commits 13 https://github.com/python/cpython/pull/101145/commits
Checks 0 https://github.com/python/cpython/pull/101145/checks
Files changed https://github.com/python/cpython/pull/101145/files
Please reload this pagehttps://github.com/python/cpython/pull/101145/files
gh-101144: Allow open and read_text encoding to be positional. https://github.com/python/cpython/pull/101145/files#top
Show all changes 13 commits https://github.com/python/cpython/pull/101145/files
a4f19a4 gh-101144: Allow open and read_text encoding to be positional. gpshead Jan 19, 2023 https://github.com/python/cpython/pull/101145/commits/a4f19a42e9a4ae3f44661ca831d2be183adb9cb3
b495172 news wording tweak gpshead Jan 19, 2023 https://github.com/python/cpython/pull/101145/commits/b495172864f24d3558d473432b59de6065518cfd
e304094 Explicitly handle encoding as an arg. gpshead Jan 19, 2023 https://github.com/python/cpython/pull/101145/commits/e3040944a3b5feedb58af768f432c10fe6ab5ed6
9caec6c wording tweak in news. gpshead Jan 19, 2023 https://github.com/python/cpython/pull/101145/commits/9caec6c6a2ab3b392a358cc3a1df34a74eae1116
b4248b1 Explicitly test an unusual encoding to verify it passed through. gpshead Jan 19, 2023 https://github.com/python/cpython/pull/101145/commits/b4248b167e9b9a87fd98d9220beac07562616c39
32b252b simplify read_text, just defer encoding to open gpshead Jan 19, 2023 https://github.com/python/cpython/pull/101145/commits/32b252bf97d2305712c5c77a976210a77a81abbf
d1228b5 address review comments: fixup pos+kw logic, test it. gpshead Jan 19, 2023 https://github.com/python/cpython/pull/101145/commits/d1228b52bd813c0d1b64f6d4e984c6fc8c063710
8ee213e Apply jaraco's suggestion: an encoding extraction method. gpshead Jan 19, 2023 https://github.com/python/cpython/pull/101145/commits/8ee213e1352aef36abfb8f445199ccbbee8ef1bf
25dd5bd Test EncodingWarning blame of open & read_text. gpshead Jan 20, 2023 https://github.com/python/cpython/pull/101145/commits/25dd5bd476f37107f782db1cb32c3bf300cf2ec2
e9b373f Surface the behavior in the zipfile.Path docs. gpshead Jan 20, 2023 https://github.com/python/cpython/pull/101145/commits/e9b373fb9a0b17d86ee348391098ce3f7e36f54e
a12243b simplify the doc wording. gpshead Jan 20, 2023 https://github.com/python/cpython/pull/101145/commits/a12243bf47bd3e25616ce7f4ba7bad08c876d79f
35abedb more doc wording updates based on review. gpshead Jan 20, 2023 https://github.com/python/cpython/pull/101145/commits/35abedba940c45b2075d0bf6134d8867585c7358
88ecd56 use () on single element tuple assignment for clarity. gpshead Jan 20, 2023 https://github.com/python/cpython/pull/101145/commits/88ecd561bc27df97abec30be373a12a089e4fbf4
Clear filters https://github.com/python/cpython/pull/101145/files
Please reload this pagehttps://github.com/python/cpython/pull/101145/files
Please reload this pagehttps://github.com/python/cpython/pull/101145/files
zipfile.rst https://github.com/python/cpython/pull/101145/files#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086
test_path.py https://github.com/python/cpython/pull/101145/files#diff-d93d29530934ea6d5aef4319d8abf55f36c61626f8229b87d71588b69ed18e23
_path.py https://github.com/python/cpython/pull/101145/files#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013
2023-01-18-17-58-50.gh-issue-101144.FHd8Un.rst https://github.com/python/cpython/pull/101145/files#diff-29ac6ac46c2804d26f7b8db6cbbad14da97a764c051a2e0a90c2c50a3d10cb93
Doc/library/zipfile.rsthttps://github.com/python/cpython/pull/101145/files#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086
View file https://github.com/gpshead/cpython/blob/88ecd561bc27df97abec30be373a12a089e4fbf4/Doc/library/zipfile.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101145/{{ revealButtonHref }}
https://github.com/python/cpython/pull/101145/files#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086
https://github.com/python/cpython/pull/101145/files#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086
https://github.com/python/cpython/pull/101145/files#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086
https://github.com/python/cpython/pull/101145/files#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086
Lib/test/test_zipfile/test_path.pyhttps://github.com/python/cpython/pull/101145/files#diff-d93d29530934ea6d5aef4319d8abf55f36c61626f8229b87d71588b69ed18e23
View file https://github.com/gpshead/cpython/blob/88ecd561bc27df97abec30be373a12a089e4fbf4/Lib/test/test_zipfile/test_path.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101145/{{ revealButtonHref }}
https://github.com/python/cpython/pull/101145/files#diff-d93d29530934ea6d5aef4319d8abf55f36c61626f8229b87d71588b69ed18e23
https://github.com/python/cpython/pull/101145/files#diff-d93d29530934ea6d5aef4319d8abf55f36c61626f8229b87d71588b69ed18e23
https://github.com/python/cpython/pull/101145/files#diff-d93d29530934ea6d5aef4319d8abf55f36c61626f8229b87d71588b69ed18e23
https://github.com/python/cpython/pull/101145/files#diff-d93d29530934ea6d5aef4319d8abf55f36c61626f8229b87d71588b69ed18e23
https://github.com/python/cpython/pull/101145/files#diff-d93d29530934ea6d5aef4319d8abf55f36c61626f8229b87d71588b69ed18e23
Lib/zipfile/_path.pyhttps://github.com/python/cpython/pull/101145/files#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013
View file https://github.com/gpshead/cpython/blob/88ecd561bc27df97abec30be373a12a089e4fbf4/Lib/zipfile/_path.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101145/{{ revealButtonHref }}
https://github.com/python/cpython/pull/101145/files#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013
Please reload this pagehttps://github.com/python/cpython/pull/101145/files
https://github.com/python/cpython/pull/101145/files#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013
https://github.com/python/cpython/pull/101145/files#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013
https://github.com/python/cpython/pull/101145/files#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013
Please reload this pagehttps://github.com/python/cpython/pull/101145/files
https://github.com/python/cpython/pull/101145/files#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013
Misc/NEWS.d/next/Library/2023-01-18-17-58-50.gh-issue-101144.FHd8Un.rsthttps://github.com/python/cpython/pull/101145/files#diff-29ac6ac46c2804d26f7b8db6cbbad14da97a764c051a2e0a90c2c50a3d10cb93
View file https://github.com/gpshead/cpython/blob/88ecd561bc27df97abec30be373a12a089e4fbf4/Misc/NEWS.d/next/Library/2023-01-18-17-58-50.gh-issue-101144.FHd8Un.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/101145/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.