René's URL Explorer Experiment


Title: gh-101144: Allow open and read_text encoding to be positional. by gpshead · Pull Request #101145 · python/cpython · GitHub

Open Graph Title: gh-101144: Allow open and read_text encoding to be positional. by gpshead · Pull Request #101145 · python/cpython

X Title: gh-101144: Allow open and read_text encoding to be positional. by gpshead · Pull Request #101145 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This was the behavior in 3.9 and earlier. The fix for #87817 introduced an API regression in 3.10.0b1. Issue: zipfile.Path.read_text & .open methods with a positional encoding arg causes a T...

X Description: This was the behavior in 3.9 and earlier. The fix for #87817 introduced an API regression in 3.10.0b1. Issue: zipfile.Path.read_text & .open methods with a positional encoding arg causes...

Opengraph URL: https://github.com/python/cpython/pull/101145

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:8f99d44c-d07a-d353-b3df-9f22e6b0c8e5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC18:39BA13:210BD6:2F633C:6A576FE5
html-safe-nonce2e83164260767aeffb7f7f417e30272e68492fb557e99f6b5f87b2eb98a4e6f7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzE4OjM5QkExMzoyMTBCRDY6MkY2MzNDOjZBNTc2RkU1IiwidmlzaXRvcl9pZCI6IjkxMTkwMjg3Mjg3NjAzMzIyNjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac197ba0f5b604fffdc96addca9bb43909eb4b55c2631b724edfbcfd3730a8f4fa
hovercard-subject-tagpull_request:1209390799
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/101145/commits
twitter:imagehttps://opengraph.githubassets.com/63ef39a4dfdccb1663307e89443bc84ca9114c5413008da5f78f07118fac9354/python/cpython/pull/101145
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/63ef39a4dfdccb1663307e89443bc84ca9114c5413008da5f78f07118fac9354/python/cpython/pull/101145
og:image:altThis was the behavior in 3.9 and earlier. The fix for #87817 introduced an API regression in 3.10.0b1. Issue: zipfile.Path.read_text & .open methods with a positional encoding arg causes a T...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegpshead
hostnamegithub.com
expected-hostnamegithub.com
None4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec0ca805e53f128ba1f966be1d3ccd81d0d1959c7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/101145/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101145%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101145%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/101145/commits
Reloadhttps://github.com/python/cpython/pull/101145/commits
Reloadhttps://github.com/python/cpython/pull/101145/commits
Please reload this pagehttps://github.com/python/cpython/pull/101145/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/101145/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:regression/zipfile.Path.read_text/gh-101144https://github.com/gpshead/cpython/tree/regression/zipfile.Path.read_text/gh-101144
Conversationhttps://github.com/python/cpython/pull/101145
Commits13 (13)https://github.com/python/cpython/pull/101145/commits
Checkshttps://github.com/python/cpython/pull/101145/checks
Files changedhttps://github.com/python/cpython/pull/101145/files
gh-101144: Allow open and read_text encoding to be positional.https://github.com/python/cpython/pull/101145/commits#top
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
gpshead:regression/zipfile.Path.read_text/gh-101144https://github.com/gpshead/cpython/tree/regression/zipfile.Path.read_text/gh-101144
gh-101144: Allow open and read_text encoding to be positional.https://github.com/python/cpython/pull/101145/commits/a4f19a42e9a4ae3f44661ca831d2be183adb9cb3
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
a4f19a4https://github.com/python/cpython/pull/101145/commits/a4f19a42e9a4ae3f44661ca831d2be183adb9cb3
https://github.com/python/cpython/tree/a4f19a42e9a4ae3f44661ca831d2be183adb9cb3
news wording tweakhttps://github.com/python/cpython/pull/101145/commits/b495172864f24d3558d473432b59de6065518cfd
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
b495172https://github.com/python/cpython/pull/101145/commits/b495172864f24d3558d473432b59de6065518cfd
https://github.com/python/cpython/tree/b495172864f24d3558d473432b59de6065518cfd
Explicitly handle encoding as an arg.https://github.com/python/cpython/pull/101145/commits/e3040944a3b5feedb58af768f432c10fe6ab5ed6
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
e304094https://github.com/python/cpython/pull/101145/commits/e3040944a3b5feedb58af768f432c10fe6ab5ed6
https://github.com/python/cpython/tree/e3040944a3b5feedb58af768f432c10fe6ab5ed6
wording tweak in news.https://github.com/python/cpython/pull/101145/commits/9caec6c6a2ab3b392a358cc3a1df34a74eae1116
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
9caec6chttps://github.com/python/cpython/pull/101145/commits/9caec6c6a2ab3b392a358cc3a1df34a74eae1116
https://github.com/python/cpython/tree/9caec6c6a2ab3b392a358cc3a1df34a74eae1116
Explicitly test an unusual encoding to verify it passed through.https://github.com/python/cpython/pull/101145/commits/b4248b167e9b9a87fd98d9220beac07562616c39
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
b4248b1https://github.com/python/cpython/pull/101145/commits/b4248b167e9b9a87fd98d9220beac07562616c39
https://github.com/python/cpython/tree/b4248b167e9b9a87fd98d9220beac07562616c39
simplify read_text, just defer encoding to openhttps://github.com/python/cpython/pull/101145/commits/32b252bf97d2305712c5c77a976210a77a81abbf
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
32b252bhttps://github.com/python/cpython/pull/101145/commits/32b252bf97d2305712c5c77a976210a77a81abbf
https://github.com/python/cpython/tree/32b252bf97d2305712c5c77a976210a77a81abbf
address review comments: fixup pos+kw logic, test it.https://github.com/python/cpython/pull/101145/commits/d1228b52bd813c0d1b64f6d4e984c6fc8c063710
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
d1228b5https://github.com/python/cpython/pull/101145/commits/d1228b52bd813c0d1b64f6d4e984c6fc8c063710
https://github.com/python/cpython/tree/d1228b52bd813c0d1b64f6d4e984c6fc8c063710
Apply jaraco's suggestion: an encoding extraction method.https://github.com/python/cpython/pull/101145/commits/8ee213e1352aef36abfb8f445199ccbbee8ef1bf
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
8ee213ehttps://github.com/python/cpython/pull/101145/commits/8ee213e1352aef36abfb8f445199ccbbee8ef1bf
https://github.com/python/cpython/tree/8ee213e1352aef36abfb8f445199ccbbee8ef1bf
Test EncodingWarning blame of open & read_text.https://github.com/python/cpython/pull/101145/commits/25dd5bd476f37107f782db1cb32c3bf300cf2ec2
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
25dd5bdhttps://github.com/python/cpython/pull/101145/commits/25dd5bd476f37107f782db1cb32c3bf300cf2ec2
https://github.com/python/cpython/tree/25dd5bd476f37107f782db1cb32c3bf300cf2ec2
Surface the behavior in the zipfile.Path docs.https://github.com/python/cpython/pull/101145/commits/e9b373fb9a0b17d86ee348391098ce3f7e36f54e
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
e9b373fhttps://github.com/python/cpython/pull/101145/commits/e9b373fb9a0b17d86ee348391098ce3f7e36f54e
https://github.com/python/cpython/tree/e9b373fb9a0b17d86ee348391098ce3f7e36f54e
simplify the doc wording.https://github.com/python/cpython/pull/101145/commits/a12243bf47bd3e25616ce7f4ba7bad08c876d79f
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
a12243bhttps://github.com/python/cpython/pull/101145/commits/a12243bf47bd3e25616ce7f4ba7bad08c876d79f
https://github.com/python/cpython/tree/a12243bf47bd3e25616ce7f4ba7bad08c876d79f
more doc wording updates based on review.https://github.com/python/cpython/pull/101145/commits/35abedba940c45b2075d0bf6134d8867585c7358
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
35abedbhttps://github.com/python/cpython/pull/101145/commits/35abedba940c45b2075d0bf6134d8867585c7358
https://github.com/python/cpython/tree/35abedba940c45b2075d0bf6134d8867585c7358
use () on single element tuple assignment for clarity.https://github.com/python/cpython/pull/101145/commits/88ecd561bc27df97abec30be373a12a089e4fbf4
https://github.com/gpshead
gpsheadhttps://github.com/python/cpython/commits?author=gpshead
88ecd56https://github.com/python/cpython/pull/101145/commits/88ecd561bc27df97abec30be373a12a089e4fbf4
https://github.com/python/cpython/tree/88ecd561bc27df97abec30be373a12a089e4fbf4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.