| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:947867e4-8764-a427-4a6b-290898c38170 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9300:35897B:106FA3C:17EA772:6A575C66 |
| html-safe-nonce | 65b0d3197dc8850264da11756e23e022ab11f46ea4bb578c25b9586ed4125025 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzAwOjM1ODk3QjoxMDZGQTNDOjE3RUE3NzI6NkE1NzVDNjYiLCJ2aXNpdG9yX2lkIjoiMTUzNTM2OTEyODQxNjA3NDg1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6d04f3c131a6ce86db59adbfb02401c38666e76612ce8f99bfbe79f96f3c613a |
| hovercard-subject-tag | pull_request:1209390799 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/101145/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/63ef39a4dfdccb1663307e89443bc84ca9114c5413008da5f78f07118fac9354/python/cpython/pull/101145 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/63ef39a4dfdccb1663307e89443bc84ca9114c5413008da5f78f07118fac9354/python/cpython/pull/101145 |
| og:image:alt | This was the behavior in 3.9 and earlier. The fix for #87817 introduced an API regression in 3.10.0b1.
Issue: zipfile.Path.read_text & .open methods with a positional encoding arg causes a T... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gpshead |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87685a1c739dbf97e95760413799bb0221799457 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/101145#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101145 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101145 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/101145 |
| Reload | https://github.com/python/cpython/pull/101145 |
| Reload | https://github.com/python/cpython/pull/101145 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| gpshead | https://github.com/gpshead |
| python:main | https://github.com/python/cpython/tree/main |
| gpshead:regression/zipfile.Path.read_text/gh-101144 | https://github.com/gpshead/cpython/tree/regression/zipfile.Path.read_text/gh-101144 |
| Conversation | https://github.com/python/cpython/pull/101145 |
| Commits13 (13) | https://github.com/python/cpython/pull/101145/commits |
| Checks | https://github.com/python/cpython/pull/101145/checks |
| Files changed | https://github.com/python/cpython/pull/101145/files |
| gh-101144: Allow open and read_text encoding to be positional. | https://github.com/python/cpython/pull/101145#top |
| gpshead | https://github.com/gpshead |
| python:main | https://github.com/python/cpython/tree/main |
| gpshead:regression/zipfile.Path.read_text/gh-101144 | https://github.com/gpshead/cpython/tree/regression/zipfile.Path.read_text/gh-101144 |
|
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| Jan 19, 2023 | https://github.com/python/cpython/pull/101145#issue-1548414740 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| #87817 | https://github.com/python/cpython/issues/87817 |
| zipfile.Path.read_text & .open methods with a positional encoding arg causes a TypeError #101144 | https://github.com/python/cpython/issues/101144 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
|
| https://github.com/gpshead |
| pythongh-101144 | https://github.com/python/cpython/issues/101144 |
| : Allow open and read_text encoding to be positional. | https://github.com/python/cpython/pull/101145/commits/a4f19a42e9a4ae3f44661ca831d2be183adb9cb3 |
| a4f19a4 | https://github.com/python/cpython/pull/101145/commits/a4f19a42e9a4ae3f44661ca831d2be183adb9cb3 |
| python#87817 | https://github.com/python/cpython/issues/87817 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jan 19, 2023 | https://github.com/python/cpython/pull/101145#event-8307648195 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| Jan 19, 2023 | https://github.com/python/cpython/pull/101145#event-8307648384 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
Jan 19, 2023
| https://github.com/python/cpython/pull/101145#ref-issue-1548395059 |
|
zipfile.Path.read_text & .open methods with a positional encoding arg causes a TypeError
#101144
| https://github.com/python/cpython/issues/101144 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
needs backport to 3.10
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22 |
|
needs backport to 3.11
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22 |
|
type-bug
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug |
|
stdlib
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib |
| Jan 19, 2023 | https://github.com/python/cpython/pull/101145#event-8307649774 |
|
| https://github.com/gpshead |
| news wording tweak | https://github.com/python/cpython/pull/101145/commits/b495172864f24d3558d473432b59de6065518cfd |
| b495172 | https://github.com/python/cpython/pull/101145/commits/b495172864f24d3558d473432b59de6065518cfd |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
Jan 19, 2023
| https://github.com/python/cpython/pull/101145#pullrequestreview-1261033281 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101145/files/b495172864f24d3558d473432b59de6065518cfd |
| Lib/zipfile/_path.py | https://github.com/python/cpython/pull/101145/files/b495172864f24d3558d473432b59de6065518cfd#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
|
| https://github.com/gpshead |
| Explicitly handle encoding as an arg. | https://github.com/python/cpython/pull/101145/commits/e3040944a3b5feedb58af768f432c10fe6ab5ed6 |
| e304094 | https://github.com/python/cpython/pull/101145/commits/e3040944a3b5feedb58af768f432c10fe6ab5ed6 |
| python#87817 | https://github.com/python/cpython/issues/87817 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| January 19, 2023 02:30 | https://github.com/python/cpython/pull/101145#event-8307712966 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| jaraco | https://github.com/jaraco |
| code owner | https://github.com/python/cpython/blob/a1e051a23736fdf3da812363bcaf32e53a294f03/.github/CODEOWNERS#L159 |
| January 19, 2023 02:30 | https://github.com/python/cpython/pull/101145#event-8307712984 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| Jan 19, 2023 | https://github.com/python/cpython/pull/101145#issuecomment-1396364181 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
|
| https://github.com/gpshead |
| wording tweak in news. | https://github.com/python/cpython/pull/101145/commits/9caec6c6a2ab3b392a358cc3a1df34a74eae1116 |
| 9caec6c | https://github.com/python/cpython/pull/101145/commits/9caec6c6a2ab3b392a358cc3a1df34a74eae1116 |
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
|
Jan 19, 2023
| https://github.com/python/cpython/pull/101145#pullrequestreview-1261062137 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101145/files/9caec6c6a2ab3b392a358cc3a1df34a74eae1116 |
| jaraco | https://github.com/jaraco |
| https://github.com/python/cpython/pull/101145#pullrequestreview-1261062137 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| Lib/zipfile/_path.py | https://github.com/python/cpython/pull/101145/files/9caec6c6a2ab3b392a358cc3a1df34a74eae1116#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| Lib/zipfile/_path.py | https://github.com/python/cpython/pull/101145/files/9caec6c6a2ab3b392a358cc3a1df34a74eae1116#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| Lib/zipfile/_path.py | https://github.com/python/cpython/pull/101145/files/9caec6c6a2ab3b392a358cc3a1df34a74eae1116#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jan 19, 2023 | https://github.com/python/cpython/pull/101145#event-8307912189 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Jan 19, 2023 | https://github.com/python/cpython/pull/101145#issuecomment-1396394104 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
|
Jan 19, 2023
| https://github.com/python/cpython/pull/101145#pullrequestreview-1261073338 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101145/files/9caec6c6a2ab3b392a358cc3a1df34a74eae1116 |
| Lib/zipfile/_path.py | https://github.com/python/cpython/pull/101145/files/9caec6c6a2ab3b392a358cc3a1df34a74eae1116#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| https://github.com/methane |
| methane | https://github.com/methane |
|
Jan 19, 2023
| https://github.com/python/cpython/pull/101145#pullrequestreview-1261145433 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101145/files/9caec6c6a2ab3b392a358cc3a1df34a74eae1116 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Jan 19, 2023 | https://github.com/python/cpython/pull/101145#event-8308387537 |
| gpshead | https://github.com/gpshead |
| January 18, 2023 21:52 | https://github.com/python/cpython/pull/101145#commits-pushed-b4248b1 |
|
| https://github.com/gpshead |
| Explicitly test an unusual encoding to verify it passed through. | https://github.com/python/cpython/pull/101145/commits/b4248b167e9b9a87fd98d9220beac07562616c39 |
| b4248b1 | https://github.com/python/cpython/pull/101145/commits/b4248b167e9b9a87fd98d9220beac07562616c39 |
|
| https://github.com/gpshead |
| simplify read_text, just defer encoding to open | https://github.com/python/cpython/pull/101145/commits/32b252bf97d2305712c5c77a976210a77a81abbf |
| 32b252b | https://github.com/python/cpython/pull/101145/commits/32b252bf97d2305712c5c77a976210a77a81abbf |
| https://github.com/methane |
| methane | https://github.com/methane |
|
Jan 19, 2023
| https://github.com/python/cpython/pull/101145#pullrequestreview-1261163068 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101145/files/32b252bf97d2305712c5c77a976210a77a81abbf |
| Lib/zipfile/_path.py | https://github.com/python/cpython/pull/101145/files/b4248b167e9b9a87fd98d9220beac07562616c39..32b252bf97d2305712c5c77a976210a77a81abbf#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
|
| https://github.com/gpshead |
| address review comments: fixup pos+kw logic, test it. | https://github.com/python/cpython/pull/101145/commits/d1228b52bd813c0d1b64f6d4e984c6fc8c063710 |
| d1228b5 | https://github.com/python/cpython/pull/101145/commits/d1228b52bd813c0d1b64f6d4e984c6fc8c063710 |
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
|
Jan 19, 2023
| https://github.com/python/cpython/pull/101145#pullrequestreview-1261960333 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101145/files/d1228b52bd813c0d1b64f6d4e984c6fc8c063710 |
| Lib/zipfile/_path.py | https://github.com/python/cpython/pull/101145/files/d1228b52bd813c0d1b64f6d4e984c6fc8c063710#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
|
Jan 19, 2023
| https://github.com/python/cpython/pull/101145#pullrequestreview-1261960565 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101145/files/d1228b52bd813c0d1b64f6d4e984c6fc8c063710 |
|
| https://github.com/gpshead |
| Apply jaraco's suggestion: an encoding extraction method. | https://github.com/python/cpython/pull/101145/commits/8ee213e1352aef36abfb8f445199ccbbee8ef1bf |
| 8ee213e | https://github.com/python/cpython/pull/101145/commits/8ee213e1352aef36abfb8f445199ccbbee8ef1bf |
| gpshead | https://github.com/gpshead |
| January 19, 2023 16:34 | https://github.com/python/cpython/pull/101145#commits-pushed-e9b373f |
|
| https://github.com/gpshead |
| Surface the behavior in the zipfile.Path docs. | https://github.com/python/cpython/pull/101145/commits/e9b373fb9a0b17d86ee348391098ce3f7e36f54e |
| e9b373f | https://github.com/python/cpython/pull/101145/commits/e9b373fb9a0b17d86ee348391098ce3f7e36f54e |
|
| https://github.com/gpshead |
| simplify the doc wording. | https://github.com/python/cpython/pull/101145/commits/a12243bf47bd3e25616ce7f4ba7bad08c876d79f |
| a12243b | https://github.com/python/cpython/pull/101145/commits/a12243bf47bd3e25616ce7f4ba7bad08c876d79f |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| Jan 20, 2023 | https://github.com/python/cpython/pull/101145#issuecomment-1397789058 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting change review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22 |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jan 20, 2023 | https://github.com/python/cpython/pull/101145#event-8317438639 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Jan 20, 2023 | https://github.com/python/cpython/pull/101145#issuecomment-1397789107 |
| @methane | https://github.com/methane |
| @jaraco | https://github.com/jaraco |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| jaraco | https://github.com/jaraco |
| methane | https://github.com/methane |
| January 20, 2023 00:41 | https://github.com/python/cpython/pull/101145#event-8317439084 |
| https://github.com/methane |
| methane | https://github.com/methane |
|
Jan 20, 2023
| https://github.com/python/cpython/pull/101145#pullrequestreview-1262865750 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101145/files/a12243bf47bd3e25616ce7f4ba7bad08c876d79f |
| Doc/library/zipfile.rst | https://github.com/python/cpython/pull/101145/files/a12243bf47bd3e25616ce7f4ba7bad08c876d79f#diff-8a20c37fb313d7b188ae15bb57b351cc2ab73cbdcb6b2aee44cf2f8451768086 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
|
| https://github.com/gpshead |
| more doc wording updates based on review. | https://github.com/python/cpython/pull/101145/commits/35abedba940c45b2075d0bf6134d8867585c7358 |
| 35abedb | https://github.com/python/cpython/pull/101145/commits/35abedba940c45b2075d0bf6134d8867585c7358 |
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
|
Jan 20, 2023
| https://github.com/python/cpython/pull/101145#pullrequestreview-1262883767 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101145/files/35abedba940c45b2075d0bf6134d8867585c7358 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting change review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22 |
| Jan 20, 2023 | https://github.com/python/cpython/pull/101145#event-8317700542 |
|
| https://github.com/gpshead |
| use () on single element tuple assignment for clarity. | https://github.com/python/cpython/pull/101145/commits/88ecd561bc27df97abec30be373a12a089e4fbf4 |
| 88ecd56 | https://github.com/python/cpython/pull/101145/commits/88ecd561bc27df97abec30be373a12a089e4fbf4 |
| https://github.com/methane |
| methane | https://github.com/methane |
|
Jan 20, 2023
| https://github.com/python/cpython/pull/101145#pullrequestreview-1262921713 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101145/files/88ecd561bc27df97abec30be373a12a089e4fbf4 |
| https://github.com/methane |
| methane | https://github.com/methane |
|
Jan 20, 2023
| https://github.com/python/cpython/pull/101145#pullrequestreview-1262922670 |
|
View reviewed changes
| https://github.com/python/cpython/pull/101145/files/88ecd561bc27df97abec30be373a12a089e4fbf4 |
| Lib/zipfile/_path.py | https://github.com/python/cpython/pull/101145/files/88ecd561bc27df97abec30be373a12a089e4fbf4#diff-06a1fd516348dcbb784169d31d76c5171caedf093fb423ce2d08a4442452d013 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| 5927013 | https://github.com/python/cpython/commit/5927013e47a8c63b70e104152351f3447baa819c |
| Jan 20, 2023 | https://github.com/python/cpython/pull/101145#event-8318787440 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jan 20, 2023 | https://github.com/python/cpython/pull/101145#event-8318787740 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Jan 20, 2023 | https://github.com/python/cpython/pull/101145#issuecomment-1397994587 |
| @gpshead | https://github.com/gpshead |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| January 20, 2023 07:04 | https://github.com/python/cpython/pull/101145#event-8318788315 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Jan 20, 2023 | https://github.com/python/cpython/pull/101145#issuecomment-1397994687 |
| @gpshead | https://github.com/gpshead |
| cherry_picker | https://pypi.org/project/cherry-picker/ |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Jan 20, 2023 | https://github.com/python/cpython/pull/101145#issuecomment-1397994711 |
| @gpshead | https://github.com/gpshead |
| cherry_picker | https://pypi.org/project/cherry-picker/ |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| gpshead | https://github.com/gpshead |
|
Jan 20, 2023
| https://github.com/python/cpython/pull/101145#ref-commit-797119d |
|
| https://github.com/gpshead |
| [3.11] | https://github.com/gpshead/cpython/commit/797119d9e3fdfc94f2f774fda54781ddcff7f8ec |
| pythongh-101144 | https://github.com/python/cpython/issues/101144 |
| : Allow open and read_text encoding to be posit… | https://github.com/gpshead/cpython/commit/797119d9e3fdfc94f2f774fda54781ddcff7f8ec |
| 797119d | https://github.com/gpshead/cpython/commit/797119d9e3fdfc94f2f774fda54781ddcff7f8ec |
| pythonGH-101145 | https://github.com/python/cpython/pull/101145 |
| 5927013 | https://github.com/gpshead/cpython/commit/5927013e47a8c63b70e104152351f3447baa819c |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
needs backport to 3.10
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22 |
| Jan 20, 2023 | https://github.com/python/cpython/pull/101145#event-8318844518 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| Jan 20, 2023 | https://github.com/python/cpython/pull/101145#issuecomment-1398004220 |
| #101179 | https://github.com/python/cpython/pull/101179 |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
needs backport to 3.11
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22 |
| Jan 20, 2023 | https://github.com/python/cpython/pull/101145#event-8318851423 |
| jaraco | https://github.com/jaraco |
|
Jan 27, 2023
| https://github.com/python/cpython/pull/101145#ref-commit-12f5a29 |
|
| https://github.com/gpshead |
|
| https://github.com/jaraco |
| python/cpython#101144 | https://github.com/python/cpython/issues/101144 |
| : Allow open and read_text encoding to be positi… | https://github.com/jaraco/zipp/commit/12f5a296cfa61cfb3e6d50149548ee6681ea6b73 |
| 12f5a29 | https://github.com/jaraco/zipp/commit/12f5a296cfa61cfb3e6d50149548ee6681ea6b73 |
| python/cpython#101145 | https://github.com/python/cpython/pull/101145 |
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
|
Jan 27, 2023
| https://github.com/python/cpython/pull/101145#ref-pullrequest-1560354068 |
|
fix encoding positional parameter
jaraco/zipp#89
| https://github.com/jaraco/zipp/pull/89 |
| jaraco | https://github.com/jaraco |
|
Jan 27, 2023
| https://github.com/python/cpython/pull/101145#ref-commit-e9b7bc3 |
|
| https://github.com/gpshead |
|
| https://github.com/jaraco |
| python/cpython#101144 | https://github.com/python/cpython/issues/101144 |
| : Allow open and read_text encoding to be positi… | https://github.com/jaraco/zipp/commit/e9b7bc3b8c83afb57440799bb9bd1fa126abc053 |
| e9b7bc3 | https://github.com/jaraco/zipp/commit/e9b7bc3b8c83afb57440799bb9bd1fa126abc053 |
| python/cpython#101145 | https://github.com/python/cpython/pull/101145 |
| clrpackages | https://github.com/clrpackages |
|
Jan 30, 2023
| https://github.com/python/cpython/pull/101145#ref-commit-8392011 |
|
| https://github.com/fenrus75 |
| pypi-zipp: Autospec creation for update from version 3.11.0 to versio… | https://github.com/clearlinux-pkgs/pypi-zipp/commit/8392011b1c4e8850896cd5c38481b9fba532d3f6 |
| 8392011 | https://github.com/clearlinux-pkgs/pypi-zipp/commit/8392011b1c4e8850896cd5c38481b9fba532d3f6 |
| python/cpython#101144 | https://github.com/python/cpython/issues/101144 |
| python/cpython#101145 | https://github.com/python/cpython/pull/101145 |
| jaraco/skeleton#73 | https://github.com/jaraco/skeleton/issues/73 |
| jaraco/skeleton#74 | https://github.com/jaraco/skeleton/issues/74 |
| python/cpython#101144 | https://github.com/python/cpython/issues/101144 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F101145 |
|
| https://github.com/methane |
|
methane
| https://github.com/methane |
|
| https://github.com/python/cpython/pull/101145/files/88ecd561bc27df97abec30be373a12a089e4fbf4 |
|
| https://github.com/jaraco |
|
jaraco
| https://github.com/jaraco |
|
| https://github.com/python/cpython/pull/101145/files/35abedba940c45b2075d0bf6134d8867585c7358 |
|
| https://github.com/gpshead |
|
gpshead
| https://github.com/gpshead |
|
stdlib
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib |
|
type-bug
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug |
| Please reload this page | https://github.com/python/cpython/pull/101145 |
|
| https://github.com/gpshead |
|
| https://github.com/bedevere-bot |
|
| https://github.com/miss-islington |
|
| https://github.com/methane |
|
| https://github.com/jaraco |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |