Title: gh-94518: Rename `group*` to `extra_group*` to avoid confusion by arhadthedev · Pull Request #101054 · python/cpython · GitHub
Open Graph Title: gh-94518: Rename `group*` to `extra_group*` to avoid confusion by arhadthedev · Pull Request #101054 · python/cpython
X Title: gh-94518: Rename `group*` to `extra_group*` to avoid confusion by arhadthedev · Pull Request #101054 · python/cpython
Description: This PR addresses #94687 (comment): Todo: replace groups_size/groups parameter names with extra_group_size/extra_groups across the whole file to avoid confusion of passers-by. It's necessary to mitigate a misleading name of setgroups that supposes replacement of not supplimentary group affinities, but all ones. The mislead results in seeing the omission of setgroups call for groups_size == 0 as a bug (like we should reset the inherited affinities but do nothing instead). I'll do it in a separate PR because both this PR and gh-94519 are already big enough to clobber them with extra details. Edit: this PR also unifies terminology by further renaming groups_list parameter and num_groups variable into extra_groups_packed and extra_group_size. cc @gpshead Issue: gh-94518
Open Graph Description: This PR addresses #94687 (comment): Todo: replace groups_size/groups parameter names with extra_group_size/extra_groups across the whole file to avoid confusion of passers-by. It's necessary t...
X Description: This PR addresses #94687 (comment): Todo: replace groups_size/groups parameter names with extra_group_size/extra_groups across the whole file to avoid confusion of passers-by. It's necessa...
Opengraph URL: https://github.com/python/cpython/pull/101054
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5275d861-d66e-8ab8-4154-98d4975b9d4f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C874:2ED814:8F9C6:C0E4A:6969B576 |
| html-safe-nonce | 28e262557aa38c2c538199efba74a785f175eac967d2842cd9a702e0ddba6d43 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODc0OjJFRDgxNDo4RjlDNjpDMEU0QTo2OTY5QjU3NiIsInZpc2l0b3JfaWQiOiI3NTI1NDE4MTQ5MDY2OTQ1OTEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9563a890f825af8fe2baf799eea011daad59d98b899d6797ab9612ac0d801602 |
| hovercard-subject-tag | pull_request:1197956888 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/101054/files |
| twitter:image | https://avatars.githubusercontent.com/u/4881073?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4881073?s=400&v=4 |
| og:image:alt | This PR addresses #94687 (comment): Todo: replace groups_size/groups parameter names with extra_group_size/extra_groups across the whole file to avoid confusion of passers-by. It's necessary t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0672399d88424758731ec07fe24509e23bb17fb5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width