René's URL Explorer Experiment


Title: gh-94912: Adjusted check for non-standard coroutine function marker. by carltongibson · Pull Request #100935 · python/cpython · GitHub

Open Graph Title: gh-94912: Adjusted check for non-standard coroutine function marker. by carltongibson · Pull Request #100935 · python/cpython

X Title: gh-94912: Adjusted check for non-standard coroutine function marker. by carltongibson · Pull Request #100935 · python/cpython

Description: The initial implementation did not correctly identify explicitly marked class instances. Follow up to 532aa4e from #99247 (Bug in Python 3.12.0a4) Integrating Python 3.12.0a4 with the Django test suite we see that the _has_coroutine_mark() is not allowing the key case of a class being marked as an asynchronous callable. (This is my fault: in the discussion with @gvanrossum on #99247 over whether we'd cover the marked and async def __call__ cases automatically, I forgot to add the explicit test for the marked instances.) I note the isfunction(f) or _signature_is_functionlike(f) restriction is untested, and not, I think, necessary. (If folks applied markcoroutinefunction, I think we have to assume that they know what they're up to.) Issue: gh-94912

Open Graph Description: The initial implementation did not correctly identify explicitly marked class instances. Follow up to 532aa4e from #99247 (Bug in Python 3.12.0a4) Integrating Python 3.12.0a4 with the Django test s...

X Description: The initial implementation did not correctly identify explicitly marked class instances. Follow up to 532aa4e from #99247 (Bug in Python 3.12.0a4) Integrating Python 3.12.0a4 with the Django test s...

Opengraph URL: https://github.com/python/cpython/pull/100935

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:aff5f56f-7495-0cdc-4a13-4cb7374ce255
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA56:124340:F1A70:1495C1:69693DEB
html-safe-nonceab403a3c29f272b238df9ce2cd0bbc2a088494cd222549a6a853d165e8285020
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTU2OjEyNDM0MDpGMUE3MDoxNDk1QzE6Njk2OTNERUIiLCJ2aXNpdG9yX2lkIjoiOTA3NjI4NDcwMzExMzgyMTY3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac26e0d7108f2c21eb31571a6307b568db7986f07a9f6b86bb40b8114f586bbf20
hovercard-subject-tagpull_request:1193571253
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/100935/files
twitter:imagehttps://avatars.githubusercontent.com/u/64686?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/64686?s=400&v=4
og:image:altThe initial implementation did not correctly identify explicitly marked class instances. Follow up to 532aa4e from #99247 (Bug in Python 3.12.0a4) Integrating Python 3.12.0a4 with the Django test s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released69ac0477df0f87da03b8b06cebd187012d7a930
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/100935/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100935%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100935%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/100935/files
Reloadhttps://github.com/python/cpython/pull/100935/files
Reloadhttps://github.com/python/cpython/pull/100935/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/100935/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/100935/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
carltongibson:fix-issue-94912https://github.com/carltongibson/cpython/tree/fix-issue-94912
Conversation 5 https://github.com/python/cpython/pull/100935
Commits 1 https://github.com/python/cpython/pull/100935/commits
Checks 0 https://github.com/python/cpython/pull/100935/checks
Files changed https://github.com/python/cpython/pull/100935/files
Please reload this pagehttps://github.com/python/cpython/pull/100935/files
gh-94912: Adjusted check for non-standard coroutine function marker. https://github.com/python/cpython/pull/100935/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/100935/files
7b6889a gh-94912: Adjusted check for non-standard coroutine function marker. carltongibson Jan 11, 2023 https://github.com/python/cpython/pull/100935/commits/7b6889abfcecb36a817f1f83ef26ff1872e0cd0c
Clear filters https://github.com/python/cpython/pull/100935/files
Please reload this pagehttps://github.com/python/cpython/pull/100935/files
Please reload this pagehttps://github.com/python/cpython/pull/100935/files
inspect.py https://github.com/python/cpython/pull/100935/files#diff-b89cd06e4637abacb73f2500301ff979a67ad7ecbfa7cf151c7243715898d7ea
test_inspect.py https://github.com/python/cpython/pull/100935/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
Lib/inspect.pyhttps://github.com/python/cpython/pull/100935/files#diff-b89cd06e4637abacb73f2500301ff979a67ad7ecbfa7cf151c7243715898d7ea
View file https://github.com/carltongibson/cpython/blob/7b6889abfcecb36a817f1f83ef26ff1872e0cd0c/Lib/inspect.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100935/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100935/files#diff-b89cd06e4637abacb73f2500301ff979a67ad7ecbfa7cf151c7243715898d7ea
sobolevnhttps://github.com/sobolevn
Jan 11, 2023https://github.com/python/cpython/pull/100935/files#r1066878113
Please reload this pagehttps://github.com/python/cpython/pull/100935/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100935/files
carltongibsonhttps://github.com/carltongibson
Jan 11, 2023https://github.com/python/cpython/pull/100935/files#r1066907762
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@sobolevnhttps://github.com/sobolevn
Please reload this pagehttps://github.com/python/cpython/pull/100935/files
https://github.com/python/cpython/pull/100935/files#diff-b89cd06e4637abacb73f2500301ff979a67ad7ecbfa7cf151c7243715898d7ea
Lib/test/test_inspect.pyhttps://github.com/python/cpython/pull/100935/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
View file https://github.com/carltongibson/cpython/blob/7b6889abfcecb36a817f1f83ef26ff1872e0cd0c/Lib/test/test_inspect.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100935/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100935/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
https://github.com/python/cpython/pull/100935/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
https://github.com/python/cpython/pull/100935/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.