Title: gh-94912: Adjusted check for non-standard coroutine function marker. by carltongibson · Pull Request #100935 · python/cpython · GitHub
Open Graph Title: gh-94912: Adjusted check for non-standard coroutine function marker. by carltongibson · Pull Request #100935 · python/cpython
X Title: gh-94912: Adjusted check for non-standard coroutine function marker. by carltongibson · Pull Request #100935 · python/cpython
Description: The initial implementation did not correctly identify explicitly marked class instances. Follow up to 532aa4e from #99247 (Bug in Python 3.12.0a4) Integrating Python 3.12.0a4 with the Django test suite we see that the _has_coroutine_mark() is not allowing the key case of a class being marked as an asynchronous callable. (This is my fault: in the discussion with @gvanrossum on #99247 over whether we'd cover the marked and async def __call__ cases automatically, I forgot to add the explicit test for the marked instances.) I note the isfunction(f) or _signature_is_functionlike(f) restriction is untested, and not, I think, necessary. (If folks applied markcoroutinefunction, I think we have to assume that they know what they're up to.) Issue: gh-94912
Open Graph Description: The initial implementation did not correctly identify explicitly marked class instances. Follow up to 532aa4e from #99247 (Bug in Python 3.12.0a4) Integrating Python 3.12.0a4 with the Django test s...
X Description: The initial implementation did not correctly identify explicitly marked class instances. Follow up to 532aa4e from #99247 (Bug in Python 3.12.0a4) Integrating Python 3.12.0a4 with the Django test s...
Opengraph URL: https://github.com/python/cpython/pull/100935
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:529f746c-149b-bfa0-05f2-f20e5bb1ba8c |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | B270:31EA40:29CBFB:37E016:6969D31F |
| html-safe-nonce | 266c84a497d01ef64782bdddcbd14ef83bc49c89a17ed1498ee034f062fcb369 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjcwOjMxRUE0MDoyOUNCRkI6MzdFMDE2OjY5NjlEMzFGIiwidmlzaXRvcl9pZCI6IjYxMzk0OTA1Nzk4NDMyNDA3MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 34a523fd015b3ae0b47e2bbf99f24c57651952c3f72354f7f00d4cac32da892c |
| hovercard-subject-tag | pull_request:1193571253 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/100935/checks |
| twitter:image | https://avatars.githubusercontent.com/u/64686?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/64686?s=400&v=4 |
| og:image:alt | The initial implementation did not correctly identify explicitly marked class instances. Follow up to 532aa4e from #99247 (Bug in Python 3.12.0a4) Integrating Python 3.12.0a4 with the Django test s... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width