René's URL Explorer Experiment


Title: gh-100933: Improve `check_element` helper in `test_xml_etree` by sobolevn · Pull Request #100934 · python/cpython · GitHub

Open Graph Title: gh-100933: Improve `check_element` helper in `test_xml_etree` by sobolevn · Pull Request #100934 · python/cpython

X Title: gh-100933: Improve `check_element` helper in `test_xml_etree` by sobolevn · Pull Request #100934 · python/cpython

Description: Items that this test checks are always str and dict: attrib: cpython/Modules/_elementtree.c Lines 536 to 548 in a9f0144 element_get_attrib(ElementObject* self) { /* return borrowed reference to attrib dictionary */ /* note: this function assumes that the extra section exists */ PyObject* res = self->extra->attrib; if (!res) { /* create missing dictionary */ res = self->extra->attrib = PyDict_New(); } return res; text: cpython/Modules/_elementtree.c Lines 561 to 564 in a9f0144 PyObject *tmp = list_join(res); if (!tmp) return NULL; self->text = tmp; tail: cpython/Modules/_elementtree.c Lines 582 to 585 in a9f0144 PyObject *tmp = list_join(res); if (!tmp) return NULL; self->tail = tmp; As you can see, there are no "custom" types that should be checked differently. isinstance is enough. test_xml_etree_c is also affected by this change.

Open Graph Description: Items that this test checks are always str and dict: attrib: cpython/Modules/_elementtree.c Lines 536 to 548 in a9f0144 ...

X Description: Items that this test checks are always str and dict: attrib: cpython/Modules/_elementtree.c Lines 536 to 548 in a9f0144 ...

Opengraph URL: https://github.com/python/cpython/pull/100934

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3a656947-bae2-4928-4203-1534886516a9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85DE:291671:ABD64:EC1BA:6969D22A
html-safe-nonced0aaa0702f6290d10870913d69cfcc1c7ecdee4fe28606622753d1693b42bd52
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NURFOjI5MTY3MTpBQkQ2NDpFQzFCQTo2OTY5RDIyQSIsInZpc2l0b3JfaWQiOiI3NDExNDI1NzA1NTMxNjU4Nzk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac141592a1432178024c1768f2470e34e3509dbbe451ba01604dbaf0ebc6e30b61
hovercard-subject-tagpull_request:1193561962
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/100934/files
twitter:imagehttps://avatars.githubusercontent.com/u/4660275?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4660275?s=400&v=4
og:image:altItems that this test checks are always str and dict: attrib: cpython/Modules/_elementtree.c Lines 536 to 548 in a9f0144 ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/100934/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100934%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100934%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/100934/files
Reloadhttps://github.com/python/cpython/pull/100934/files
Reloadhttps://github.com/python/cpython/pull/100934/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/100934/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/100934/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-100933https://github.com/sobolevn/cpython/tree/issue-100933
Conversation 4 https://github.com/python/cpython/pull/100934
Commits 1 https://github.com/python/cpython/pull/100934/commits
Checks 0 https://github.com/python/cpython/pull/100934/checks
Files changed https://github.com/python/cpython/pull/100934/files
Please reload this pagehttps://github.com/python/cpython/pull/100934/files
gh-100933: Improve check_element helper in test_xml_etree https://github.com/python/cpython/pull/100934/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/100934/files
a11b403 gh-100933: Improve `check_element` helper in `test_xml_etree` sobolevn Jan 11, 2023 https://github.com/python/cpython/pull/100934/commits/a11b4035f81785beb0de91fe38fc28b838e1e41e
Clear filters https://github.com/python/cpython/pull/100934/files
Please reload this pagehttps://github.com/python/cpython/pull/100934/files
Please reload this pagehttps://github.com/python/cpython/pull/100934/files
Lib/test/test_xml_etree.pyhttps://github.com/python/cpython/pull/100934/files#diff-cd2315ff25ab49e653d363de2d213e390ecb1b01bbc86e2be3b700db4b0bf454
View file https://github.com/sobolevn/cpython/blob/a11b4035f81785beb0de91fe38fc28b838e1e41e/Lib/test/test_xml_etree.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100934/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100934/files#diff-cd2315ff25ab49e653d363de2d213e390ecb1b01bbc86e2be3b700db4b0bf454
https://github.com/python/cpython/pull/100934/files#diff-cd2315ff25ab49e653d363de2d213e390ecb1b01bbc86e2be3b700db4b0bf454
https://github.com/python/cpython/pull/100934/files#diff-cd2315ff25ab49e653d363de2d213e390ecb1b01bbc86e2be3b700db4b0bf454
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.