René's URL Explorer Experiment


Title: gh-89727: Fix os.walk to handle late editing of dirs by jonburdo · Pull Request #100703 · python/cpython · GitHub

Open Graph Title: gh-89727: Fix os.walk to handle late editing of dirs by jonburdo · Pull Request #100703 · python/cpython

X Title: gh-89727: Fix os.walk to handle late editing of dirs by jonburdo · Pull Request #100703 · python/cpython

Description: Allow modification of the dirs returned by an os.walk entry to affect which subdirectories are walked, even when the modification occurs after iteration over dirs has begun. This was the behavior for a long time before it was changed in #100703 Issue: gh-89727

Open Graph Description: Allow modification of the dirs returned by an os.walk entry to affect which subdirectories are walked, even when the modification occurs after iteration over dirs has begun. This was the behavior f...

X Description: Allow modification of the dirs returned by an os.walk entry to affect which subdirectories are walked, even when the modification occurs after iteration over dirs has begun. This was the behavior f...

Opengraph URL: https://github.com/python/cpython/pull/100703

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0c2190d4-ed46-d925-3075-988438f111f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC1E:87E17:26523DF:329BD21:696B1B32
html-safe-nonce519e0e659fae67e861d67164f783f00f696a8b224ca7fa1cced6014e9cc12fb2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzFFOjg3RTE3OjI2NTIzREY6MzI5QkQyMTo2OTZCMUIzMiIsInZpc2l0b3JfaWQiOiI0NDAwMjcxOTE1ODE3MzExMDI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace1ed3d825f911f2270e9f9de4f1a93edfe716b162930017e514da910f707d588
hovercard-subject-tagpull_request:1183166493
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/100703/files
twitter:imagehttps://avatars.githubusercontent.com/u/79213343?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/79213343?s=400&v=4
og:image:altAllow modification of the dirs returned by an os.walk entry to affect which subdirectories are walked, even when the modification occurs after iteration over dirs has begun. This was the behavior f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/100703/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100703%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100703%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/100703/files
Reloadhttps://github.com/python/cpython/pull/100703/files
Reloadhttps://github.com/python/cpython/pull/100703/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/100703/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/100703/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
jonburdohttps://github.com/jonburdo
python:mainhttps://github.com/python/cpython/tree/main
jonburdo:os-walk-dirs-editinghttps://github.com/jonburdo/cpython/tree/os-walk-dirs-editing
Conversation 15 https://github.com/python/cpython/pull/100703
Commits 14 https://github.com/python/cpython/pull/100703/commits
Checks 0 https://github.com/python/cpython/pull/100703/checks
Files changed https://github.com/python/cpython/pull/100703/files
Please reload this pagehttps://github.com/python/cpython/pull/100703/files
gh-89727: Fix os.walk to handle late editing of dirs https://github.com/python/cpython/pull/100703/files#top
Show all changes 14 commits https://github.com/python/cpython/pull/100703/files
2767f70 adopt old os.walk behavior to handle changes to dirs list after itera… jonburdo Jan 3, 2023 https://github.com/python/cpython/pull/100703/commits/2767f7065ff456e72521a268b3969e53b9b9e301
04a16a2 move stack logic to bottom of loop in os.walk jonburdo Jan 3, 2023 https://github.com/python/cpython/pull/100703/commits/04a16a22f5c7cd969c46e9a0c510e66f86bfc432
6b0465f move scandir logic to bottom of loop jonburdo Jan 3, 2023 https://github.com/python/cpython/pull/100703/commits/6b0465ff4ffb03cd85b19f7a434c100e5bca4ee5
2ff800f use for-loop to process dirs in bottom-up clause jonburdo Jan 3, 2023 https://github.com/python/cpython/pull/100703/commits/2ff800fef05a24af88b0dbb6a9c823c37a6f93ba
072bdfb Merge branch 'main' into os-walk-dirs-editing jonburdo Jan 3, 2023 https://github.com/python/cpython/pull/100703/commits/072bdfb4c137fa747cba0ca1e5d03a1d8777b4b8
41d7463 return if scandir_it fails on first value jonburdo Jan 3, 2023 https://github.com/python/cpython/pull/100703/commits/41d7463c5e8a873e8625422af8cee963d5414a57
d81ff45 add test for late modification of dirs in os.walk jonburdo Jan 3, 2023 https://github.com/python/cpython/pull/100703/commits/d81ff45aaafb43900dd09b9d6f180b77ea0c0780
431d47a Merge branch 'main' into os-walk-dirs-editing jonburdo Jan 3, 2023 https://github.com/python/cpython/pull/100703/commits/431d47aa5a4cca58af0db9a3646874f9b37667be
2829a7d use while-else instead of while True, make variable names clearer jonburdo Jan 3, 2023 https://github.com/python/cpython/pull/100703/commits/2829a7dc11c2ba2e370e9a1d03464966d5019a9c
b59358b change os.walk docstring to say "traverse" instead of "recurse" jonburdo Jan 3, 2023 https://github.com/python/cpython/pull/100703/commits/b59358b46af47e2895abfbaf9169482b71173bd1
839f31e fix scandir comment jonburdo Jan 4, 2023 https://github.com/python/cpython/pull/100703/commits/839f31eb34e5ecc4ddf5cb0060487483fb788513
1011e19 Merge branch 'main' into os-walk-dirs-editing jonburdo Jan 4, 2023 https://github.com/python/cpython/pull/100703/commits/1011e199529ccdbd778226574c379403708b2e5d
80b7e82 split topdown and bottomup logic into separate functions for os.walk jonburdo Jan 4, 2023 https://github.com/python/cpython/pull/100703/commits/80b7e825bced8e9bd256d6f154822695fc363f75
70cb0c2 Merge branch 'main' into os-walk-dirs-editing erlend-aasland Jan 5, 2024 https://github.com/python/cpython/pull/100703/commits/70cb0c289f1c1f9d38de273bbceee353c26253f2
Clear filters https://github.com/python/cpython/pull/100703/files
Please reload this pagehttps://github.com/python/cpython/pull/100703/files
Please reload this pagehttps://github.com/python/cpython/pull/100703/files
os.py https://github.com/python/cpython/pull/100703/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
test_os.py https://github.com/python/cpython/pull/100703/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
Lib/os.pyhttps://github.com/python/cpython/pull/100703/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
View file https://github.com/jonburdo/cpython/blob/70cb0c289f1c1f9d38de273bbceee353c26253f2/Lib/os.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100703/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100703/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
https://github.com/python/cpython/pull/100703/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
https://github.com/python/cpython/pull/100703/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
Please reload this pagehttps://github.com/python/cpython/pull/100703/files
Please reload this pagehttps://github.com/python/cpython/pull/100703/files
https://github.com/python/cpython/pull/100703/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
https://github.com/python/cpython/pull/100703/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
https://github.com/python/cpython/pull/100703/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
Lib/test/test_os.pyhttps://github.com/python/cpython/pull/100703/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
View file https://github.com/jonburdo/cpython/blob/70cb0c289f1c1f9d38de273bbceee353c26253f2/Lib/test/test_os.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100703/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100703/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/100703/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/100703/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/100703/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com/python/cpython/pull/100703/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.