René's URL Explorer Experiment


Title: gh-89727: Fix os.walk to handle late editing of dirs by jonburdo · Pull Request #100703 · python/cpython · GitHub

Open Graph Title: gh-89727: Fix os.walk to handle late editing of dirs by jonburdo · Pull Request #100703 · python/cpython

X Title: gh-89727: Fix os.walk to handle late editing of dirs by jonburdo · Pull Request #100703 · python/cpython

Description: Allow modification of the dirs returned by an os.walk entry to affect which subdirectories are walked, even when the modification occurs after iteration over dirs has begun. This was the behavior f...

Open Graph Description: Allow modification of the dirs returned by an os.walk entry to affect which subdirectories are walked, even when the modification occurs after iteration over dirs has begun. This was the behavior f...

X Description: Allow modification of the dirs returned by an os.walk entry to affect which subdirectories are walked, even when the modification occurs after iteration over dirs has begun. This was the behavior f...

Opengraph URL: https://github.com/python/cpython/pull/100703

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ab8405b1-fdb4-ecde-e594-077d08abe5cf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD676:231D79:1B013C2:23C4E93:696AF559
html-safe-nonce67400ceecaa9f18dff69c3bac94622a22d6a31a6bb10e8423bba1a172141a8a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjc2OjIzMUQ3OToxQjAxM0MyOjIzQzRFOTM6Njk2QUY1NTkiLCJ2aXNpdG9yX2lkIjoiODQwMDI2MTE2NTkwMzM1MzIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace82d6a8162dfbec120d149fce2074dadcae205d2116d9e4ab63eff678fce8edc
hovercard-subject-tagpull_request:1183166493
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/100703/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/68e59653096b9865a28d3c0ecfee4a0714159c0bfdd9d6092be1481f588bcd5e/python/cpython/pull/100703
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/68e59653096b9865a28d3c0ecfee4a0714159c0bfdd9d6092be1481f588bcd5e/python/cpython/pull/100703
og:image:altAllow modification of the dirs returned by an os.walk entry to affect which subdirectories are walked, even when the modification occurs after iteration over dirs has begun. This was the behavior f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejonburdo
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/100703#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100703
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100703
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/100703
Reloadhttps://github.com/python/cpython/pull/100703
Reloadhttps://github.com/python/cpython/pull/100703
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/100703
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/100703
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/100703#issue-comment-box
jonburdohttps://github.com/jonburdo
python:mainhttps://github.com/python/cpython/tree/main
jonburdo:os-walk-dirs-editinghttps://github.com/jonburdo/cpython/tree/os-walk-dirs-editing
gh-89727: Fix os.walk to handle late editing of dirs https://github.com/python/cpython/pull/100703#top
jonburdohttps://github.com/jonburdo
python:mainhttps://github.com/python/cpython/tree/main
jonburdo:os-walk-dirs-editinghttps://github.com/jonburdo/cpython/tree/os-walk-dirs-editing
Conversation 15 https://github.com/python/cpython/pull/100703
Commits 14 https://github.com/python/cpython/pull/100703/commits
Checks 0 https://github.com/python/cpython/pull/100703/checks
Files changed https://github.com/python/cpython/pull/100703/files
Please reload this pagehttps://github.com/python/cpython/pull/100703
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/jonburdo
jonburdohttps://github.com/jonburdo
Jan 3, 2023https://github.com/python/cpython/pull/100703#issue-1517037248
Please reload this pagehttps://github.com/python/cpython/pull/100703
#100703https://github.com/python/cpython/pull/100703
Change shutil.rmtree and os.walk to support very deep hierarchies #89727https://github.com/python/cpython/issues/89727
Please reload this pagehttps://github.com/python/cpython/pull/100703
https://github.com/jonburdo
adopt old os.walk behavior to handle changes to dirs list after itera…https://github.com/python/cpython/pull/100703/commits/2767f7065ff456e72521a268b3969e53b9b9e301
2767f70https://github.com/python/cpython/pull/100703/commits/2767f7065ff456e72521a268b3969e53b9b9e301
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 3, 2023https://github.com/python/cpython/pull/100703#event-8140686341
https://github.com/jonburdo
jonburdohttps://github.com/jonburdo
Jan 3, 2023https://github.com/python/cpython/pull/100703#event-8140895162
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 3, 2023 https://github.com/python/cpython/pull/100703#ref-issue-1199067663
Change shutil.rmtree and os.walk to support very deep hierarchies #89727 https://github.com/python/cpython/issues/89727
https://github.com/jonburdo
jonburdohttps://github.com/jonburdo
Jan 3, 2023https://github.com/python/cpython/pull/100703#issuecomment-1369498521
Please reload this pagehttps://github.com/python/cpython/pull/100703
Please reload this pagehttps://github.com/python/cpython/pull/100703
jonburdohttps://github.com/jonburdo
January 3, 2023 13:23https://github.com/python/cpython/pull/100703#commits-pushed-04a16a2
https://github.com/jonburdo
move stack logic to bottom of loop in os.walkhttps://github.com/python/cpython/pull/100703/commits/04a16a22f5c7cd969c46e9a0c510e66f86bfc432
04a16a2https://github.com/python/cpython/pull/100703/commits/04a16a22f5c7cd969c46e9a0c510e66f86bfc432
https://github.com/jonburdo
move scandir logic to bottom of loophttps://github.com/python/cpython/pull/100703/commits/6b0465ff4ffb03cd85b19f7a434c100e5bca4ee5
6b0465fhttps://github.com/python/cpython/pull/100703/commits/6b0465ff4ffb03cd85b19f7a434c100e5bca4ee5
https://github.com/jonburdo
use for-loop to process dirs in bottom-up clausehttps://github.com/python/cpython/pull/100703/commits/2ff800fef05a24af88b0dbb6a9c823c37a6f93ba
2ff800fhttps://github.com/python/cpython/pull/100703/commits/2ff800fef05a24af88b0dbb6a9c823c37a6f93ba
https://github.com/jonburdo
Merge branch 'main' into os-walk-dirs-editinghttps://github.com/python/cpython/pull/100703/commits/072bdfb4c137fa747cba0ca1e5d03a1d8777b4b8
072bdfbhttps://github.com/python/cpython/pull/100703/commits/072bdfb4c137fa747cba0ca1e5d03a1d8777b4b8
https://github.com/jonburdo
return if scandir_it fails on first valuehttps://github.com/python/cpython/pull/100703/commits/41d7463c5e8a873e8625422af8cee963d5414a57
41d7463https://github.com/python/cpython/pull/100703/commits/41d7463c5e8a873e8625422af8cee963d5414a57
https://github.com/jonburdo
add test for late modification of dirs in os.walkhttps://github.com/python/cpython/pull/100703/commits/d81ff45aaafb43900dd09b9d6f180b77ea0c0780
d81ff45https://github.com/python/cpython/pull/100703/commits/d81ff45aaafb43900dd09b9d6f180b77ea0c0780
https://github.com/jonburdo
Merge branch 'main' into os-walk-dirs-editinghttps://github.com/python/cpython/pull/100703/commits/431d47aa5a4cca58af0db9a3646874f9b37667be
431d47ahttps://github.com/python/cpython/pull/100703/commits/431d47aa5a4cca58af0db9a3646874f9b37667be
https://github.com/jonburdo
use while-else instead of while True, make variable names clearerhttps://github.com/python/cpython/pull/100703/commits/2829a7dc11c2ba2e370e9a1d03464966d5019a9c
2829a7dhttps://github.com/python/cpython/pull/100703/commits/2829a7dc11c2ba2e370e9a1d03464966d5019a9c
https://github.com/jonburdo
change os.walk docstring to say "traverse" instead of "recurse"https://github.com/python/cpython/pull/100703/commits/b59358b46af47e2895abfbaf9169482b71173bd1
b59358bhttps://github.com/python/cpython/pull/100703/commits/b59358b46af47e2895abfbaf9169482b71173bd1
https://github.com/jonburdo
jonburdohttps://github.com/jonburdo
Jan 3, 2023https://github.com/python/cpython/pull/100703#issuecomment-1370328027
Please reload this pagehttps://github.com/python/cpython/pull/100703
https://github.com/carljm
carljmhttps://github.com/carljm
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jan 4, 2023https://github.com/python/cpython/pull/100703#event-8147011661
https://github.com/carljm
carljmhttps://github.com/carljm
Jan 4, 2023 https://github.com/python/cpython/pull/100703#pullrequestreview-1235250263
View reviewed changes https://github.com/python/cpython/pull/100703/files/b59358b46af47e2895abfbaf9169482b71173bd1
Lib/os.pyhttps://github.com/python/cpython/pull/100703/files/b59358b46af47e2895abfbaf9169482b71173bd1#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
carljmhttps://github.com/carljm
Jan 4, 2023https://github.com/python/cpython/pull/100703#discussion_r1061059451
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100703
jonburdohttps://github.com/jonburdo
Jan 4, 2023https://github.com/python/cpython/pull/100703#discussion_r1061853329
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100703
jonburdohttps://github.com/jonburdo
Jan 4, 2023https://github.com/python/cpython/pull/100703#discussion_r1061929273
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100703
Lib/os.pyhttps://github.com/python/cpython/pull/100703/files/b59358b46af47e2895abfbaf9169482b71173bd1#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
Please reload this pagehttps://github.com/python/cpython/pull/100703
Lib/os.pyhttps://github.com/python/cpython/pull/100703/files/b59358b46af47e2895abfbaf9169482b71173bd1#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
carljmhttps://github.com/carljm
Jan 4, 2023https://github.com/python/cpython/pull/100703#discussion_r1061070991
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100703
jonburdohttps://github.com/jonburdo
Jan 4, 2023https://github.com/python/cpython/pull/100703#discussion_r1061942165
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100703
carljmhttps://github.com/carljm
Jan 4, 2023https://github.com/python/cpython/pull/100703#discussion_r1061963576
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100703
jonburdohttps://github.com/jonburdo
January 4, 2023 15:19https://github.com/python/cpython/pull/100703#commits-pushed-839f31e
https://github.com/jonburdo
fix scandir commenthttps://github.com/python/cpython/pull/100703/commits/839f31eb34e5ecc4ddf5cb0060487483fb788513
839f31ehttps://github.com/python/cpython/pull/100703/commits/839f31eb34e5ecc4ddf5cb0060487483fb788513
https://github.com/jonburdo
Merge branch 'main' into os-walk-dirs-editinghttps://github.com/python/cpython/pull/100703/commits/1011e199529ccdbd778226574c379403708b2e5d
1011e19https://github.com/python/cpython/pull/100703/commits/1011e199529ccdbd778226574c379403708b2e5d
https://github.com/jonburdo
split topdown and bottomup logic into separate functions for os.walkhttps://github.com/python/cpython/pull/100703/commits/80b7e825bced8e9bd256d6f154822695fc363f75
80b7e82https://github.com/python/cpython/pull/100703/commits/80b7e825bced8e9bd256d6f154822695fc363f75
https://github.com/jonburdo
jonburdohttps://github.com/jonburdo
Jan 4, 2023 https://github.com/python/cpython/pull/100703#pullrequestreview-1236579548
View reviewed changes https://github.com/python/cpython/pull/100703/files/80b7e825bced8e9bd256d6f154822695fc363f75
Lib/os.pyhttps://github.com/python/cpython/pull/100703/files/80b7e825bced8e9bd256d6f154822695fc363f75#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
Please reload this pagehttps://github.com/python/cpython/pull/100703
https://github.com/jonburdo
jonburdohttps://github.com/jonburdo
Jan 6, 2023https://github.com/python/cpython/pull/100703#issuecomment-1374032724
first commithttps://github.com/python/cpython/pull/100703/commits/2767f7065ff456e72521a268b3969e53b9b9e301
this suggestionhttps://github.com/python/cpython/issues/89727#issuecomment-1369335184
Please reload this pagehttps://github.com/python/cpython/pull/100703
https://github.com/zmievsa
zmievsahttps://github.com/zmievsa
Jan 6, 2023https://github.com/python/cpython/pull/100703#issuecomment-1374101933
Please reload this pagehttps://github.com/python/cpython/pull/100703
Please reload this pagehttps://github.com/python/cpython/pull/100703
https://github.com/jonburdo
jonburdohttps://github.com/jonburdo
Jan 6, 2023https://github.com/python/cpython/pull/100703#issuecomment-1374146074
Please reload this pagehttps://github.com/python/cpython/pull/100703
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Jan 11, 2023https://github.com/python/cpython/pull/100703#issuecomment-1379231164
Please reload this pagehttps://github.com/python/cpython/pull/100703
https://github.com/jonburdo
jonburdohttps://github.com/jonburdo
Mar 24, 2023 https://github.com/python/cpython/pull/100703#ref-issue-1636438630
os.walk() no longer supports late edits to dirnames #102932 https://github.com/python/cpython/issues/102932
https://github.com/erlend-aasland
Merge branch 'main' into os-walk-dirs-editinghttps://github.com/python/cpython/pull/100703/commits/70cb0c289f1c1f9d38de273bbceee353c26253f2
70cb0c2https://github.com/python/cpython/pull/100703/commits/70cb0c289f1c1f9d38de273bbceee353c26253f2
https://github.com/jonburdo
jonburdohttps://github.com/jonburdo
Dec 2, 2024https://github.com/python/cpython/pull/100703#event-15497864284
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100703
https://github.com/carljm
carljm https://github.com/carljm
https://github.com/python/cpython/pull/100703/files/b59358b46af47e2895abfbaf9169482b71173bd1
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/100703
https://github.com/jonburdo
https://github.com/zmievsa
https://github.com/barneygale
https://github.com/carljm
https://github.com/bedevere-bot
https://github.com/erlend-aasland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.