René's URL Explorer Experiment


Title: [3.7] bpo-34454: Clean up datetime.fromisoformat surrogate handling (GH-8959) by miss-islington · Pull Request #10041 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-34454: Clean up datetime.fromisoformat surrogate handling (GH-8959) by miss-islington · Pull Request #10041 · python/cpython

X Title: [3.7] bpo-34454: Clean up datetime.fromisoformat surrogate handling (GH-8959) by miss-islington · Pull Request #10041 · python/cpython

Description: Use _PyUnicode_Copy in sanitize_isoformat_str Use repr in fromisoformat error message This reverses commit 67b74a98b2 per Serhiy Storchaka's suggestion: I suggested to use %R in the error message because including the raw string can be confusing in the case of empty string, or string containing trailing whitespaces, invisible or unprintable characters. We agree that it is better to change both the C and pure Python versions to use repr. Retain non-sanitized dtstr for error printing This does not create an extra string, it just holds on to a reference to the original input string for purposes of creating the error message. PEP 7 fixes to from_isoformat Separate handling of Unicode and other errors In the initial implementation, errors other than encoding errors would both raise an error indicating an invalid format, which would not be true for errors like MemoryError. Drop needs_decref from _sanitize_isoformat_str Instead _sanitize_isoformat_str returns a new reference, even to the original string. (cherry picked from commit 3df8540) Co-authored-by: Paul Ganssle pganssle@users.noreply.github.com https://bugs.python.org/issue34454

Open Graph Description: Use _PyUnicode_Copy in sanitize_isoformat_str Use repr in fromisoformat error message This reverses commit 67b74a98b2 per Serhiy Storchaka's suggestion: I suggested to use %R in the error ...

X Description: Use _PyUnicode_Copy in sanitize_isoformat_str Use repr in fromisoformat error message This reverses commit 67b74a98b2 per Serhiy Storchaka's suggestion: I suggested to use %R in the er...

Opengraph URL: https://github.com/python/cpython/pull/10041

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5c2b6f82-e460-bd76-514e-8c444ef589c4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA6DE:AA9CB:1F19D9:29225C:6B022DA9
html-safe-noncea5ac7d76f7853cc216d8d9155f19e5baf58a7874a7564ba3b0a82c6a65b3b27c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkRFOkFBOUNCOjFGMTlEOToyOTIyNUM6NkIwMjJEQTkiLCJ2aXNpdG9yX2lkIjoiODQ0MjE3MzkxOTA4Mjk4MjgyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca5f3368dc4793e3651a052a155e859ea2ac9822277f3f52687196a9bc9cefcd6
hovercard-subject-tagpull_request:224789406
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/10041/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altUse _PyUnicode_Copy in sanitize_isoformat_str Use repr in fromisoformat error message This reverses commit 67b74a98b2 per Serhiy Storchaka's suggestion: I suggested to use %R in the error ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/10041/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10041%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10041%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/10041/files
Reloadhttps://github.com/python/cpython/pull/10041/files
Reloadhttps://github.com/python/cpython/pull/10041/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
miss-islingtonhttps://github.com/miss-islington
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-3df8540-3.7https://github.com/miss-islington/cpython/tree/backport-3df8540-3.7
Conversation 2 https://github.com/python/cpython/pull/10041
Commits 1 https://github.com/python/cpython/pull/10041/commits
Checks 0 https://github.com/python/cpython/pull/10041/checks
Files changed https://github.com/python/cpython/pull/10041/files
Please reload this pagehttps://github.com/python/cpython/pull/10041/files
[3.7] bpo-34454: Clean up datetime.fromisoformat surrogate handling (GH-8959) https://github.com/python/cpython/pull/10041/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/10041/files
eb69908 bpo-34454: Clean up datetime.fromisoformat surrogate handling (GH-8959) pganssle Oct 22, 2018 https://github.com/python/cpython/pull/10041/commits/eb69908b5cfdf568e01356f96d01cd146979cfe7
Clear filters https://github.com/python/cpython/pull/10041/files
Please reload this pagehttps://github.com/python/cpython/pull/10041/files
Please reload this pagehttps://github.com/python/cpython/pull/10041/files
datetime.py https://github.com/python/cpython/pull/10041/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
datetimetester.py https://github.com/python/cpython/pull/10041/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
_datetimemodule.c https://github.com/python/cpython/pull/10041/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
Lib/datetime.pyhttps://github.com/python/cpython/pull/10041/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
View file https://github.com/miss-islington/cpython/blob/eb69908b5cfdf568e01356f96d01cd146979cfe7/Lib/datetime.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10041/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10041/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
https://github.com/python/cpython/pull/10041/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
https://github.com/python/cpython/pull/10041/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
https://github.com/python/cpython/pull/10041/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
https://github.com/python/cpython/pull/10041/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
https://github.com/python/cpython/pull/10041/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
Lib/test/datetimetester.pyhttps://github.com/python/cpython/pull/10041/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
View file https://github.com/miss-islington/cpython/blob/eb69908b5cfdf568e01356f96d01cd146979cfe7/Lib/test/datetimetester.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10041/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10041/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/10041/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/10041/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/10041/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
Please reload this pagehttps://github.com/python/cpython/pull/10041/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.