René's URL Explorer Experiment


Title: gh-99191: Use correct check for MSVC C++ version support in _wmimodule.cpp by CAM-Gerlach · Pull Request #100381 · python/cpython · GitHub

Open Graph Title: gh-99191: Use correct check for MSVC C++ version support in _wmimodule.cpp by CAM-Gerlach · Pull Request #100381 · python/cpython

X Title: gh-99191: Use correct check for MSVC C++ version support in _wmimodule.cpp by CAM-Gerlach · Pull Request #100381 · python/cpython

Description: As discussed in #99191 , in PC/_wmimodule.cpp it currently uses the check #if _MSC_VER >= 1929 to determine if the compiler supports C++20 designated initializers. However, the /std:c++20 flag was only introduced in VS 2019 16.11, but 1929 is also the version reported in VS 2019 16.10, which doesn't support that flag. Therefore, the current check will break (resulting in the unsupported C++20 branch being taken and presumably resulting in a compiler error) on VS 16.10 and also if the build is invoked such that \std:c++20 is overridden or not passed. However, we can instead use _MSVC_LANG >= 202002L to check whether C++20 or greater is actually being targeted. Fixes #99191 Issue: gh-99191

Open Graph Description: As discussed in #99191 , in PC/_wmimodule.cpp it currently uses the check #if _MSC_VER >= 1929 to determine if the compiler supports C++20 designated initializers. However, the /std:c++20 flag w...

X Description: As discussed in #99191 , in PC/_wmimodule.cpp it currently uses the check #if _MSC_VER >= 1929 to determine if the compiler supports C++20 designated initializers. However, the /std:c++20 fl...

Opengraph URL: https://github.com/python/cpython/pull/100381

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:acb01644-bc20-e719-9fa3-cf2bce0d6ca0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC50:333370:1CE7799:285D454:696A5B89
html-safe-noncefebdaf921639a7156a0b9ce17e7e590afc5d1a19543ca3786608eae2df6f0b35
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzUwOjMzMzM3MDoxQ0U3Nzk5OjI4NUQ0NTQ6Njk2QTVCODkiLCJ2aXNpdG9yX2lkIjoiMTUyMzc2Njc5Njk3Mzc0MDg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacffe946e6680e1ac7d7dba3fff77866ac9a2c6953cac50d77fba3e724da5772a7
hovercard-subject-tagpull_request:1172948705
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/100381/files
twitter:imagehttps://avatars.githubusercontent.com/u/17051931?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17051931?s=400&v=4
og:image:altAs discussed in #99191 , in PC/_wmimodule.cpp it currently uses the check #if _MSC_VER >= 1929 to determine if the compiler supports C++20 designated initializers. However, the /std:c++20 flag w...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/100381/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100381%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100381%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/100381/files
Reloadhttps://github.com/python/cpython/pull/100381/files
Reloadhttps://github.com/python/cpython/pull/100381/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/100381/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/100381/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zoobahttps://github.com/zooba
python:mainhttps://github.com/python/cpython/tree/main
CAM-Gerlach:fix-wmimodule-msvc-checkhttps://github.com/CAM-Gerlach/cpython/tree/fix-wmimodule-msvc-check
Conversation 1 https://github.com/python/cpython/pull/100381
Commits 2 https://github.com/python/cpython/pull/100381/commits
Checks 0 https://github.com/python/cpython/pull/100381/checks
Files changed https://github.com/python/cpython/pull/100381/files
Please reload this pagehttps://github.com/python/cpython/pull/100381/files
gh-99191: Use correct check for MSVC C++ version support in _wmimodule.cpp https://github.com/python/cpython/pull/100381/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/100381/files
472ef32 Use correct check for MSVC C++ version support in _wmimodule.cpp CAM-Gerlach Dec 20, 2022 https://github.com/python/cpython/pull/100381/commits/472ef3217946599ea650b33fb92dfd6fe03281b8
6b33a99 Add NEWS entry for MSVC C++20 check change CAM-Gerlach Dec 20, 2022 https://github.com/python/cpython/pull/100381/commits/6b33a99e2114fb7e71fd3e73b9b640658a529961
Clear filters https://github.com/python/cpython/pull/100381/files
Please reload this pagehttps://github.com/python/cpython/pull/100381/files
Please reload this pagehttps://github.com/python/cpython/pull/100381/files
2022-12-20-18-36-17.gh-issue-99191.0cfRja.rst https://github.com/python/cpython/pull/100381/files#diff-40fa0fc8d59a1a5ac301fc08364bb1596e5e2dcee2f15fb25cc80d9b1a122c1b
_wmimodule.cpp https://github.com/python/cpython/pull/100381/files#diff-17fcc3b874b351eb5ff47ac1d312062f2b12ce7ea61507b7a998b66fc720cb08
Misc/NEWS.d/next/Windows/2022-12-20-18-36-17.gh-issue-99191.0cfRja.rsthttps://github.com/python/cpython/pull/100381/files#diff-40fa0fc8d59a1a5ac301fc08364bb1596e5e2dcee2f15fb25cc80d9b1a122c1b
View file https://github.com/CAM-Gerlach/cpython/blob/6b33a99e2114fb7e71fd3e73b9b640658a529961/Misc/NEWS.d/next/Windows/2022-12-20-18-36-17.gh-issue-99191.0cfRja.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100381/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L184
PC/_wmimodule.cpphttps://github.com/python/cpython/pull/100381/files#diff-17fcc3b874b351eb5ff47ac1d312062f2b12ce7ea61507b7a998b66fc720cb08
View file https://github.com/CAM-Gerlach/cpython/blob/6b33a99e2114fb7e71fd3e73b9b640658a529961/PC/_wmimodule.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100381/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100381/files#diff-17fcc3b874b351eb5ff47ac1d312062f2b12ce7ea61507b7a998b66fc720cb08
https://github.com/python/cpython/pull/100381/files#diff-17fcc3b874b351eb5ff47ac1d312062f2b12ce7ea61507b7a998b66fc720cb08
https://github.com/python/cpython/pull/100381/files#diff-17fcc3b874b351eb5ff47ac1d312062f2b12ce7ea61507b7a998b66fc720cb08
https://github.com/python/cpython/pull/100381/files#diff-17fcc3b874b351eb5ff47ac1d312062f2b12ce7ea61507b7a998b66fc720cb08
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.