René's URL Explorer Experiment


Title: gh-99191: Use correct check for MSVC C++ version support in _wmimodule.cpp by CAM-Gerlach · Pull Request #100381 · python/cpython · GitHub

Open Graph Title: gh-99191: Use correct check for MSVC C++ version support in _wmimodule.cpp by CAM-Gerlach · Pull Request #100381 · python/cpython

X Title: gh-99191: Use correct check for MSVC C++ version support in _wmimodule.cpp by CAM-Gerlach · Pull Request #100381 · python/cpython

Description: As discussed in #99191 , in PC/_wmimodule.cpp it currently uses the check #if _MSC_VER >= 1929 to determine if the compiler supports C++20 designated initializers. However, the /std:c++20 flag was ...

Open Graph Description: As discussed in #99191 , in PC/_wmimodule.cpp it currently uses the check #if _MSC_VER >= 1929 to determine if the compiler supports C++20 designated initializers. However, the /std:c++20 flag w...

X Description: As discussed in #99191 , in PC/_wmimodule.cpp it currently uses the check #if _MSC_VER >= 1929 to determine if the compiler supports C++20 designated initializers. However, the /std:c++20 fl...

Opengraph URL: https://github.com/python/cpython/pull/100381

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5840fb1a-9769-d2a8-0626-898da3a4810f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id971E:359457:13A6D1D:1B90B73:696A3F74
html-safe-nonce5633b7d966761aa5081be400c17c33318007573f8d0c99023c4db5838dd5dcfe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzFFOjM1OTQ1NzoxM0E2RDFEOjFCOTBCNzM6Njk2QTNGNzQiLCJ2aXNpdG9yX2lkIjoiODQzMDcxMDQ0NTE4NDc5NDQ4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca43df4a10c228c5432e1b78ea407c1d0134f5a53c4a62fa286279bdd6b8c6ba6
hovercard-subject-tagpull_request:1172948705
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/100381/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/be74fd723ca910f8c61f6d254fd1efa14c0f9ccc1ee872d010ef73b90c74e47e/python/cpython/pull/100381
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/be74fd723ca910f8c61f6d254fd1efa14c0f9ccc1ee872d010ef73b90c74e47e/python/cpython/pull/100381
og:image:altAs discussed in #99191 , in PC/_wmimodule.cpp it currently uses the check #if _MSC_VER >= 1929 to determine if the compiler supports C++20 designated initializers. However, the /std:c++20 flag w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCAM-Gerlach
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release13581a31d51edf4a3aca179e10890a4d4f9b6d76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/100381#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100381
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100381
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/100381
Reloadhttps://github.com/python/cpython/pull/100381
Reloadhttps://github.com/python/cpython/pull/100381
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/100381
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/100381
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/100381#issue-comment-box
zoobahttps://github.com/zooba
python:mainhttps://github.com/python/cpython/tree/main
CAM-Gerlach:fix-wmimodule-msvc-checkhttps://github.com/CAM-Gerlach/cpython/tree/fix-wmimodule-msvc-check
gh-99191: Use correct check for MSVC C++ version support in _wmimodule.cpp https://github.com/python/cpython/pull/100381#top
zoobahttps://github.com/zooba
python:mainhttps://github.com/python/cpython/tree/main
CAM-Gerlach:fix-wmimodule-msvc-checkhttps://github.com/CAM-Gerlach/cpython/tree/fix-wmimodule-msvc-check
Conversation 1 https://github.com/python/cpython/pull/100381
Commits 2 https://github.com/python/cpython/pull/100381/commits
Checks 0 https://github.com/python/cpython/pull/100381/checks
Files changed https://github.com/python/cpython/pull/100381/files
Please reload this pagehttps://github.com/python/cpython/pull/100381
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/CAM-Gerlach
CAM-Gerlachhttps://github.com/CAM-Gerlach
Dec 20, 2022https://github.com/python/cpython/pull/100381#issue-1505453507
Please reload this pagehttps://github.com/python/cpython/pull/100381
#99191https://github.com/python/cpython/issues/99191
PC/_wmimodule.cpphttps://github.com/python/cpython/blob/c18d83118881333b9a0afd0add83afb2ba7300f7/PC/_wmimodule.cpp#L20
#99191https://github.com/python/cpython/issues/99191
/std:c++20 instead of /std:c++17 used for _wmimodule.cpp, but seems unnecessary #99191https://github.com/python/cpython/issues/99191
Please reload this pagehttps://github.com/python/cpython/pull/100381
https://github.com/CAM-Gerlach
Use correct check for MSVC C++ version support in _wmimodule.cpphttps://github.com/python/cpython/pull/100381/commits/472ef3217946599ea650b33fb92dfd6fe03281b8
472ef32https://github.com/python/cpython/pull/100381/commits/472ef3217946599ea650b33fb92dfd6fe03281b8
https://github.com/CAM-Gerlach
CAM-Gerlachhttps://github.com/CAM-Gerlach
OS-windows https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-windows
build https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Abuild
3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.12
Dec 20, 2022https://github.com/python/cpython/pull/100381#event-8082558426
https://github.com/CAM-Gerlach
CAM-Gerlachhttps://github.com/CAM-Gerlach
zoobahttps://github.com/zooba
December 20, 2022 23:28https://github.com/python/cpython/pull/100381#event-8082558440
https://github.com/CAM-Gerlach
CAM-Gerlachhttps://github.com/CAM-Gerlach
code ownerhttps://github.com/python/cpython/blob/c18d83118881333b9a0afd0add83afb2ba7300f7/.github/CODEOWNERS#L114
December 20, 2022 23:28https://github.com/python/cpython/pull/100381#event-8082558459
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Dec 20, 2022 https://github.com/python/cpython/pull/100381#ref-issue-1438077871
/std:c++20 instead of /std:c++17 used for _wmimodule.cpp, but seems unnecessary #99191 https://github.com/python/cpython/issues/99191
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 20, 2022https://github.com/python/cpython/pull/100381#event-8082558695
https://github.com/CAM-Gerlach
Add NEWS entry for MSVC C++20 check changehttps://github.com/python/cpython/pull/100381/commits/6b33a99e2114fb7e71fd3e73b9b640658a529961
6b33a99https://github.com/python/cpython/pull/100381/commits/6b33a99e2114fb7e71fd3e73b9b640658a529961
https://github.com/zooba
zoobahttps://github.com/zooba
f082098https://github.com/python/cpython/commit/f08209874e58d0adbb08bd1dba4f58ba63f571c5
Jan 9, 2023https://github.com/python/cpython/pull/100381#event-8184268220
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jan 9, 2023https://github.com/python/cpython/pull/100381#event-8184268654
https://github.com/zooba
zoobahttps://github.com/zooba
Jan 9, 2023https://github.com/python/cpython/pull/100381#issuecomment-1376016140
Please reload this pagehttps://github.com/python/cpython/pull/100381
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100381
https://github.com/zooba
zooba https://github.com/zooba
3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.12
build https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Abuild
OS-windows https://github.com/python/cpython/issues?q=state%3Aopen%20label%3AOS-windows
/std:c++20 instead of /std:c++17 used for _wmimodule.cpp, but seems unnecessary https://github.com/python/cpython/issues/99191
Please reload this pagehttps://github.com/python/cpython/pull/100381
https://github.com/CAM-Gerlach
https://github.com/zooba
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.