Title: gh-100220: Fix error handling in make rules by mgorny · Pull Request #100328 · python/cpython · GitHub
Open Graph Title: gh-100220: Fix error handling in make rules by mgorny · Pull Request #100328 · python/cpython
X Title: gh-100220: Fix error handling in make rules by mgorny · Pull Request #100328 · python/cpython
Description: Use set -e before compound shell commands in order to ensure that make targets fail correctly when at least one of the subcommands fail. This is necessary since make considers a target failed only if one of the shell invocations returns with unsuccessful exit status. If a shell script does not exit explicitly, the shell uses the exit status of the last executed command. This means that when multiple commands are executed (e.g. through a for loop), the exit statuses of prior command invocations are ignored. This can be either resolved by adding an explicit || exit 1 to every command that is expected to succeed, or by running the whole script with set -e. The latter was used here as it the rules seem to be written with the assumption that individual commands were supposed to cause the make rules to fail. Issue: gh-100220
Open Graph Description: Use set -e before compound shell commands in order to ensure that make targets fail correctly when at least one of the subcommands fail. This is necessary since make considers a target failed only ...
X Description: Use set -e before compound shell commands in order to ensure that make targets fail correctly when at least one of the subcommands fail. This is necessary since make considers a target failed only ...
Opengraph URL: https://github.com/python/cpython/pull/100328
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:753913a6-19c8-a7ac-76b3-b013eae777c8 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 9962:36B93D:D0F67:12152F:696A6653 |
| html-safe-nonce | 64e819d3dac7ac40092961c1582db372ae375efa39cf840c0c3f55638763950a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTYyOjM2QjkzRDpEMEY2NzoxMjE1MkY6Njk2QTY2NTMiLCJ2aXNpdG9yX2lkIjoiNDI1MDEyMjQ3MDQ4OTIyMDY5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2e6b405dee6c578ceb08c7f5d210aad2511a976cac2d3e655e6cca34436a0812 |
| hovercard-subject-tag | pull_request:1169738804 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/100328/checks |
| twitter:image | https://avatars.githubusercontent.com/u/110765?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/110765?s=400&v=4 |
| og:image:alt | Use set -e before compound shell commands in order to ensure that make targets fail correctly when at least one of the subcommands fail. This is necessary since make considers a target failed only ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width