René's URL Explorer Experiment


Title: gh-100220: Fix error handling in make rules by mgorny · Pull Request #100328 · python/cpython · GitHub

Open Graph Title: gh-100220: Fix error handling in make rules by mgorny · Pull Request #100328 · python/cpython

X Title: gh-100220: Fix error handling in make rules by mgorny · Pull Request #100328 · python/cpython

Description: Use set -e before compound shell commands in order to ensure that make targets fail correctly when at least one of the subcommands fail. This is necessary since make considers a target failed only ...

Open Graph Description: Use set -e before compound shell commands in order to ensure that make targets fail correctly when at least one of the subcommands fail. This is necessary since make considers a target failed only ...

X Description: Use set -e before compound shell commands in order to ensure that make targets fail correctly when at least one of the subcommands fail. This is necessary since make considers a target failed only ...

Opengraph URL: https://github.com/python/cpython/pull/100328

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d70c7e85-2829-351f-c244-bc6feeaee48b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id81A6:23EE8F:2002D7:2A96F5:6969BF20
html-safe-nonceb33262b34ca2199227ab9bb899d9e7ec04852b6514c6f633bbac5ce91463f8d3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUE2OjIzRUU4RjoyMDAyRDc6MkE5NkY1OjY5NjlCRjIwIiwidmlzaXRvcl9pZCI6IjQ3NTE1NTMzMjI0MDcyODA0MTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7a1c18c0f2790d5651d9b2b9d15bfd0b1cb6294227823a879725ed8f0b45056e
hovercard-subject-tagpull_request:1169738804
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/100328/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8782c4ff9b65b0f2898af5660c656d87b5f5f0ba166e15b34166ce36607a0199/python/cpython/pull/100328
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8782c4ff9b65b0f2898af5660c656d87b5f5f0ba166e15b34166ce36607a0199/python/cpython/pull/100328
og:image:altUse set -e before compound shell commands in order to ensure that make targets fail correctly when at least one of the subcommands fail. This is necessary since make considers a target failed only ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemgorny
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/100328#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100328
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100328
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/100328
Reloadhttps://github.com/python/cpython/pull/100328
Reloadhttps://github.com/python/cpython/pull/100328
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/100328
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/100328
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/100328#issue-comment-box
zwarehttps://github.com/zware
python:mainhttps://github.com/python/cpython/tree/main
mgorny:make-fail-100220https://github.com/mgorny/cpython/tree/make-fail-100220
gh-100220: Fix error handling in make rules https://github.com/python/cpython/pull/100328#top
zwarehttps://github.com/zware
python:mainhttps://github.com/python/cpython/tree/main
mgorny:make-fail-100220https://github.com/mgorny/cpython/tree/make-fail-100220
Conversation 12 https://github.com/python/cpython/pull/100328
Commits 5 https://github.com/python/cpython/pull/100328/commits
Checks 0 https://github.com/python/cpython/pull/100328/checks
Files changed https://github.com/python/cpython/pull/100328/files
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/mgorny
mgornyhttps://github.com/mgorny
Dec 18, 2022https://github.com/python/cpython/pull/100328#issue-1501778551
Please reload this pagehttps://github.com/python/cpython/pull/100328
make sharedinstall does not return failure if install commands fail #100220https://github.com/python/cpython/issues/100220
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Dec 18, 2022 https://github.com/python/cpython/pull/100328#ref-issue-1494247691
make sharedinstall does not return failure if install commands fail #100220 https://github.com/python/cpython/issues/100220
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 18, 2022https://github.com/python/cpython/pull/100328#event-8063449159
https://github.com/kushaldas
kushaldashttps://github.com/kushaldas
Dec 19, 2022https://github.com/python/cpython/pull/100328#event-8068507647
https://github.com/merwok
merwokhttps://github.com/merwok
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jan 11, 2023https://github.com/python/cpython/pull/100328#event-8203345098
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 11, 2023https://github.com/python/cpython/pull/100328#issuecomment-1379075450
@merwokhttps://github.com/merwok
65d6cdbhttps://github.com/python/cpython/commit/65d6cdbe96bb682e4a4fa5b440330b47398f7c32
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jan 11, 2023https://github.com/python/cpython/pull/100328#event-8203345664
https://github.com/thesamesam
thesamesamhttps://github.com/thesamesam
Jan 11, 2023 https://github.com/python/cpython/pull/100328#ref-pullrequest-1501798561
gh-100221: Fix creating dirs in make sharedinstall #100329 https://github.com/python/cpython/pull/100329
https://github.com/zware
zwarehttps://github.com/zware
Feb 8, 2023https://github.com/python/cpython/pull/100328#issuecomment-1422973707
GH-100329https://github.com/python/cpython/pull/100329
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.com/mgorny
pythongh-100220https://github.com/python/cpython/issues/100220
: Fix error handling in make ruleshttps://github.com/python/cpython/pull/100328/commits/6c05684f323cc01fccaaa62f1d492f60ae2df8e5
6c05684https://github.com/python/cpython/pull/100328/commits/6c05684f323cc01fccaaa62f1d492f60ae2df8e5
https://github.com/mgorny
mgornyhttps://github.com/mgorny
force-pushedhttps://github.com/python/cpython/compare/65d6cdbe96bb682e4a4fa5b440330b47398f7c32..6c05684f323cc01fccaaa62f1d492f60ae2df8e5
65d6cdbhttps://github.com/python/cpython/commit/65d6cdbe96bb682e4a4fa5b440330b47398f7c32
6c05684https://github.com/python/cpython/commit/6c05684f323cc01fccaaa62f1d492f60ae2df8e5
Compare https://github.com/python/cpython/compare/65d6cdbe96bb682e4a4fa5b440330b47398f7c32..6c05684f323cc01fccaaa62f1d492f60ae2df8e5
February 9, 2023 05:36https://github.com/python/cpython/pull/100328#event-8475682556
https://github.com/mgorny
mgornyhttps://github.com/mgorny
Feb 9, 2023https://github.com/python/cpython/pull/100328#issuecomment-1423665961
GH-100329https://github.com/python/cpython/pull/100329
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.com/merwok
merwokhttps://github.com/merwok
Feb 9, 2023https://github.com/python/cpython/pull/100328#issuecomment-1424414232
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.com/mgorny
mgornyhttps://github.com/mgorny
Mar 2, 2023https://github.com/python/cpython/pull/100328#issuecomment-1452464061
@zwarehttps://github.com/zware
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.com/zware
zwarehttps://github.com/zware
Mar 2, 2023https://github.com/python/cpython/pull/100328#issuecomment-1452471034
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.com/mgorny
Set shell flag -e globallyhttps://github.com/python/cpython/pull/100328/commits/86c946f5f9dbaace6b34279218470a72c73317fb
86c946fhttps://github.com/python/cpython/pull/100328/commits/86c946f5f9dbaace6b34279218470a72c73317fb
https://github.com/mgorny
mgornyhttps://github.com/mgorny
Mar 3, 2023https://github.com/python/cpython/pull/100328#issuecomment-1453567069
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.com/zware
zwarehttps://github.com/zware
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Mar 3, 2023https://github.com/python/cpython/pull/100328#event-8660798788
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 3, 2023https://github.com/python/cpython/pull/100328#issuecomment-1453687585
@zwarehttps://github.com/zware
86c946fhttps://github.com/python/cpython/commit/86c946f5f9dbaace6b34279218470a72c73317fb
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Mar 3, 2023https://github.com/python/cpython/pull/100328#event-8660799216
https://github.com/zware
zwarehttps://github.com/zware
Mar 6, 2023https://github.com/python/cpython/pull/100328#issuecomment-1456730138
@kushaldashttps://github.com/kushaldas
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.com/mgorny
mgornyhttps://github.com/mgorny
Apr 5, 2023https://github.com/python/cpython/pull/100328#issuecomment-1496922956
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.com/arhadthedev
Merge branch 'main' into make-fail-100220https://github.com/python/cpython/pull/100328/commits/ef886de09e45f7e9bac45be51b167a61a91f4fd9
ef886dehttps://github.com/python/cpython/pull/100328/commits/ef886de09e45f7e9bac45be51b167a61a91f4fd9
https://github.com/arhadthedev
arhadthedevhttps://github.com/arhadthedev
build https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Abuild
Apr 5, 2023https://github.com/python/cpython/pull/100328#event-8932413383
https://github.com/zware
zwarehttps://github.com/zware
Apr 7, 2023 https://github.com/python/cpython/pull/100328#pullrequestreview-1376360483
View reviewed changes https://github.com/python/cpython/pull/100328/files/ef886de09e45f7e9bac45be51b167a61a91f4fd9
Misc/NEWS.d/next/Build/2022-12-18-07-24-44.gh-issue-100220.BgSV7C.rsthttps://github.com/python/cpython/pull/100328/files/ef886de09e45f7e9bac45be51b167a61a91f4fd9#diff-adf7b1cc98d379006c0f740a71b5addf101a222eccd38809bff337a50cb8aa96
Please reload this pagehttps://github.com/python/cpython/pull/100328
zwarehttps://github.com/zware
April 7, 2023 11:16https://github.com/python/cpython/pull/100328#commits-pushed-4006cd4
https://github.com/zware
Update Misc/NEWS.d/next/Build/2022-12-18-07-24-44.gh-issue-100220.BgS…https://github.com/python/cpython/pull/100328/commits/4006cd4e211c0a53c218b8cf3494d93803fa6d36
4006cd4https://github.com/python/cpython/pull/100328/commits/4006cd4e211c0a53c218b8cf3494d93803fa6d36
https://github.com/zware
Merge branch 'main' into make-fail-100220https://github.com/python/cpython/pull/100328/commits/46cd0c01f12c32774c5c913ed11e79f95dd58f2c
46cd0c0https://github.com/python/cpython/pull/100328/commits/46cd0c01f12c32774c5c913ed11e79f95dd58f2c
https://github.com/zware
zwarehttps://github.com/zware
Apr 7, 2023 https://github.com/python/cpython/pull/100328#pullrequestreview-1376361557
View reviewed changes https://github.com/python/cpython/pull/100328/files/46cd0c01f12c32774c5c913ed11e79f95dd58f2c
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 7, 2023https://github.com/python/cpython/pull/100328#event-8954820362
https://github.com/zware
zwarehttps://github.com/zware
a90863chttps://github.com/python/cpython/commit/a90863c993157ae65e040476cf46abd73ae54b4a
Apr 7, 2023https://github.com/python/cpython/pull/100328#event-8955388062
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 7, 2023https://github.com/python/cpython/pull/100328#event-8955388323
https://github.com/mgorny
mgornyhttps://github.com/mgorny
April 8, 2023 05:14https://github.com/python/cpython/pull/100328#event-8957121357
https://github.com/mgorny
mgornyhttps://github.com/mgorny
Apr 8, 2023https://github.com/python/cpython/pull/100328#issuecomment-1500794442
Please reload this pagehttps://github.com/python/cpython/pull/100328
warsawhttps://github.com/warsaw
Apr 11, 2023 https://github.com/python/cpython/pull/100328#ref-commit-d68d292
https://github.com/mgorny
https://github.com/zware
https://github.com/warsaw
pythongh-100220https://github.com/python/cpython/issues/100220
: Fix error handling in make rules (https://github.com/warsaw/cpython/commit/d68d2920e88aaaea2e3f385118d2a95dfc9f8a57
pythonGH-100328https://github.com/python/cpython/pull/100328
)https://github.com/warsaw/cpython/commit/d68d2920e88aaaea2e3f385118d2a95dfc9f8a57
d68d292https://github.com/warsaw/cpython/commit/d68d2920e88aaaea2e3f385118d2a95dfc9f8a57
https://github.com/zware
zwarehttps://github.com/zware
Apr 24, 2023 https://github.com/python/cpython/pull/100328#ref-issue-1681744333
SHELL=/bin/sh -e can cause failures when Makefile re-runs ./configure #103776 https://github.com/python/cpython/issues/103776
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100328
https://github.com/zware
zware https://github.com/zware
https://github.com/python/cpython/pull/100328/files/46cd0c01f12c32774c5c913ed11e79f95dd58f2c
https://github.com/kushaldas
kushaldas https://github.com/kushaldas
build https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Abuild
Please reload this pagehttps://github.com/python/cpython/pull/100328
https://github.com/mgorny
https://github.com/bedevere-bot
https://github.com/zware
https://github.com/merwok
https://github.com/kushaldas
https://github.com/arhadthedev
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.