René's URL Explorer Experiment


Title: Better stats for `LOAD_ATTR` and `STORE_ATTR` by markshannon · Pull Request #100295 · python/cpython · GitHub

Open Graph Title: Better stats for `LOAD_ATTR` and `STORE_ATTR` by markshannon · Pull Request #100295 · python/cpython

X Title: Better stats for `LOAD_ATTR` and `STORE_ATTR` by markshannon · Pull Request #100295 · python/cpython

Description: This PR provides better stats for LOAD_ATTR and STORE_ATTR, differentiating several class attributes. There is a slight change to specializing behavior, but it seems to make no difference in practice. The main change is for simple attributes of a class. Consider class C: i = 0 c = C() c.i c.i is not specialized and the failure is reported as "not in dict". i isn't in the instance's dict, but that's not the problem. With this PR, the failure is reported as "class attr simple" which is much more informative. The change in specialization behavior is that if an instance attribute shadows a non-data descriptor, it is no longer specialized. This has no effect on the hit rate, which remains at 82%, but does convert some misses to deferreds.

Open Graph Description: This PR provides better stats for LOAD_ATTR and STORE_ATTR, differentiating several class attributes. There is a slight change to specializing behavior, but it seems to make no difference in pract...

X Description: This PR provides better stats for LOAD_ATTR and STORE_ATTR, differentiating several class attributes. There is a slight change to specializing behavior, but it seems to make no difference in pract...

Opengraph URL: https://github.com/python/cpython/pull/100295

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6d99dc4f-182d-9770-8502-ad8b0858637f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96FC:20D879:237337:322C48:696A0067
html-safe-nonce2308fecde226c5d0f169f35773ac0bfec43d629707bfe8533a4162b2430db7c7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkZDOjIwRDg3OToyMzczMzc6MzIyQzQ4OjY5NkEwMDY3IiwidmlzaXRvcl9pZCI6IjQ0OTcwNTg5OTg1MzA4Nzc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac96e9b8414fcc4eaa22e2beafb224238b79350cbbf96ae0bd87d9de8e4f34e286
hovercard-subject-tagpull_request:1168549474
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/100295/files
twitter:imagehttps://avatars.githubusercontent.com/u/9448417?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9448417?s=400&v=4
og:image:altThis PR provides better stats for LOAD_ATTR and STORE_ATTR, differentiating several class attributes. There is a slight change to specializing behavior, but it seems to make no difference in pract...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/100295/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100295%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100295%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/100295/files
Reloadhttps://github.com/python/cpython/pull/100295/files
Reloadhttps://github.com/python/cpython/pull/100295/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/100295/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/100295/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
faster-cpython:better-stats-load-attrhttps://github.com/faster-cpython/cpython/tree/better-stats-load-attr
Conversation 3 https://github.com/python/cpython/pull/100295
Commits 3 https://github.com/python/cpython/pull/100295/commits
Checks 0 https://github.com/python/cpython/pull/100295/checks
Files changed https://github.com/python/cpython/pull/100295/files
Please reload this pagehttps://github.com/python/cpython/pull/100295/files
Better stats for LOAD_ATTR and STORE_ATTR https://github.com/python/cpython/pull/100295/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/100295/files
db9f04f Don't attempt to specialize for LOAD_ATTR on instance if class has at… markshannon Dec 16, 2022 https://github.com/python/cpython/pull/100295/commits/db9f04f17a7fa9ee794adb9e8ccdd4a24a8547b3
31ad53e Further improvement to LOAD_ATTR and STORE_ATTR specialization stats. markshannon Dec 16, 2022 https://github.com/python/cpython/pull/100295/commits/31ad53e700a5eee2ffa407199624a7f2afe49adf
05a9952 Refine stats for LOAD_ATTR with class attribute. markshannon Dec 16, 2022 https://github.com/python/cpython/pull/100295/commits/05a9952dfe7f89f862924f50f88541002a2b40ad
Clear filters https://github.com/python/cpython/pull/100295/files
Please reload this pagehttps://github.com/python/cpython/pull/100295/files
Please reload this pagehttps://github.com/python/cpython/pull/100295/files
pystats.h https://github.com/python/cpython/pull/100295/files#diff-c8811643aa89128cff4aee6174dc9b1a6043ae7619cc034493b97ee6a5b8a813
specialize.c https://github.com/python/cpython/pull/100295/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
Include/pystats.hhttps://github.com/python/cpython/pull/100295/files#diff-c8811643aa89128cff4aee6174dc9b1a6043ae7619cc034493b97ee6a5b8a813
View file https://github.com/faster-cpython/cpython/blob/05a9952dfe7f89f862924f50f88541002a2b40ad/Include/pystats.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100295/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100295/files#diff-c8811643aa89128cff4aee6174dc9b1a6043ae7619cc034493b97ee6a5b8a813
https://github.com/python/cpython/pull/100295/files#diff-c8811643aa89128cff4aee6174dc9b1a6043ae7619cc034493b97ee6a5b8a813
Python/specialize.chttps://github.com/python/cpython/pull/100295/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
View file https://github.com/faster-cpython/cpython/blob/05a9952dfe7f89f862924f50f88541002a2b40ad/Python/specialize.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100295/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100295/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/100295/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/100295/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/100295/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/100295/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/100295/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.