| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:16376681-d091-ad91-d90d-55497e704e23 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB02:A2A10:25A104D:34F4A98:69691C94 |
| html-safe-nonce | 5004c3e4878ca7ab40459cd4b234d9703efb8654baec68fa897d4734c771c249 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjAyOkEyQTEwOjI1QTEwNEQ6MzRGNEE5ODo2OTY5MUM5NCIsInZpc2l0b3JfaWQiOiI2OTI1OTY3NTU2NTUxMDU2ODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e26a5d7a3dac27cf551fb23522c4e83decf8bbeb5de809354e2a1b4c24f47bac |
| hovercard-subject-tag | pull_request:1167492308 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/100282/files |
| twitter:image | https://avatars.githubusercontent.com/u/17561586?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/17561586?s=400&v=4 |
| og:image:alt | Use a stack to implement pathlib.Path.walk iteratively instead of recursively to avoid hitting recursion limits on deeply nested trees.
Issue: gh-89727 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e60568924309a021b51adabdce15c2a2f285b556f3130d1a2fa2a5bce11c55f |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd206f7ed6207863172be4a783826e86bd2375c3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/100282/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100282%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100282%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/100282/files |
| Reload | https://github.com/python/cpython/pull/100282/files |
| Reload | https://github.com/python/cpython/pull/100282/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/100282/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/100282/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| barneygale | https://github.com/barneygale |
| python:main | https://github.com/python/cpython/tree/main |
| zmievsa:gh-89727/fix-pathlib.Path.walk-recursion-depth | https://github.com/zmievsa/cpython/tree/gh-89727/fix-pathlib.Path.walk-recursion-depth |
|
Conversation
43
| https://github.com/python/cpython/pull/100282 |
|
Commits
20
| https://github.com/python/cpython/pull/100282/commits |
|
Checks
0
| https://github.com/python/cpython/pull/100282/checks |
|
Files changed
| https://github.com/python/cpython/pull/100282/files |
| Please reload this page | https://github.com/python/cpython/pull/100282/files |
|
gh-89727: Fix pathlib.Path.walk RecursionError on deep trees
| https://github.com/python/cpython/pull/100282/files#top |
|
Show all changes
20 commits
| https://github.com/python/cpython/pull/100282/files |
|
037a717
Replace recursion with iteration
zmievsa Dec 15, 2022
| https://github.com/python/cpython/pull/100282/commits/037a71712f159301e43b443ba72b898be53d052f |
|
f8968b6
Unify walk and _walk methods
zmievsa Dec 15, 2022
| https://github.com/python/cpython/pull/100282/commits/f8968b647f07b7826c2d073d3007220f96bcef37 |
|
ecabf8c
Remove empty typehint
zmievsa Dec 15, 2022
| https://github.com/python/cpython/pull/100282/commits/ecabf8c99a361488935e7d49555d1199a3b50261 |
|
6ec3c3e
Fix all tests
zmievsa Dec 16, 2022
| https://github.com/python/cpython/pull/100282/commits/6ec3c3e084151d6923cb45fca401bbd53b07c656 |
|
fb5a4c7
Add test for recursion limit
zmievsa Dec 16, 2022
| https://github.com/python/cpython/pull/100282/commits/fb5a4c7af1331a9f916032f6fa15779ec2cacc70 |
|
55beb6e
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 16, 2022
| https://github.com/python/cpython/pull/100282/commits/55beb6ef59acedac5aab020ba7e8f4238d749ce9 |
|
7f36140
Merge branch 'main' into gh-89727/fix-pathlib.Path.walk-recursion-depth
zmievsa Dec 16, 2022
| https://github.com/python/cpython/pull/100282/commits/7f36140a2022c1d2961e8ce6a7c8b56cafd7e75c |
|
508bd4d
Fix recursion limit issue in different envs
zmievsa Dec 16, 2022
| https://github.com/python/cpython/pull/100282/commits/508bd4df5db39a12cf70ff959c3d1262b32c0a0c |
|
2bfc47d
Merge branch 'gh-89727/fix-pathlib.Path.walk-recursion-depth' of gith…
zmievsa Dec 16, 2022
| https://github.com/python/cpython/pull/100282/commits/2bfc47dfc3e2538c32f4a9ba3a6990d7544c5f1a |
|
20476ff
Make everything consistent with os.walk
zmievsa Dec 17, 2022
| https://github.com/python/cpython/pull/100282/commits/20476ffca31adb6586a6d4dd9f98c564562f4fd5 |
|
4f2de62
Remove unused import
zmievsa Dec 20, 2022
| https://github.com/python/cpython/pull/100282/commits/4f2de627040f6c5b7fec5088d1c1be556cada890 |
|
6313b6a
Merge branch 'main' into gh-89727/fix-pathlib.Path.walk-recursion-depth
zmievsa Dec 20, 2022
| https://github.com/python/cpython/pull/100282/commits/6313b6a9bd8d7a897eae84b7e2e768fb80744d91 |
|
17497f0
Replace the usage of infinite_recursion with set_recursion_limit
zmievsa Dec 20, 2022
| https://github.com/python/cpython/pull/100282/commits/17497f06ffd33056e3f27e4bc2a3dea73cd7c4ca |
|
2543448
Merge branch 'main' into gh-89727/fix-pathlib.Path.walk-recursion-depth
zmievsa Jan 1, 2023
| https://github.com/python/cpython/pull/100282/commits/25434486582a1f38eaef8b9b1eea2fddf19546c0 |
|
5609e4f
Code review fixes
zmievsa Jan 1, 2023
| https://github.com/python/cpython/pull/100282/commits/5609e4ff73cc916cc1c3f3a6aada0f4afa84eae5 |
|
b7d36de
Update Lib/pathlib.py
Ovsyanka83 Jan 2, 2023
| https://github.com/python/cpython/pull/100282/commits/b7d36de468c786257340ca44bab3f1a56d43014d |
|
d428a89
Code review fixes
zmievsa Jan 4, 2023
| https://github.com/python/cpython/pull/100282/commits/d428a8923b69579d9fe629ee47bb72f1cc832359 |
|
4ce5291
Merge branch 'main' into gh-89727/fix-pathlib.Path.walk-recursion-depth
zmievsa Jan 11, 2023
| https://github.com/python/cpython/pull/100282/commits/4ce5291710d0c74f0e4e8ba4d5d51857841aa751 |
|
49d4237
Apply suggestions from code review
Ovsyanka83 Jan 21, 2023
| https://github.com/python/cpython/pull/100282/commits/49d423711d8d5dff4cede4e70be167056bce7727 |
|
9bc2500
Rename stack to paths
zmievsa Mar 19, 2023
| https://github.com/python/cpython/pull/100282/commits/9bc2500855546a1cb4b83bedb75b02da1668c3d9 |
|
Clear filters
| https://github.com/python/cpython/pull/100282/files |
| Please reload this page | https://github.com/python/cpython/pull/100282/files |
| Please reload this page | https://github.com/python/cpython/pull/100282/files |
|
pathlib.py
| https://github.com/python/cpython/pull/100282/files#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c |
|
test_pathlib.py
| https://github.com/python/cpython/pull/100282/files#diff-3dd97d2dc8816848d0b0c442e8fdeec9650b3de77935289a93f37ac6396ee17f |
|
2022-12-16-10-27-58.gh-issue-89727.y64ZLM.rst
| https://github.com/python/cpython/pull/100282/files#diff-02de8a0a994f3d9804d2d82476fdbe4928071bb54fa1c250d596a97aa166462d |
| Lib/pathlib.py | https://github.com/python/cpython/pull/100282/files#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c |
|
View file
| https://github.com/zmievsa/cpython/blob/9bc2500855546a1cb4b83bedb75b02da1668c3d9/Lib/pathlib.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/100282/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/100282/files#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c |
|
| https://github.com/python/cpython/pull/100282/files#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c |
| Lib/test/test_pathlib.py | https://github.com/python/cpython/pull/100282/files#diff-3dd97d2dc8816848d0b0c442e8fdeec9650b3de77935289a93f37ac6396ee17f |
|
View file
| https://github.com/zmievsa/cpython/blob/9bc2500855546a1cb4b83bedb75b02da1668c3d9/Lib/test/test_pathlib.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/100282/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/100282/files#diff-3dd97d2dc8816848d0b0c442e8fdeec9650b3de77935289a93f37ac6396ee17f |
|
| https://github.com/python/cpython/pull/100282/files#diff-3dd97d2dc8816848d0b0c442e8fdeec9650b3de77935289a93f37ac6396ee17f |
|
| https://github.com/python/cpython/pull/100282/files#diff-3dd97d2dc8816848d0b0c442e8fdeec9650b3de77935289a93f37ac6396ee17f |
|
| https://github.com/python/cpython/pull/100282/files#diff-3dd97d2dc8816848d0b0c442e8fdeec9650b3de77935289a93f37ac6396ee17f |
| Misc/NEWS.d/next/Library/2022-12-16-10-27-58.gh-issue-89727.y64ZLM.rst | https://github.com/python/cpython/pull/100282/files#diff-02de8a0a994f3d9804d2d82476fdbe4928071bb54fa1c250d596a97aa166462d |
|
View file
| https://github.com/zmievsa/cpython/blob/9bc2500855546a1cb4b83bedb75b02da1668c3d9/Misc/NEWS.d/next/Library/2022-12-16-10-27-58.gh-issue-89727.y64ZLM.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/100282/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |