René's URL Explorer Experiment


Title: GH-90043: Handle NaNs in `COMPARE_OP_FLOAT_JUMP` by brandtbucher · Pull Request #100278 · python/cpython · GitHub

Open Graph Title: GH-90043: Handle NaNs in `COMPARE_OP_FLOAT_JUMP` by brandtbucher · Pull Request #100278 · python/cpython

X Title: GH-90043: Handle NaNs in `COMPARE_OP_FLOAT_JUMP` by brandtbucher · Pull Request #100278 · python/cpython

Description: COMPARE_OP_FLOAT_JUMP contains two DEOPT_IF branches for NaN values. This means that COMPARE_OP will repeatedly specialize and deoptimize in the presence of NaNs. The current scheme can be slightly modified to handle unordered operands correctly, and remove these checks entirely. Issue: gh-90043

Open Graph Description: COMPARE_OP_FLOAT_JUMP contains two DEOPT_IF branches for NaN values. This means that COMPARE_OP will repeatedly specialize and deoptimize in the presence of NaNs. The current scheme can be slightly...

X Description: COMPARE_OP_FLOAT_JUMP contains two DEOPT_IF branches for NaN values. This means that COMPARE_OP will repeatedly specialize and deoptimize in the presence of NaNs. The current scheme can be slightly...

Opengraph URL: https://github.com/python/cpython/pull/100278

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:22597a91-4a1c-2ab9-f2ab-bf6843dcb8d0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC4A:169ED8:4648E0:5E211E:69697F35
html-safe-nonce5113ed22cbeb9a781aae695b90bb80fe3a92c7c19c111e5238b242c899e5a259
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzRBOjE2OUVEODo0NjQ4RTA6NUUyMTFFOjY5Njk3RjM1IiwidmlzaXRvcl9pZCI6IjE0MDY3MTM1NzYzMjIzMzQ1MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac99fb20efb1f7aa69998fb302ffae6a0b8d51f50d333469140c222b79d4ba3d10
hovercard-subject-tagpull_request:1167370833
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/100278/files
twitter:imagehttps://avatars.githubusercontent.com/u/40968415?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40968415?s=400&v=4
og:image:altCOMPARE_OP_FLOAT_JUMP contains two DEOPT_IF branches for NaN values. This means that COMPARE_OP will repeatedly specialize and deoptimize in the presence of NaNs. The current scheme can be slightly...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef33e4b94c8824ab2b434d82a94139432fb5ebee9df4b75304140ad22508c4a77
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release48f380098b30acbb700b04f1724481ca10d574fc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/100278/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100278%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100278%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/100278/files
Reloadhttps://github.com/python/cpython/pull/100278/files
Reloadhttps://github.com/python/cpython/pull/100278/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:compare-op-float-nanhttps://github.com/brandtbucher/cpython/tree/compare-op-float-nan
Conversation 14 https://github.com/python/cpython/pull/100278
Commits 5 https://github.com/python/cpython/pull/100278/commits
Checks 0 https://github.com/python/cpython/pull/100278/checks
Files changed https://github.com/python/cpython/pull/100278/files
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
GH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP https://github.com/python/cpython/pull/100278/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/100278/files
f0728cf Handle NaNs in COMPARE_OP_FLOAT_JUMP brandtbucher Nov 28, 2022 https://github.com/python/cpython/pull/100278/commits/f0728cf9c23935e4f51e848909581d3bd5a18083
2665c9a Remove NaN checks! brandtbucher Nov 30, 2022 https://github.com/python/cpython/pull/100278/commits/2665c9a82699614cadc78529fe7ced82c90bc5e8
dba5894 Catch up with main brandtbucher Nov 30, 2022 https://github.com/python/cpython/pull/100278/commits/dba5894a33c9c78ec51dc68f196e5035769dca79
66d2d63 Catch up with main brandtbucher Dec 15, 2022 https://github.com/python/cpython/pull/100278/commits/66d2d6305200c800241ae1ba1c9cd0d969abd0e9
9dc68aa blurb add brandtbucher Dec 15, 2022 https://github.com/python/cpython/pull/100278/commits/9dc68aa3b3bc23309f879729c5a23ab6f3402514
Clear filters https://github.com/python/cpython/pull/100278/files
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
2022-12-15-00-50-25.gh-issue-90043.gyoKdx.rst https://github.com/python/cpython/pull/100278/files#diff-aa30defd60f732d1af7beda8d0fc4f2c06151f70ba4b2931761c7a42c7e26393
bytecodes.c https://github.com/python/cpython/pull/100278/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
generated_cases.c.h https://github.com/python/cpython/pull/100278/files#diff-4ef46fa654f95502e49a24f7dc8ee31a4cac9b3433fe9cd2b2d4dd78cfbad448
specialize.c https://github.com/python/cpython/pull/100278/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
Misc/NEWS.d/next/Core and Builtins/2022-12-15-00-50-25.gh-issue-90043.gyoKdx.rsthttps://github.com/python/cpython/pull/100278/files#diff-aa30defd60f732d1af7beda8d0fc4f2c06151f70ba4b2931761c7a42c7e26393
View file https://github.com/brandtbucher/cpython/blob/9dc68aa3b3bc23309f879729c5a23ab6f3402514/Misc/NEWS.d/next/Core%20and%20Builtins/2022-12-15-00-50-25.gh-issue-90043.gyoKdx.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100278/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L221
Python/bytecodes.chttps://github.com/python/cpython/pull/100278/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
View file https://github.com/brandtbucher/cpython/blob/9dc68aa3b3bc23309f879729c5a23ab6f3402514/Python/bytecodes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100278/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100278/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
sweeneydehttps://github.com/sweeneyde
Dec 15, 2022https://github.com/python/cpython/pull/100278/files#r1050246713
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
brandtbucherhttps://github.com/brandtbucher
Dec 16, 2022https://github.com/python/cpython/pull/100278/files#r1050253440
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@markshannonhttps://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
mdickinsonhttps://github.com/mdickinson
Dec 16, 2022https://github.com/python/cpython/pull/100278/files#r1050942358
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
mdickinsonhttps://github.com/mdickinson
Dec 16, 2022https://github.com/python/cpython/pull/100278/files#r1050942870
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
markshannonhttps://github.com/markshannon
Dec 16, 2022https://github.com/python/cpython/pull/100278/files#r1050948459
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
mdickinsonhttps://github.com/mdickinson
Dec 16, 2022https://github.com/python/cpython/pull/100278/files#r1050990448
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@brandtbucherhttps://github.com/brandtbucher
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
brandtbucherhttps://github.com/brandtbucher
Dec 16, 2022https://github.com/python/cpython/pull/100278/files#r1050998518
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
mdickinsonhttps://github.com/mdickinson
Dec 16, 2022https://github.com/python/cpython/pull/100278/files#r1050999485
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#81655https://github.com/python/cpython/issues/81655
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
mdickinsonhttps://github.com/mdickinson
Dec 16, 2022https://github.com/python/cpython/pull/100278/files#r1051016730
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
cpython/Objects/floatobject.chttps://github.com/python/cpython/blob/ca079a3ea30098aff3197c559a0e32d42dda6d84/Objects/floatobject.c#L600-L621
ca079a3https://github.com/python/cpython/commit/ca079a3ea30098aff3197c559a0e32d42dda6d84
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
mdickinsonhttps://github.com/mdickinson
Dec 16, 2022https://github.com/python/cpython/pull/100278/files#r1051020993
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
https://github.com/python/cpython/pull/100278/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
https://github.com/python/cpython/pull/100278/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
Python/generated_cases.c.hhttps://github.com/python/cpython/pull/100278/files#diff-4ef46fa654f95502e49a24f7dc8ee31a4cac9b3433fe9cd2b2d4dd78cfbad448
View file https://github.com/brandtbucher/cpython/blob/9dc68aa3b3bc23309f879729c5a23ab6f3402514/Python/generated_cases.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
Python/specialize.chttps://github.com/python/cpython/pull/100278/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
View file https://github.com/brandtbucher/cpython/blob/9dc68aa3b3bc23309f879729c5a23ab6f3402514/Python/specialize.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100278/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100278/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/100278/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
sweeneydehttps://github.com/sweeneyde
Dec 15, 2022https://github.com/python/cpython/pull/100278/files#r1050248068
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
brandtbucherhttps://github.com/brandtbucher
Dec 16, 2022https://github.com/python/cpython/pull/100278/files#r1050251755
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/100278/files
https://github.com/python/cpython/pull/100278/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/100278/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/100278/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.