René's URL Explorer Experiment


Title: gh-99941: asyncio.Protocol.data_received now received immutable bytes by DarioDaF · Pull Request #100053 · python/cpython · GitHub

Open Graph Title: gh-99941: asyncio.Protocol.data_received now received immutable bytes by DarioDaF · Pull Request #100053 · python/cpython

X Title: gh-99941: asyncio.Protocol.data_received now received immutable bytes by DarioDaF · Pull Request #100053 · python/cpython

Description: Made asyncio.Protocol.data_received receive immutable object bytes instead of bytearrays (like defined in the docs) with regression tests added and opted to use memoryview to take the slices for performance on big buffers. Performance test from #21442 done on my machine with 10 repetitions on release build with timings 0.043 (delta: 0.019) before patch and 0.041 (delta: 0.010) after so no noticable change in performance. Issue: gh-99941

Open Graph Description: Made asyncio.Protocol.data_received receive immutable object bytes instead of bytearrays (like defined in the docs) with regression tests added and opted to use memoryview to take the slices for pe...

X Description: Made asyncio.Protocol.data_received receive immutable object bytes instead of bytearrays (like defined in the docs) with regression tests added and opted to use memoryview to take the slices for pe...

Opengraph URL: https://github.com/python/cpython/pull/100053

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b770d4e3-b469-0ff3-0df1-3d5c371c55a8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA654:C9E9C:47FD7A:65C7DD:696A0C6D
html-safe-nonce6636890f05a1036a533c20e3b8d6d3024957527f4e31c31760276d7e7e08c828
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjU0OkM5RTlDOjQ3RkQ3QTo2NUM3REQ6Njk2QTBDNkQiLCJ2aXNpdG9yX2lkIjoiMTAwNDk3MDQ0MDA1NzgxODIyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac947284a3cba0a8debfc94ecb1b6848586fd02f3ccf58ee3a1a15f5e2b2114c11
hovercard-subject-tagpull_request:1148614172
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/100053/files
twitter:imagehttps://avatars.githubusercontent.com/u/10617344?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10617344?s=400&v=4
og:image:altMade asyncio.Protocol.data_received receive immutable object bytes instead of bytearrays (like defined in the docs) with regression tests added and opted to use memoryview to take the slices for pe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7266b2d935baa1c6474b16dd9feaa5ca30607261
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/100053/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100053%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F100053%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/100053/files
Reloadhttps://github.com/python/cpython/pull/100053/files
Reloadhttps://github.com/python/cpython/pull/100053/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/100053/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/100053/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
DarioDaF:fix_#99941https://github.com/DarioDaF/cpython/tree/fix_%2399941
Conversation 4 https://github.com/python/cpython/pull/100053
Commits 4 https://github.com/python/cpython/pull/100053/commits
Checks 0 https://github.com/python/cpython/pull/100053/checks
Files changed https://github.com/python/cpython/pull/100053/files
Please reload this pagehttps://github.com/python/cpython/pull/100053/files
gh-99941: asyncio.Protocol.data_received now received immutable bytes https://github.com/python/cpython/pull/100053/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/100053/files
aad3337 Moving transport data_read to bytes through memoryview DarioDaF Dec 6, 2022 https://github.com/python/cpython/pull/100053/commits/aad3337eeeaa90b4a2268ff590a4ff274c4bd7f9
1a5af35 Added test case for #99941 DarioDaF Dec 6, 2022 https://github.com/python/cpython/pull/100053/commits/1a5af35f3667d5961869662e08f882fe9c3f0e95
d9e22f7 Added blurb DarioDaF Dec 6, 2022 https://github.com/python/cpython/pull/100053/commits/d9e22f78b30941499545eb705da5b3e515e0f503
e101911 Simplify news entry gvanrossum Dec 10, 2022 https://github.com/python/cpython/pull/100053/commits/e101911355177b6aac3fb4f07159f2c5b1c3854b
Clear filters https://github.com/python/cpython/pull/100053/files
Please reload this pagehttps://github.com/python/cpython/pull/100053/files
Please reload this pagehttps://github.com/python/cpython/pull/100053/files
proactor_events.py https://github.com/python/cpython/pull/100053/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
streams.py https://github.com/python/cpython/pull/100053/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
test_proactor_events.py https://github.com/python/cpython/pull/100053/files#diff-64f40794e7d328f5f5c7cf78bcc305c6f17ff02e5b9ebd1c78b6cbc5dc865187
2022-12-06-11-16-46.gh-issue-99941.GmUQ6o.rst https://github.com/python/cpython/pull/100053/files#diff-eee95641c86233ed1c1c67770351c6d3e0eddcff41a4f4f0a247b84b09d524cd
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L369
Lib/asyncio/proactor_events.pyhttps://github.com/python/cpython/pull/100053/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
View file https://github.com/DarioDaF/cpython/blob/e101911355177b6aac3fb4f07159f2c5b1c3854b/Lib/asyncio/proactor_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100053/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100053/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/pull/100053/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L369
Lib/asyncio/streams.pyhttps://github.com/python/cpython/pull/100053/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
View file https://github.com/DarioDaF/cpython/blob/e101911355177b6aac3fb4f07159f2c5b1c3854b/Lib/asyncio/streams.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100053/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100053/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
https://github.com/python/cpython/pull/100053/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
https://github.com/python/cpython/pull/100053/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
https://github.com/python/cpython/pull/100053/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L370
Lib/test/test_asyncio/test_proactor_events.pyhttps://github.com/python/cpython/pull/100053/files#diff-64f40794e7d328f5f5c7cf78bcc305c6f17ff02e5b9ebd1c78b6cbc5dc865187
View file https://github.com/DarioDaF/cpython/blob/e101911355177b6aac3fb4f07159f2c5b1c3854b/Lib/test/test_asyncio/test_proactor_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100053/{{ revealButtonHref }}
https://github.com/python/cpython/pull/100053/files#diff-64f40794e7d328f5f5c7cf78bcc305c6f17ff02e5b9ebd1c78b6cbc5dc865187
https://github.com/python/cpython/pull/100053/files#diff-64f40794e7d328f5f5c7cf78bcc305c6f17ff02e5b9ebd1c78b6cbc5dc865187
Misc/NEWS.d/next/Windows/2022-12-06-11-16-46.gh-issue-99941.GmUQ6o.rsthttps://github.com/python/cpython/pull/100053/files#diff-eee95641c86233ed1c1c67770351c6d3e0eddcff41a4f4f0a247b84b09d524cd
View file https://github.com/DarioDaF/cpython/blob/e101911355177b6aac3fb4f07159f2c5b1c3854b/Misc/NEWS.d/next/Windows/2022-12-06-11-16-46.gh-issue-99941.GmUQ6o.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/100053/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.