Title: Document sqlite3.connect() as implicitly opening transactions in the new PEP-249 manual commit mode · Issue #99824 · python/cpython · GitHub
Open Graph Title: Document sqlite3.connect() as implicitly opening transactions in the new PEP-249 manual commit mode · Issue #99824 · python/cpython
X Title: Document sqlite3.connect() as implicitly opening transactions in the new PEP-249 manual commit mode · Issue #99824 · python/cpython
Description: Documentation In sqlite3, @malemburg specified that connect(), commit(), and rollback() implicitly open transactions in the new PEP-249 manual commit mode implemented in PR #93823: If this is set to False, the module could then implement...
Open Graph Description: Documentation In sqlite3, @malemburg specified that connect(), commit(), and rollback() implicitly open transactions in the new PEP-249 manual commit mode implemented in PR #93823: If this is set t...
X Description: Documentation In sqlite3, @malemburg specified that connect(), commit(), and rollback() implicitly open transactions in the new PEP-249 manual commit mode implemented in PR #93823: If this is set t...
Opengraph URL: https://github.com/python/cpython/issues/99824
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Document sqlite3.connect() as implicitly opening transactions in the new PEP-249 manual commit mode","articleBody":"# Documentation\r\n\r\nIn `sqlite3`, @malemburg [specified](https://github.com/python/cpython/issues/83638#issuecomment-1093853924) that `connect()`, `commit()`, and `rollback()` implicitly open transactions in the new PEP-249 manual commit mode implemented in PR #93823:\r\n\r\n\u003e If this is set to False, the module could then implement the\r\n\u003e correct way of handling transactions, which means:\r\n\u003e \r\n\u003e a) start a new transaction when the connection is opened\r\n\u003e b) start a new transaction after .commit() and .rollback()\r\n\u003e c) don't start new transactions anywhere else\r\n\u003e d) run an implicit .rollback() when the connection closes\r\n\r\nSo I expect to see that information clearly documented.\r\n\r\nYet the PR documented it only for `commit()` and `rollback()` (item b), not for `connect()` (item a):\r\n\r\n```\r\n* :mod:`!sqlite3` ensures that a transaction is always open,\r\n so :meth:`Connection.commit` and :meth:`Connection.rollback`\r\n will implicitly open a new transaction immediately after closing\r\n the pending one.\r\n```\r\n\r\nTo me it is important to document it also for `connect()` rather than relying on user’s deduction, which is not obvious at all since for instance in *legacy* manual commit mode, `sqlite3` does *not* implicitly open transactions when `connect()` is called but when `execute()` is called on a DML statement.\r\n\r\n\u003c!-- gh-linked-prs --\u003e\r\n### Linked PRs\r\n* gh-99825\r\n\u003c!-- /gh-linked-prs --\u003e\r\n","author":{"url":"https://github.com/geryogam","@type":"Person","name":"geryogam"},"datePublished":"2022-11-27T20:38:28.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/99824/cpython/issues/99824"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:092fc164-89da-dc22-baeb-56126660028f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 83B4:8A288:91077A:C3B0DE:6969BE9B |
| html-safe-nonce | 1f548a086e90a0faa678dff18a5c7b84038d0f92eaa575bab713114b4f95852b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0I0OjhBMjg4OjkxMDc3QTpDM0IwREU6Njk2OUJFOUIiLCJ2aXNpdG9yX2lkIjoiNjg1NDQ2Njk5NTI2NTA2MDUwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 36a8cee4f97118aed9b2335cb4e0e0c1295d181271b03cca2aea683dcde6af04 |
| hovercard-subject-tag | issue:1465569167 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/99824/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b6fcf6e53bf7091e20e21031d75e090cad3590a48ed750f22d45b01aa7208861/python/cpython/issues/99824 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b6fcf6e53bf7091e20e21031d75e090cad3590a48ed750f22d45b01aa7208861/python/cpython/issues/99824 |
| og:image:alt | Documentation In sqlite3, @malemburg specified that connect(), commit(), and rollback() implicitly open transactions in the new PEP-249 manual commit mode implemented in PR #93823: If this is set t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | geryogam |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width