Title: Consider testing `zoneinfo` with `tzdata` PyPI package installed · Issue #99649 · python/cpython · GitHub
Open Graph Title: Consider testing `zoneinfo` with `tzdata` PyPI package installed · Issue #99649 · python/cpython
X Title: Consider testing `zoneinfo` with `tzdata` PyPI package installed · Issue #99649 · python/cpython
Description: Feature or enhancement Right now none of our build bots test zoneinfo with tzdata pypi package installed. Proof: https://github.com/python/cpython/pull/99602/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45dR27-...
Open Graph Description: Feature or enhancement Right now none of our build bots test zoneinfo with tzdata pypi package installed. Proof: https://github.com/python/cpython/pull/99602/files#diff-7908b1930bd1135d6f8077ef5ff5...
X Description: Feature or enhancement Right now none of our build bots test zoneinfo with tzdata pypi package installed. Proof: https://github.com/python/cpython/pull/99602/files#diff-7908b1930bd1135d6f8077ef5ff5...
Opengraph URL: https://github.com/python/cpython/issues/99649
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Consider testing `zoneinfo` with `tzdata` PyPI package installed","articleBody":"# Feature or enhancement\r\n\r\nRight now none of our build bots test `zoneinfo` with `tzdata` pypi package installed.\r\nProof: https://github.com/python/cpython/pull/99602/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45dR27-R35\r\n\r\nLink to the package: https://pypi.org/project/tzdata/\r\n\r\nHowever, it works locally:\r\n\r\n```\r\n(.venv) ~/Desktop/cpython issue-99508 ✔ \r\n» pip install tzdata \r\nCollecting tzdata\r\n Using cached tzdata-2022.6-py2.py3-none-any.whl (338 kB)\r\nInstalling collected packages: tzdata\r\nSuccessfully installed tzdata-2022.6\r\n\r\n(.venv) ~/Desktop/cpython issue-99508 ✔ \r\n» python\r\nPython 3.12.0a2+ (heads/main:a3360facba, Nov 19 2022, 14:10:54) [Clang 11.0.0 (clang-1100.0.33.16)] on darwin\r\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\r\n\u003e\u003e\u003e import importlib.metadata\r\n\u003e\u003e\u003e importlib.metadata.metadata(\"tzdata\")\r\n\u003cimportlib.metadata._adapters.Message object at 0x107d5df50\u003e\r\n```\r\n\r\nBut, presence / absence of this 3rd party package change the behavior of `zoneinfo` module: both `C` and `Python` versions of it.\r\n\r\nSo, we need to be sure that tests can check all combinations.\r\n\r\n# Risks\r\n\r\nRight now we don't have 3rd party packages installed for tests.\r\nThis might cause quite a lot of problems: where / how / when to install it.\r\nIt also can affect test / buildbot stability, because `pip` sometimes just fails to install some packages and you have to retry.\r\n\r\n# Pitch\r\n\r\nI think we should test with `tzdata` PyPI package installed on at least one buildbot / CI job.\r\nThe question is: how can we do it without compromising the CI setup and reliability?\r\n\r\n# Previous discussion\r\n\r\n- https://github.com/python/cpython/issues/84683#issuecomment-1093870842 \r\n- https://github.com/python/cpython/pull/99602\r\n- https://github.com/python/cpython/issues/96463\r\n\r\nCC @pganssle \r\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2022-11-21T14:05:07.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/99649/cpython/issues/99649"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:225c17b2-ecc7-8794-39a3-54714f7137eb |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ACE6:CADE5:A4389D:D9FF5C:6969917A |
| html-safe-nonce | 1a9c56eeee0f15a97c4ab65d3db2f81218b32e1c87d6aebabad3826463ebbd1f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQ0U2OkNBREU1OkE0Mzg5RDpEOUZGNUM6Njk2OTkxN0EiLCJ2aXNpdG9yX2lkIjoiODc3NzYzOTMxNjI2MzI5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e6dc06f8d56473665dbf35c37902ffa912bf2e76800adad7be6154115dd697af |
| hovercard-subject-tag | issue:1458006971 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/99649/issue_layout |
| twitter:image | https://opengraph.githubassets.com/2cd1a4868dd00c3b2fcc65b0f6f342694f6d471f573d75ac6391c1f7e408c0ee/python/cpython/issues/99649 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2cd1a4868dd00c3b2fcc65b0f6f342694f6d471f573d75ac6391c1f7e408c0ee/python/cpython/issues/99649 |
| og:image:alt | Feature or enhancement Right now none of our build bots test zoneinfo with tzdata pypi package installed. Proof: https://github.com/python/cpython/pull/99602/files#diff-7908b1930bd1135d6f8077ef5ff5... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3542e147982176a7ebaa23dfb559c8af16f721c03ec560c68c56b64a0f35e751 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | af80af7cc9e3de9c336f18b208a600950a3c187c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width