René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Call to _imp.source_hash with incorrect arguments in (unreachable?) part of SourceLoader.get_code (importlib._bootstrap_external)","articleBody":"# Bug report\r\n\r\nAs far as I can tell this line:\r\nhttps://github.com/python/cpython/blob/4e4b13e8f6211abbc0d53056da11357756daa314/Lib/importlib/_bootstrap_external.py#L1147-L1147\r\n\r\nwill raise a TypeError and should be a 2 argument form as seen earlier in the same method.\r\n\r\nhttps://github.com/python/cpython/blob/4e4b13e8f6211abbc0d53056da11357756daa314/Lib/importlib/_bootstrap_external.py#L1117-L1120\r\n\r\nHowever, as either `hash_based` is False, `source_hash` has already been generated or the code returns early I don't think this line can be reached. (Maybe if you have a flaky version of get_data that sometimes raises an ImportError/EOFError??).\r\n\r\nExample:\r\n```python3\r\n\u003e\u003e\u003e _imp.source_hash(_RAW_MAGIC_NUMBER, b'')\r\nb's\\x8d\\x9c\\xd5\\xd5\\xe8\\x7fs'\r\n\r\n\u003e\u003e\u003e _imp.source_hash(b'')\r\nTraceback (most recent call last):\r\n  File \"/opt/local/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/code.py\", line 90, in runcode\r\n    exec(code, self.locals)\r\n  File \"\u003cinput\u003e\", line 1, in \u003cmodule\u003e\r\nTypeError: source_hash() missing required argument 'source' (pos 2)\r\n```\r\n\r\nEdit: Sorry, as I opened the issue from within the source line via 'reference in new issue' I think I accidentally skipped the bug report format that would have given this a label.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-99635\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/DavidCEllis","@type":"Person","name":"DavidCEllis"},"datePublished":"2022-11-15T12:14:52.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/99508/cpython/issues/99508"}