René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Replace Py_INCREF()/Py_XINCREF() usage with Py_NewRef()/Py_XNewRef()","articleBody":"I added Py_NewRef() and Py_XNewRef() to Python 3.10 C API. IMO using them make to code easier to read and make the code looks \"more correct\". Examples:\r\n\r\n(A) Assign + INCREF:\r\n\r\n```diff\r\n-                result = Py_False;\r\n-                Py_INCREF(result);\r\n+                result = Py_NewRef(Py_False);\r\n```\r\n\r\n(B) INCREF + assign:\r\n\r\n```diff\r\n-        Py_INCREF(last);\r\n-        self-\u003elast = last;\r\n+        self-\u003elast = Py_NewRef(last);\r\n```\r\n\r\n(C) INCREF + return:\r\n\r\n```diff\r\n-    Py_XINCREF(result);\r\n-    return result;\r\n+    return Py_XNewRef(result);\r\n```\r\n\r\nWhile technically, Py_INCREF() and Py_XINCREF() modify the object in-place (increment their reference counter), for me Py_NewRef() makes me sense: it creates \"a new reference\".\r\n\r\nThe example (A) is weird: it assigns a variable to something, and only later creates a new reference. For me, the syntax with Py_NewRef() makes more sense.\r\n\r\nExamples (B) and (C) are shorter with Py_NewRef(), and again, IMO makes more sense and are more readable.\n\n\u003c!-- gh-pr-number: gh-99302 --\u003e\n* PR: gh-99302\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99317 --\u003e\n* PR: gh-99317\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99318 --\u003e\n* PR: gh-99318\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99330 --\u003e\n* PR: gh-99330\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99332 --\u003e\n* PR: gh-99332\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99333 --\u003e\n* PR: gh-99333\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99335 --\u003e\n* PR: gh-99335\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99336 --\u003e\n* PR: gh-99336\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99351 --\u003e\n* PR: gh-99351\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99354 --\u003e\n* PR: gh-99354\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99436 --\u003e\n* PR: gh-99436\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99438 --\u003e\n* PR: gh-99438\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99439 --\u003e\n* PR: gh-99439\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99440 --\u003e\n* PR: gh-99440\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99441 --\u003e\n* PR: gh-99441\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99465 --\u003e\n* PR: gh-99465\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99466 --\u003e\n* PR: gh-99466\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99467 --\u003e\n* PR: gh-99467\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99468 --\u003e\n* PR: gh-99468\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99469 --\u003e\n* PR: gh-99469\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99473 --\u003e\n* PR: gh-99473\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99479 --\u003e\n* PR: gh-99479\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99480 --\u003e\n* PR: gh-99480\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99499 --\u003e\n* PR: gh-99499\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99513 --\u003e\n* PR: gh-99513\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99530 --\u003e\n* PR: gh-99530\n\u003c!-- /gh-pr-number --\u003e\n\n\n\u003c!-- gh-pr-number: gh-99696 --\u003e\n* PR: gh-99696\n\u003c!-- /gh-pr-number --\u003e\n","author":{"url":"https://github.com/vstinner","@type":"Person","name":"vstinner"},"datePublished":"2022-11-09T21:31:01.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/99300/cpython/issues/99300"}