René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug report: shutil.make_archive() makes empty archive file even when root_dir does not exists","articleBody":"# Bug report\r\n\r\nIn python 3.10+, shutil.make_archive() makes empty archive file and does not raise any error even when root_dir does not exists.\r\nIn python -3.9, FileNotFoundError is raised with message `[Errno 2] No such file or directory: ‘xxxxxxx’`.\r\n\r\n```\r\nimport shutil\r\n\r\nshutil.make_archive(base_name='aaa_archive', root_dir=\"not_existing_dir\", format=\"zip\")\r\n# This will raise FileNotFoundError in python ~3.9, where it doesn’t in 3.10~\r\n```\r\n\r\nI though making empty archive file is unnatural, so fixing it maybe good for backward compatibility.\r\n\r\nI think this problem is caused in this line, where `os.chdir(root_dir)` is not called anymore.\r\nIn the previous code, `os.chdir(root_dir)` will raise FileNotFoundError when root_dir does not exists.\r\nhttps://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689bL1084 \r\n\r\nI thought checking the existence of root_dir and raise FileNotFoundError when root_dir is not found, might be a good implementation to fix this problem.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-99802\n* gh-107998\n* gh-107999\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/mski-iksm","@type":"Person","name":"mski-iksm"},"datePublished":"2022-11-07T15:07:32.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/99203/cpython/issues/99203"}