Title: /std:c++20 instead of /std:c++17 used for _wmimodule.cpp, but seems unnecessary · Issue #99191 · python/cpython · GitHub
Open Graph Title: /std:c++20 instead of /std:c++17 used for _wmimodule.cpp, but seems unnecessary · Issue #99191 · python/cpython
X Title: /std:c++20 instead of /std:c++17 used for _wmimodule.cpp, but seems unnecessary · Issue #99191 · python/cpython
Description: @python/windows-team I noticed the VS project file _wmi.cxproj for _wmimodule.cpp added for 3.12 to support using WMI on Windows to get platform data in issue #89545 / PR #96289 specifies C++20 mode via the compiler flag /std:c++20. The ...
Open Graph Description: @python/windows-team I noticed the VS project file _wmi.cxproj for _wmimodule.cpp added for 3.12 to support using WMI on Windows to get platform data in issue #89545 / PR #96289 specifies C++20 mod...
X Description: @python/windows-team I noticed the VS project file _wmi.cxproj for _wmimodule.cpp added for 3.12 to support using WMI on Windows to get platform data in issue #89545 / PR #96289 specifies C++20 mod...
Opengraph URL: https://github.com/python/cpython/issues/99191
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"/std:c++20 instead of /std:c++17 used for _wmimodule.cpp, but seems unnecessary","articleBody":"@python/windows-team \r\n\r\nI noticed the VS project file `_wmi.cxproj` for `_wmimodule.cpp` added for 3.12 to support using WMI on Windows to get `platform` data in issue #89545 / PR #96289 specifies C++20 mode via the compiler flag `/std:c++20`. The flag (and partially-complete C++20 support) was only added in VS 2019 16.11, and produces a compiler warning in VS 2017 15.9 stating the flag was ignored.\r\n\r\nThis is the only file that requires it and there were no relevant hints in the issue, PR, or commit history as to why it was required. Despite the flag being ignored, there were no compiler errors or other warnings, and both the full test suite (minus a couple clearly unrelated issues) and running `test_wmi` and `test_platform` with `-u all` passed, and the same was true when I recompiled it with `/std:c++17` (added in VS 2017 15.8 and used a couple other files), which naturally avoids the warning.\r\n\r\nTherefore, it would seems specifying C++20 is unnecessary, and it can be changed to `/std:c++17` to avoid compiler warnings and use a consistent C++ standard version with the other files, unless there's something I'm missing here (entirely possible, of course). Any reason this was added?\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-100381\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/CAM-Gerlach","@type":"Person","name":"CAM-Gerlach"},"datePublished":"2022-11-07T09:58:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":10},"url":"https://github.com/99191/cpython/issues/99191"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2f61494d-2d7e-801f-dcfe-477007c36de3 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A730:7B62C:E37C80:1367C12:6969F519 |
| html-safe-nonce | b9bbfcdf9ec5b553ee29426bae0657869e75244557c8be89d01705f7c8f97fb5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzMwOjdCNjJDOkUzN0M4MDoxMzY3QzEyOjY5NjlGNTE5IiwidmlzaXRvcl9pZCI6IjQ1MzY2NTExMjA0Njg2ODYxMDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6b4d03899419b1c075207a155dbd212738d06617a920b1e8e94525b9788415f8 |
| hovercard-subject-tag | issue:1438077871 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/99191/issue_layout |
| twitter:image | https://opengraph.githubassets.com/cf1dab0c9d67fde26fa83bf2b9895139473e87f58707ca206ac7597b088c7746/python/cpython/issues/99191 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cf1dab0c9d67fde26fa83bf2b9895139473e87f58707ca206ac7597b088c7746/python/cpython/issues/99191 |
| og:image:alt | @python/windows-team I noticed the VS project file _wmi.cxproj for _wmimodule.cpp added for 3.12 to support using WMI on Windows to get platform data in issue #89545 / PR #96289 specifies C++20 mod... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | CAM-Gerlach |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width