René's URL Explorer Experiment


Title: /std:c++20 instead of /std:c++17 used for _wmimodule.cpp, but seems unnecessary · Issue #99191 · python/cpython · GitHub

Open Graph Title: /std:c++20 instead of /std:c++17 used for _wmimodule.cpp, but seems unnecessary · Issue #99191 · python/cpython

X Title: /std:c++20 instead of /std:c++17 used for _wmimodule.cpp, but seems unnecessary · Issue #99191 · python/cpython

Description: @python/windows-team I noticed the VS project file _wmi.cxproj for _wmimodule.cpp added for 3.12 to support using WMI on Windows to get platform data in issue #89545 / PR #96289 specifies C++20 mode via the compiler flag /std:c++20. The ...

Open Graph Description: @python/windows-team I noticed the VS project file _wmi.cxproj for _wmimodule.cpp added for 3.12 to support using WMI on Windows to get platform data in issue #89545 / PR #96289 specifies C++20 mod...

X Description: @python/windows-team I noticed the VS project file _wmi.cxproj for _wmimodule.cpp added for 3.12 to support using WMI on Windows to get platform data in issue #89545 / PR #96289 specifies C++20 mod...

Opengraph URL: https://github.com/python/cpython/issues/99191

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"/std:c++20 instead of /std:c++17 used for _wmimodule.cpp, but seems unnecessary","articleBody":"@python/windows-team \r\n\r\nI noticed the VS project file `_wmi.cxproj` for `_wmimodule.cpp` added for 3.12 to support using WMI on Windows to get `platform` data in issue #89545 / PR #96289 specifies C++20 mode via the compiler flag `/std:c++20`. The flag (and partially-complete C++20 support) was only added in VS 2019 16.11, and produces a compiler warning in VS 2017 15.9 stating the flag was ignored.\r\n\r\nThis is the only file that requires it and there were no relevant hints in the issue, PR, or commit history as to why it was required. Despite the flag being ignored, there were no compiler errors or other warnings, and both the full test suite (minus a couple clearly unrelated issues) and running `test_wmi` and `test_platform` with `-u all` passed, and the same was true when I recompiled it with  `/std:c++17` (added in VS 2017 15.8 and used a couple other files), which naturally avoids the warning.\r\n\r\nTherefore, it would seems specifying C++20 is unnecessary, and it can be changed to `/std:c++17` to avoid compiler warnings and use a consistent C++ standard version with the other files, unless there's something I'm missing here (entirely possible, of course). Any reason this was added?\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-100381\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/CAM-Gerlach","@type":"Person","name":"CAM-Gerlach"},"datePublished":"2022-11-07T09:58:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":10},"url":"https://github.com/99191/cpython/issues/99191"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2f61494d-2d7e-801f-dcfe-477007c36de3
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA730:7B62C:E37C80:1367C12:6969F519
html-safe-nonceb9bbfcdf9ec5b553ee29426bae0657869e75244557c8be89d01705f7c8f97fb5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzMwOjdCNjJDOkUzN0M4MDoxMzY3QzEyOjY5NjlGNTE5IiwidmlzaXRvcl9pZCI6IjQ1MzY2NTExMjA0Njg2ODYxMDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6b4d03899419b1c075207a155dbd212738d06617a920b1e8e94525b9788415f8
hovercard-subject-tagissue:1438077871
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/99191/issue_layout
twitter:imagehttps://opengraph.githubassets.com/cf1dab0c9d67fde26fa83bf2b9895139473e87f58707ca206ac7597b088c7746/python/cpython/issues/99191
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cf1dab0c9d67fde26fa83bf2b9895139473e87f58707ca206ac7597b088c7746/python/cpython/issues/99191
og:image:alt@python/windows-team I noticed the VS project file _wmi.cxproj for _wmimodule.cpp added for 3.12 to support using WMI on Windows to get platform data in issue #89545 / PR #96289 specifies C++20 mod...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCAM-Gerlach
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/99191#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F99191
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F99191
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/99191
Reloadhttps://github.com/python/cpython/issues/99191
Reloadhttps://github.com/python/cpython/issues/99191
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/99191
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/99191
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/99191
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/99191
#100381https://github.com/python/cpython/pull/100381
/std:c++20 instead of /std:c++17 used for _wmimodule.cpp, but seems unnecessaryhttps://github.com/python/cpython/issues/99191#top
#100381https://github.com/python/cpython/pull/100381
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
OS-windowshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22OS-windows%22
buildThe build process and cross-buildhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22build%22
https://github.com/CAM-Gerlach
https://github.com/CAM-Gerlach
CAM-Gerlachhttps://github.com/CAM-Gerlach
on Nov 7, 2022https://github.com/python/cpython/issues/99191#issue-1438077871
#89545https://github.com/python/cpython/issues/89545
#96289https://github.com/python/cpython/pull/96289
gh-99191: Use correct check for MSVC C++ version support in _wmimodule.cpp #100381https://github.com/python/cpython/pull/100381
3.12only security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.12%22
OS-windowshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22OS-windows%22
buildThe build process and cross-buildhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22build%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.