René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove zero or negative reference counter check in `PyObject_Print`","articleBody":"# Feature or enhancement\r\n\r\nRemove the section of the PyObject_Print function that handles input objects that have a negative reference counter:\r\nhttps://github.com/python/cpython/blob/88297e2a8a75898228360ee369628a4a6111e2ee/Objects/object.c#L274-L278\r\n\r\n# Previous discussion\r\nThe PR https://github.com/python/cpython/pull/98749 that improves the coverage of `PyObject_Print` is blocked due to a failing pipeline. After investigation, the test that is failing is associated with the Address Sanitizer. In particular, it fails the test that covers the aforementioned section. It consists in passing an object (specifically a Python string) with its reference counter set to zero and comparing the output string to the expected result: https://github.com/MonadChains/cpython/blob/562b9d26db7e766741c954146d4423eda414d2f6/Modules/_testcapimodule.c#L2053-L2080\r\nHowever, when the reference counter of the object goes to zero, it is deallocated, and the Address Sanitizer does not like it.\r\nAfter the discussion in https://mail.python.org/archives/list/core-mentorship@python.org/thread/7BP55KL6VB3H2ZZ5JZP2NV6RX72HBUCC/, a possible solution to this is to clean up the function and remove this section entirely. Normally this kind of check is performed only in specific situations like for example `_Py_ForgetReference` or `Py_DECREF` so it seems a bit weird to have it in `PyObject_Print`. \r\nAlternatively, another solution could be to remove the failing test from the PR and don't cover this section of the function.\r\n\n\n\u003c!-- gh-pr-number: gh-98929 --\u003e\n* PR: gh-98929\n\u003c!-- /gh-pr-number --\u003e\n","author":{"url":"https://github.com/MonadChains","@type":"Person","name":"MonadChains"},"datePublished":"2022-10-31T21:56:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/98928/cpython/issues/98928"}