René's URL Explorer Experiment


Title: Remove Dead Code in PyObject_Print · Issue #98421 · python/cpython · GitHub

Open Graph Title: Remove Dead Code in PyObject_Print · Issue #98421 · python/cpython

X Title: Remove Dead Code in PyObject_Print · Issue #98421 · python/cpython

Description: Bug report While working on covering PyObject_Print, I noticed that I couldn't hit some lines with any test. Specifically, the part that checks the type of the representation of the object returned by PyObject_Str or PyObject_Repr: cpyth...

Open Graph Description: Bug report While working on covering PyObject_Print, I noticed that I couldn't hit some lines with any test. Specifically, the part that checks the type of the representation of the object returned...

X Description: Bug report While working on covering PyObject_Print, I noticed that I couldn't hit some lines with any test. Specifically, the part that checks the type of the representation of the object retu...

Opengraph URL: https://github.com/python/cpython/issues/98421

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove Dead Code in PyObject_Print","articleBody":"# Bug report\r\n\r\nWhile working on covering `PyObject_Print`, I noticed that I couldn't hit some lines with any test. Specifically, the part that checks the type of the representation of the object returned by `PyObject_Str` or `PyObject_Repr`:\r\nhttps://github.com/python/cpython/blob/f4ead4874b558efa6379e3a130b0c491fec3acb1/Objects/object.c#L280-L308\r\n\r\nAs pointed out by @encukou, both aforementioned functions already check and **ensure** that the return type is a Python string:\r\nhttps://github.com/python/cpython/blob/f4ead4874b558efa6379e3a130b0c491fec3acb1/Objects/object.c#L492-L498\r\nhttps://github.com/python/cpython/blob/f4ead4874b558efa6379e3a130b0c491fec3acb1/Objects/object.c#L433-L439\r\n\r\nSo it is possible to simplify the function by excluding the useless checks of types diffent from Python string.\r\n\r\n","author":{"url":"https://github.com/MonadChains","@type":"Person","name":"MonadChains"},"datePublished":"2022-10-18T23:16:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/98421/cpython/issues/98421"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e7073503-c91d-8810-ffd6-926a3e51454e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id93A8:11D50D:A2A61F:D8F761:696991C3
html-safe-nonce3f50eec65cc1e71fd54f62b5d26316f6119dbc8226925b0d44e7d40bc055a2e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0E4OjExRDUwRDpBMkE2MUY6RDhGNzYxOjY5Njk5MUMzIiwidmlzaXRvcl9pZCI6IjczNDA1NzA0Mjc0NTg2ODc0MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac043f1bd12416284b422a872b6c3f9c434b2bb01d5b56483baa9e199d8ee78758
hovercard-subject-tagissue:1413958829
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/98421/issue_layout
twitter:imagehttps://opengraph.githubassets.com/80ebebda61f80c817c05be224f1ba289a6eb22f27dee2113cd5afad8125a943e/python/cpython/issues/98421
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/80ebebda61f80c817c05be224f1ba289a6eb22f27dee2113cd5afad8125a943e/python/cpython/issues/98421
og:image:altBug report While working on covering PyObject_Print, I noticed that I couldn't hit some lines with any test. Specifically, the part that checks the type of the representation of the object returned...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMonadChains
hostnamegithub.com
expected-hostnamegithub.com
None3542e147982176a7ebaa23dfb559c8af16f721c03ec560c68c56b64a0f35e751
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaf80af7cc9e3de9c336f18b208a600950a3c187c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/98421#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F98421
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F98421
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/98421
Reloadhttps://github.com/python/cpython/issues/98421
Reloadhttps://github.com/python/cpython/issues/98421
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/98421
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/issues/98421
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/98421
New issuehttps://github.com/login?return_to=https://github.com/python/cpython/issues/98421
Remove Dead Code in PyObject_Printhttps://github.com/python/cpython/issues/98421#top
https://github.com/MonadChains
https://github.com/MonadChains
MonadChainshttps://github.com/MonadChains
on Oct 18, 2022https://github.com/python/cpython/issues/98421#issue-1413958829
cpython/Objects/object.chttps://github.com/python/cpython/blob/f4ead4874b558efa6379e3a130b0c491fec3acb1/Objects/object.c#L280-L308
f4ead48https://github.com/python/cpython/commit/f4ead4874b558efa6379e3a130b0c491fec3acb1
@encukouhttps://github.com/encukou
cpython/Objects/object.chttps://github.com/python/cpython/blob/f4ead4874b558efa6379e3a130b0c491fec3acb1/Objects/object.c#L492-L498
f4ead48https://github.com/python/cpython/commit/f4ead4874b558efa6379e3a130b0c491fec3acb1
cpython/Objects/object.chttps://github.com/python/cpython/blob/f4ead4874b558efa6379e3a130b0c491fec3acb1/Objects/object.c#L433-L439
f4ead48https://github.com/python/cpython/commit/f4ead4874b558efa6379e3a130b0c491fec3acb1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.