René's URL Explorer Experiment


Title: `pydoc` renders `from builtins.type` note, even if it is incorrect · Issue #97959 · python/cpython · GitHub

Open Graph Title: `pydoc` renders `from builtins.type` note, even if it is incorrect · Issue #97959 · python/cpython

X Title: `pydoc` renders `from builtins.type` note, even if it is incorrect · Issue #97959 · python/cpython

Description: While working on #97958 I've noticed that there's something strange with help() and classmethods. Take a look at this example: import pydoc class My: @classmethod def __init_subclass__(cls, *args, **kwargs): pass @classmethod def custom(...

Open Graph Description: While working on #97958 I've noticed that there's something strange with help() and classmethods. Take a look at this example: import pydoc class My: @classmethod def __init_subclass__(cls, *args, ...

X Description: While working on #97958 I've noticed that there's something strange with help() and classmethods. Take a look at this example: import pydoc class My: @classmethod def __init_subclass__(cls,...

Opengraph URL: https://github.com/python/cpython/issues/97959

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`pydoc` renders `from builtins.type` note, even if it is incorrect","articleBody":"While working on https://github.com/python/cpython/pull/97958 I've noticed that there's something strange with `help()` and `classmethod`s.\r\n\r\nTake a look at this example:\r\n\r\n```python\r\nimport pydoc\r\n\r\nclass My:\r\n    @classmethod\r\n    def __init_subclass__(cls, *args, **kwargs):\r\n        pass\r\n\r\n    @classmethod\r\n    def custom(cls):\r\n        pass\r\n\r\nprint(pydoc.plain(pydoc.render_doc(My)))\r\n```\r\n\r\nIt prints:\r\n\r\n```\r\nPython Library Documentation: class My in module __main__\r\n\r\nclass My(builtins.object)\r\n |  Class methods defined here:\r\n |\r\n |  __init_subclass__(*args, **kwargs) from builtins.type\r\n |      This method is called when a class is subclassed.\r\n |\r\n |      The default implementation does nothing. It may be\r\n |      overridden to extend subclasses.\r\n |\r\n |  custom() from builtins.type\r\n |\r\n |  ----------------------------------------------------------------------\r\n |  Data descriptors defined here:\r\n |\r\n |  __dict__\r\n |      dictionary for instance variables (if defined)\r\n |\r\n |  __weakref__\r\n |      list of weak references to the object (if defined)\r\n```\r\n\r\nTake a look at these two entries:\r\n1. `__init_subclass__(*args, **kwargs) from builtins.type`\r\n2. `custom() from builtins.type`\r\n\r\nWhile `type` has `__init_subclass__`, there's no `type.custom`. But, `help` says that there is!\r\n\r\n```python\r\n\u003e\u003e\u003e type.__init_subclass__\r\n\u003cbuilt-in method __init_subclass__ of type object at 0x10a50c360\u003e\r\n\u003e\u003e\u003e type.custom\r\nTraceback (most recent call last):\r\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\r\nAttributeError: type object 'type' has no attribute 'custom'\r\n```\r\n\r\nI think that it is incorrect and can lead to confusion.\r\nInstead it should be:\r\n\r\n```\r\n |  __init_subclass__(*args, **kwargs) from builtins.type\r\n |      This method is called when a class is subclassed.\r\n |\r\n |      The default implementation does nothing. It may be\r\n |      overridden to extend subclasses.\r\n |\r\n |  custom()\r\n```\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-98120\n* gh-113941\n* gh-115296\n* gh-115302\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2022-10-06T12:08:05.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":9},"url":"https://github.com/97959/cpython/issues/97959"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:15c2e50c-45df-2461-5d7e-40a0d104115d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idEBB8:29C2E1:32E5C:4102A:6A532488
html-safe-nonce2fc36de815144136c7df996f9b2d11bbf7176049f2d01847bc14c083a7d3cc36
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkI4OjI5QzJFMTozMkU1Qzo0MTAyQTo2QTUzMjQ4OCIsInZpc2l0b3JfaWQiOiIzMjAyODAxODQyMjAwNDU0MjgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2eaf5b442e05462ea35f330de9e4fa93cc975bacb0c747ce00d4d477dea5374e
hovercard-subject-tagissue:1399483876
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/97959/issue_layout
twitter:imagehttps://opengraph.githubassets.com/745d2ad735bb6ae93071091d1a893d83f65954ade1337182dfd31b47e2e459ea/python/cpython/issues/97959
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/745d2ad735bb6ae93071091d1a893d83f65954ade1337182dfd31b47e2e459ea/python/cpython/issues/97959
og:image:altWhile working on #97958 I've noticed that there's something strange with help() and classmethods. Take a look at this example: import pydoc class My: @classmethod def __init_subclass__(cls, *args, ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/issues/97959#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F97959
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F97959
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/issues/97959
Reloadhttps://github.com/python/cpython/issues/97959
Reloadhttps://github.com/python/cpython/issues/97959
Please reload this pagehttps://github.com/python/cpython/issues/97959
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/issues/97959
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
pydoc renders from builtins.type note, even if it is incorrecthttps://github.com/python/cpython/issues/97959#top
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Oct 6, 2022https://github.com/python/cpython/issues/97959#issue-1399483876
#97958https://github.com/python/cpython/pull/97958
gh-97959: [pydoc] now help() does not show extra notes for classmethods #98120https://github.com/python/cpython/pull/98120
gh-97959: Fix rendering of routines in pydoc #113941https://github.com/python/cpython/pull/113941
[3.12] gh-97959: Fix rendering of routines in pydoc (GH-113941) #115296https://github.com/python/cpython/pull/115296
[3.11] [3.12] gh-97959: Fix rendering of routines in pydoc (GH-113941) (GH-115296) #115302https://github.com/python/cpython/pull/115302
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.