René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[tests] When test_venv.test_with_pip() fails, a bug in error handling fails to display stderr","articleBody":"https://buildbot.python.org/all/#/builders/719/builds/1696\r\n\r\n```\r\nERROR: test_with_pip (test.test_venv.EnsurePipTest.test_with_pip)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/buildbot/buildarea/3.x.pablogsal-arch-x86_64.clang-ubsan/build/Lib/test/test_venv.py\", line 660, in nicer_error\r\n    yield\r\n  File \"/buildbot/buildarea/3.x.pablogsal-arch-x86_64.clang-ubsan/build/Lib/test/test_venv.py\", line 595, in do_test_with_pip\r\n    self.run_with_capture(venv.create, self.env_dir,\r\n  File \"/buildbot/buildarea/3.x.pablogsal-arch-x86_64.clang-ubsan/build/Lib/test/test_venv.py\", line 87, in run_with_capture\r\n    func(*args, **kwargs)\r\n  File \"/buildbot/buildarea/3.x.pablogsal-arch-x86_64.clang-ubsan/build/Lib/venv/__init__.py\", line 459, in create\r\n    builder.create(env_dir)\r\n  File \"/buildbot/buildarea/3.x.pablogsal-arch-x86_64.clang-ubsan/build/Lib/venv/__init__.py\", line 76, in create\r\n    self._setup_pip(context)\r\n  File \"/buildbot/buildarea/3.x.pablogsal-arch-x86_64.clang-ubsan/build/Lib/venv/__init__.py\", line 349, in _setup_pip\r\n    subprocess.check_output(cmd, stderr=subprocess.STDOUT)\r\n  File \"/buildbot/buildarea/3.x.pablogsal-arch-x86_64.clang-ubsan/build/Lib/subprocess.py\", line 465, in check_output\r\n    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,\r\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"/buildbot/buildarea/3.x.pablogsal-arch-x86_64.clang-ubsan/build/Lib/subprocess.py\", line 569, in run\r\n    raise CalledProcessError(retcode, process.args,\r\nsubprocess.CalledProcessError: Command '['/tmp/test_python_92rnuaxl/tmpkaiesc24/bin/python', '-Im', 'ensurepip', '--upgrade', '--default-pip']' returned non-zero exit status 1.\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File \"/buildbot/buildarea/3.x.pablogsal-arch-x86_64.clang-ubsan/build/Lib/test/test_venv.py\", line 672, in test_with_pip\r\n    self.do_test_with_pip(False)\r\n  File \"/buildbot/buildarea/3.x.pablogsal-arch-x86_64.clang-ubsan/build/Lib/test/test_venv.py\", line 594, in do_test_with_pip\r\n    with self.nicer_error():\r\n  File \"/buildbot/buildarea/3.x.pablogsal-arch-x86_64.clang-ubsan/build/Lib/contextlib.py\", line 155, in __exit__\r\n    self.gen.throw(value)\r\n  File \"/buildbot/buildarea/3.x.pablogsal-arch-x86_64.clang-ubsan/build/Lib/test/test_venv.py\", line 663, in nicer_error\r\n    err = exc.stderr.decode(errors=\"replace\")\r\n          ^^^^^^^^^^^^^^^^^\r\nAttributeError: 'NoneType' object has no attribute 'decode'\r\n```","author":{"url":"https://github.com/vstinner","@type":"Person","name":"vstinner"},"datePublished":"2022-10-03T14:01:43.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/97764/cpython/issues/97764"}