Title: Dead code in `CALL_FUNCTION_EX` opcode handler · Issue #96751 · python/cpython · GitHub
Open Graph Title: Dead code in `CALL_FUNCTION_EX` opcode handler · Issue #96751 · python/cpython
X Title: Dead code in `CALL_FUNCTION_EX` opcode handler · Issue #96751 · python/cpython
Description: I am talking about these lines: cpython/Python/ceval.c Lines 4722 to 4734 in a36235d if (!PyDict_CheckExact(kwargs)) { PyObject *d = PyDict_New(); if (d == NULL) goto error; if (_PyDict_MergeEx(d, kwargs, 2) < 0) { Py_DECREF(d); format_k...
Open Graph Description: I am talking about these lines: cpython/Python/ceval.c Lines 4722 to 4734 in a36235d if (!PyDict_CheckExact(kwargs)) { PyObject *d = PyDict_New(); if (d == NULL) goto error; if (_PyDict_MergeEx(d, ...
X Description: I am talking about these lines: cpython/Python/ceval.c Lines 4722 to 4734 in a36235d if (!PyDict_CheckExact(kwargs)) { PyObject *d = PyDict_New(); if (d == NULL) goto error; if (_PyDict_MergeEx(d, ...
Opengraph URL: https://github.com/python/cpython/issues/96751
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Dead code in `CALL_FUNCTION_EX` opcode handler","articleBody":"I am talking about these lines:\r\nhttps://github.com/python/cpython/blob/a36235d5c7863a85fa323b2048d3d254116a958e/Python/ceval.c#L4722-L4734\r\n\r\nThey are not ever called, because after https://github.com/python/cpython/pull/18141 all `**` dict unpacking is handled in `DICT_MERGE` opcode.\r\n\r\nThis was found while working on https://github.com/python/cpython/issues/94808 but I think that it deserves a separate issue.\r\n\r\nPR is on its way.","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2022-09-11T09:43:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/96751/cpython/issues/96751"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:dd76f439-a453-98c2-b4c8-d06417698019 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AB02:37CCD2:106A679:161DB99:696AD062 |
| html-safe-nonce | d0c39db34109b7bd0369e91d7f2db05d37899536101c0869c1c4b8dc1dfd125b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjAyOjM3Q0NEMjoxMDZBNjc5OjE2MURCOTk6Njk2QUQwNjIiLCJ2aXNpdG9yX2lkIjoiNDkxMTM3Mzk1NjA0OTE5NTEwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 13e22e127d992891994a12790510742b64b773208289a915f444a325a3c1e1d6 |
| hovercard-subject-tag | issue:1368890506 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/96751/issue_layout |
| twitter:image | https://opengraph.githubassets.com/80f9707daeb58b6b679dea8743d825ee99dc746fb7944b21cf474f73b91a373c/python/cpython/issues/96751 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/80f9707daeb58b6b679dea8743d825ee99dc746fb7944b21cf474f73b91a373c/python/cpython/issues/96751 |
| og:image:alt | I am talking about these lines: cpython/Python/ceval.c Lines 4722 to 4734 in a36235d if (!PyDict_CheckExact(kwargs)) { PyObject *d = PyDict_New(); if (d == NULL) goto error; if (_PyDict_MergeEx(d, ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | c785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c718a376fcf780eb22089171adb84a543f660bf7 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width