Title: Redundant NULL check in profile_trampoline function (sysmodule.c) · Issue #96715 · python/cpython · GitHub
Open Graph Title: Redundant NULL check in profile_trampoline function (sysmodule.c) · Issue #96715 · python/cpython
X Title: Redundant NULL check in profile_trampoline function (sysmodule.c) · Issue #96715 · python/cpython
Description: Code in profile_trampoline function checks if arg argument value is equal to NULL and in this case assigns Py_None to it cpython/Python/sysmodule.c Lines 954 to 956 in 88a7f66 if (arg == NULL) { arg = Py_None; } The only place where arg ...
Open Graph Description: Code in profile_trampoline function checks if arg argument value is equal to NULL and in this case assigns Py_None to it cpython/Python/sysmodule.c Lines 954 to 956 in 88a7f66 if (arg == NULL) { ar...
X Description: Code in profile_trampoline function checks if arg argument value is equal to NULL and in this case assigns Py_None to it cpython/Python/sysmodule.c Lines 954 to 956 in 88a7f66 if (arg == NULL) { ar...
Opengraph URL: https://github.com/python/cpython/issues/96715
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Redundant NULL check in profile_trampoline function (sysmodule.c)","articleBody":"Code in `profile_trampoline` function checks if `arg` argument value is equal to `NULL` and in this case assigns `Py_None` to it\r\nhttps://github.com/python/cpython/blob/88a7f661ca02c0eb76b8f19234b8293b70f171e2/Python/sysmodule.c#L954-L956\r\nThe only place where `arg` is used in `profile_trampoline` is this call\r\nhttps://github.com/python/cpython/blob/88a7f661ca02c0eb76b8f19234b8293b70f171e2/Python/sysmodule.c#L959\r\nBut similar check is already done by `call_trampoline` function\r\nhttps://github.com/python/cpython/blob/88a7f661ca02c0eb76b8f19234b8293b70f171e2/Python/sysmodule.c#L930\r\n\r\nMy suggestion is to remove excess check from `profile_trampoline`.\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-96716\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/chgnrdv","@type":"Person","name":"chgnrdv"},"datePublished":"2022-09-09T15:25:34.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/96715/cpython/issues/96715"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:66538403-f89b-5881-a6b6-099fd928bb09 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CCF6:37C592:778DC9:9E2329:69697918 |
| html-safe-nonce | d5eeea3c8cb0fdbc4a3bc3c03a793f86c7df636b6af1ab9981f529f8e65df891 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0Y2OjM3QzU5Mjo3NzhEQzk6OUUyMzI5OjY5Njk3OTE4IiwidmlzaXRvcl9pZCI6IjMyNTM2Mjc5MDUzNDU0MTk1NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b54f4a6451088cf87d9d3df082707c2475b1254578662d80a78d9bc7cd3c6569 |
| hovercard-subject-tag | issue:1367989067 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/96715/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1cfa62d311cf7c484f0f88058160a986f59276a8f480b214843cd77ff8928610/python/cpython/issues/96715 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1cfa62d311cf7c484f0f88058160a986f59276a8f480b214843cd77ff8928610/python/cpython/issues/96715 |
| og:image:alt | Code in profile_trampoline function checks if arg argument value is equal to NULL and in this case assigns Py_None to it cpython/Python/sysmodule.c Lines 954 to 956 in 88a7f66 if (arg == NULL) { ar... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | chgnrdv |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6f193beb8ff08443adc07685d75302ab8aaf0a135f6e251c3ff3112c8deb881 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 212e3e3d3298bf5b313830edfd2399e869f7ea76 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width